From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rajesh Mudimadugula <rmudimadugul@marvell.com>
Cc: qemu-devel@nongnu.org, pizhenwei@bytedance.com, gmuthukrishn@marvell.com
Subject: Re: [PATCH] vhost-user: enable asym capabilities for user backend
Date: Sun, 13 Jul 2025 16:49:17 -0400 [thread overview]
Message-ID: <20250713164654-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20250626122451.908205-1-rmudimadugul@marvell.com>
On Thu, Jun 26, 2025 at 12:24:51PM +0000, Rajesh Mudimadugula wrote:
> This patch enables and advertises asym capabilties
> for backend user application.
>
> Signed-off-by: Rajesh Mudimadugula <rmudimadugul@marvell.com>
You want to CC all maintainers really.
The commit log also should include motivation for each change,
not just repeat what the patch does.
As a nit, format it using an imperative mood:
"...enable and advertise..."
> ---
> backends/cryptodev-vhost-user.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
> index cb04e68b02..f9dec14a4a 100644
> --- a/backends/cryptodev-vhost-user.c
> +++ b/backends/cryptodev-vhost-user.c
> @@ -230,6 +230,9 @@ static void cryptodev_vhost_user_init(
> backend->conf.max_size = UINT64_MAX;
> backend->conf.max_cipher_key_len = VHOST_USER_MAX_CIPHER_KEY_LEN;
> backend->conf.max_auth_key_len = VHOST_USER_MAX_AUTH_KEY_LEN;
> + backend->conf.crypto_services |=
> + 1u << QCRYPTODEV_BACKEND_SERVICE_TYPE_AKCIPHER;
> + backend->conf.akcipher_algo = 1u << VIRTIO_CRYPTO_AKCIPHER_RSA;
> }
>
> static int64_t cryptodev_vhost_user_crypto_create_session(
> --
> 2.34.1
prev parent reply other threads:[~2025-07-13 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 12:24 [PATCH] vhost-user: enable asym capabilities for user backend Rajesh Mudimadugula
2025-07-13 20:49 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250713164654-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=gmuthukrishn@marvell.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-devel@nongnu.org \
--cc=rmudimadugul@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).