qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	peter.maydell@linaro.org, imammedo@redhat.com,
	Jonathan.Cameron@huawei.com, gustavo.romero@linaro.org,
	anisinha@redhat.com, mst@redhat.com, shannon.zhaosl@gmail.com
Cc: pbonzini@redhat.com, philmd@linaro.org, alex.bennee@linaro.org
Subject: [PATCH v7 26/36] hw/acpi/ged: Call pcihp plug callbacks in hotplug handler implementation
Date: Mon, 14 Jul 2025 10:05:10 +0200	[thread overview]
Message-ID: <20250714080639.2525563-27-eric.auger@redhat.com> (raw)
In-Reply-To: <20250714080639.2525563-1-eric.auger@redhat.com>

Add PCI device related code in the TYPE_HOTPLUG_HANDLER
implementation.

For a PCI device hotplug/hotunplug event, the code routes to
acpi_pcihp_device callbacks (pre_plug_cb, plug_cb, unplug_request_cb,
unplug_cb).

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

---

v2 -> v4:
moved before "hw/acpi/ged: Prepare the device to react to PCI hotplug
events" (Igor)

v2 -> v3:
- remove else block in acpi_ged_device_pre_plug_cb
---
 hw/acpi/generic_event_device.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
index ef1c1ec51f..92b931758f 100644
--- a/hw/acpi/generic_event_device.c
+++ b/hw/acpi/generic_event_device.c
@@ -17,6 +17,7 @@
 #include "hw/irq.h"
 #include "hw/mem/pc-dimm.h"
 #include "hw/mem/nvdimm.h"
+#include "hw/pci/pci_device.h"
 #include "hw/qdev-properties.h"
 #include "migration/vmstate.h"
 #include "qemu/error-report.h"
@@ -228,6 +229,14 @@ static const MemoryRegionOps ged_regs_ops = {
     },
 };
 
+static void acpi_ged_device_pre_plug_cb(HotplugHandler *hotplug_dev,
+                                        DeviceState *dev, Error **errp)
+{
+    if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
+        acpi_pcihp_device_pre_plug_cb(hotplug_dev, dev, errp);
+    }
+}
+
 static void acpi_ged_device_plug_cb(HotplugHandler *hotplug_dev,
                                     DeviceState *dev, Error **errp)
 {
@@ -241,6 +250,8 @@ static void acpi_ged_device_plug_cb(HotplugHandler *hotplug_dev,
         }
     } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
         acpi_cpu_plug_cb(hotplug_dev, &s->cpuhp_state, dev, errp);
+    } else if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
+        acpi_pcihp_device_plug_cb(hotplug_dev, &s->pcihp_state, dev, errp);
     } else {
         error_setg(errp, "virt: device plug request for unsupported device"
                    " type: %s", object_get_typename(OBJECT(dev)));
@@ -257,6 +268,9 @@ static void acpi_ged_unplug_request_cb(HotplugHandler *hotplug_dev,
         acpi_memory_unplug_request_cb(hotplug_dev, &s->memhp_state, dev, errp);
     } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
         acpi_cpu_unplug_request_cb(hotplug_dev, &s->cpuhp_state, dev, errp);
+    } else if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
+        acpi_pcihp_device_unplug_request_cb(hotplug_dev, &s->pcihp_state,
+                                            dev, errp);
     } else {
         error_setg(errp, "acpi: device unplug request for unsupported device"
                    " type: %s", object_get_typename(OBJECT(dev)));
@@ -272,6 +286,8 @@ static void acpi_ged_unplug_cb(HotplugHandler *hotplug_dev,
         acpi_memory_unplug_cb(&s->memhp_state, dev, errp);
     } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
         acpi_cpu_unplug_cb(&s->cpuhp_state, dev, errp);
+    } else if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
+        acpi_pcihp_device_unplug_cb(hotplug_dev, &s->pcihp_state, dev, errp);
     } else {
         error_setg(errp, "acpi: device unplug for unsupported device"
                    " type: %s", object_get_typename(OBJECT(dev)));
@@ -485,6 +501,7 @@ static void acpi_ged_class_init(ObjectClass *class, const void *data)
     dc->vmsd = &vmstate_acpi_ged;
     dc->realize = acpi_ged_realize;
 
+    hc->pre_plug = acpi_ged_device_pre_plug_cb;
     hc->plug = acpi_ged_device_plug_cb;
     hc->unplug_request = acpi_ged_unplug_request_cb;
     hc->unplug = acpi_ged_unplug_cb;
-- 
2.49.0



  parent reply	other threads:[~2025-07-14  8:28 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14  8:04 [PATCH v7 00/36] ACPI PCI Hotplug support on ARM Eric Auger
2025-07-14  8:04 ` [PATCH v7 01/36] hw/i386/acpi-build: Make aml_pci_device_dsm() static Eric Auger
2025-07-14  8:04 ` [PATCH v7 02/36] hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp Eric Auger
2025-07-14  8:04 ` [PATCH v7 03/36] hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to acpi_dsdt_add_pci_osc Eric Auger
2025-07-14  8:04 ` [PATCH v7 04/36] tests/qtest/bios-tables-test: Prepare for changes in the DSDT table Eric Auger
2025-07-14  8:04 ` [PATCH v7 05/36] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation Eric Auger
2025-07-14  8:04 ` [PATCH v7 06/36] hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property Eric Auger
2025-07-14  8:04 ` [PATCH v7 07/36] hw/pci-host/gpex-acpi: Use GED acpi pcihp property Eric Auger
2025-07-14  8:04 ` [PATCH v7 08/36] hw/i386/acpi-build: Turn build_q35_osc_method into a generic method Eric Auger
2025-07-14  8:04 ` [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method Eric Auger
2025-07-27 11:48   ` Michael Tokarev
2025-07-28  9:07     ` Michael Tokarev
2025-07-28 14:56       ` Eric Auger
2025-07-28 15:17         ` Michael Tokarev
2025-07-28 15:29           ` Michael Tokarev
2025-07-28 15:34           ` Eric Auger
2025-08-01 12:29         ` Michael S. Tsirkin
2025-08-03 16:49           ` Eric Auger
2025-08-04  6:29             ` Michael Tokarev
2025-08-04 15:27               ` Eric Auger
2025-07-14  8:04 ` [PATCH v7 10/36] tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change Eric Auger
2025-07-14  8:04 ` [PATCH v7 11/36] hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper Eric Auger
2025-07-14  8:04 ` [PATCH v7 12/36] hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug Eric Auger
2025-07-14  8:04 ` [PATCH v7 13/36] hw/i386/acpi-build: Move build_append_notification_callback to pcihp Eric Auger
2025-07-14  8:04 ` [PATCH v7 14/36] hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots " Eric Auger
2025-07-14  8:04 ` [PATCH v7 15/36] hw/i386/acpi-build: Use AcpiPciHpState::root in acpi_set_pci_info Eric Auger
2025-07-14  8:05 ` [PATCH v7 16/36] hw/i386/acpi-build: Move aml_pci_edsm to a generic place Eric Auger
2025-07-14  8:05 ` [PATCH v7 17/36] qtest/bios-tables-test: Prepare for fixing the aarch64 viot test Eric Auger
2025-07-14  8:05 ` [PATCH v7 18/36] qtest/bios-tables-test: Add a variant to " Eric Auger
2025-07-14  8:05 ` [PATCH v7 19/36] qtest/bios-tables-test: Generate DSDT.viot Eric Auger
2025-07-14  8:05 ` [PATCH v7 20/36] tests/qtest/bios-tables-test: Prepare for changes in the arm virt DSDT table Eric Auger
2025-07-14  8:05 ` [PATCH v7 21/36] hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index Eric Auger
2025-07-14  8:05 ` [PATCH v7 22/36] tests/qtest/bios-tables-test: Update ARM DSDT reference blobs Eric Auger
2025-07-14  8:05 ` [PATCH v7 23/36] hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug Eric Auger
2025-07-14  8:05 ` [PATCH v7 24/36] hw/acpi/ged: Add a bus link property Eric Auger
2025-07-14  8:05 ` [PATCH v7 25/36] hw/arm/virt: Pass the bus on the ged creation Eric Auger
2025-07-14  8:05 ` Eric Auger [this message]
2025-07-14  8:05 ` [PATCH v7 27/36] hw/acpi/pcihp: Remove root arg in acpi_pcihp_init Eric Auger
2025-07-14  8:05 ` [PATCH v7 28/36] hw/acpi/ged: Prepare the device to react to PCI hotplug events Eric Auger
2025-07-14  8:05 ` [PATCH v7 29/36] hw/acpi/ged: Support migration of AcpiPciHpState Eric Auger
2025-07-14  8:05 ` [PATCH v7 30/36] hw/core/sysbus: Introduce sysbus_mmio_map_name() helper Eric Auger
2025-07-14  8:05 ` [PATCH v7 31/36] hw/arm/virt: Minor code reshuffling in create_acpi_ged Eric Auger
2025-07-14  8:05 ` [PATCH v7 32/36] hw/arm/virt: Let virt support pci hotplug/unplug GED event Eric Auger
2025-07-14  8:05 ` [PATCH v7 33/36] tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp tests Eric Auger
2025-07-14  8:05 ` [PATCH v7 34/36] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test Eric Auger
2025-07-14  8:05 ` [PATCH v7 35/36] qtest/bios-tables-test: Generate reference blob for DSDT.hpoffacpiindex Eric Auger
2025-07-14  8:05 ` [PATCH v7 36/36] qtest/bios-tables-test: Generate reference blob for DSDT.acpipcihp Eric Auger
2025-07-14 19:40 ` [PATCH v7 00/36] ACPI PCI Hotplug support on ARM Jonathan Cameron via
2025-07-14 19:46   ` Eric Auger
2025-07-14 19:51   ` Eric Auger
2025-07-14 23:56     ` Michael S. Tsirkin
2025-07-15  8:53       ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250714080639.2525563-27-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alex.bennee@linaro.org \
    --cc=anisinha@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=gustavo.romero@linaro.org \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhaosl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).