qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com,
	"Vivek Kasireddy" <vivek.kasireddy@intel.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	"Frediano Ziglio" <freddy77@gmail.com>,
	"Dongwon Kim" <dongwon.kim@intel.com>,
	"Michael Scherle" <michael.scherle@rz.uni-freiburg.de>
Subject: [PULL v2 03/13] ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()
Date: Tue, 15 Jul 2025 10:32:49 +0400	[thread overview]
Message-ID: <20250715063301.145191-4-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20250715063301.145191-1-marcandre.lureau@redhat.com>

From: Vivek Kasireddy <vivek.kasireddy@intel.com>

While trying to export and obtain fds associated with a texture, it
is possible that the fds returned after eglExportDMABUFImageMESA()
call have error values. Therefore, we need to evaluate the value of
all fds and return false if any of them are negative.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Frediano Ziglio <freddy77@gmail.com>
Cc: Dongwon Kim <dongwon.kim@intel.com>
Cc: Michael Scherle <michael.scherle@rz.uni-freiburg.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Message-Id: <20250617043546.1022779-2-vivek.kasireddy@intel.com>
---
 ui/egl-helpers.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
index 5503a795e4..e3f2872cc1 100644
--- a/ui/egl-helpers.c
+++ b/ui/egl-helpers.c
@@ -295,6 +295,7 @@ bool egl_dmabuf_export_texture(uint32_t tex_id, int *fd, EGLint *offset,
 {
     EGLImageKHR image;
     EGLuint64KHR modifiers[DMABUF_MAX_PLANES];
+    int i;
 
     image = eglCreateImageKHR(qemu_egl_display, eglGetCurrentContext(),
                               EGL_GL_TEXTURE_2D_KHR,
@@ -314,6 +315,11 @@ bool egl_dmabuf_export_texture(uint32_t tex_id, int *fd, EGLint *offset,
         *modifier = modifiers[0];
     }
 
+    for (i = 0; i < *num_planes; i++) {
+        if (fd[i] < 0) {
+            return false;
+        }
+    }
     return true;
 }
 
-- 
2.50.0



  parent reply	other threads:[~2025-07-15  6:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15  6:32 [PULL v2 00/13] Ui patches marcandre.lureau
2025-07-15  6:32 ` [PULL v2 01/13] ui/vnc: Do not copy z_stream marcandre.lureau
2025-07-16 15:07   ` Michael Tokarev
2025-07-16 15:49     ` Daniel P. Berrangé
2025-07-15  6:32 ` [PULL v2 02/13] ui/vnc: Introduce the VncWorker type marcandre.lureau
2025-07-15  6:32 ` marcandre.lureau [this message]
2025-07-15  6:32 ` [PULL v2 04/13] ui/spice: Enable gl=on option for non-local or remote clients marcandre.lureau
2025-07-15  6:32 ` [PULL v2 05/13] ui/spice: Add an option for users to provide a preferred video codec marcandre.lureau
2025-07-15  6:32 ` [PULL v2 06/13] ui/spice: Add an option to submit gl_draw requests at fixed rate marcandre.lureau
2025-07-15  6:32 ` [PULL v2 07/13] ui/console-gl: Add a helper to create a texture with linear memory layout marcandre.lureau
2025-07-15  6:32 ` [PULL v2 08/13] ui/spice: Create a new texture with linear layout when gl=on is specified marcandre.lureau
2025-07-15  6:32 ` [PULL v2 09/13] ui/spice: Blit the scanout texture if its memory layout is not linear marcandre.lureau
2025-07-17  9:23   ` Peter Maydell
2025-07-17 18:17     ` Kasireddy, Vivek
2025-07-15  6:32 ` [PULL v2 10/13] hw/display: Allow injection of virtio-gpu EDID name marcandre.lureau
2025-07-15  6:32 ` [PULL v2 11/13] ui/gtk: Add keep-aspect-ratio option marcandre.lureau
2025-07-15  6:32 ` [PULL v2 12/13] ui/gtk: Add scale option marcandre.lureau
2025-07-15  6:32 ` [PULL v2 13/13] tpm: "qemu -tpmdev help" should return success marcandre.lureau
2025-07-15  6:38 ` [PULL v2 00/13] Ui patches Marc-André Lureau
2025-07-16 12:40 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715063301.145191-4-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=dongwon.kim@intel.com \
    --cc=freddy77@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=michael.scherle@rz.uni-freiburg.de \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).