qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header
@ 2025-07-15  7:15 Philippe Mathieu-Daudé
  2025-07-15  7:26 ` Xiaoyao Li
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-07-15  7:15 UTC (permalink / raw)
  To: qemu-devel
  Cc: Anthony PERARD, Pierrick Bouvier, Richard Henderson,
	David Woodhouse, Peter Maydell, Paul Durrant, Edgar E. Iglesias,
	qemu-arm, xen-devel, Stefano Stabellini,
	Philippe Mathieu-Daudé, Xiaoyao Li

"hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and
arch_xen_set_memory() prototypes, which are not used by xen-pvh.c.
Remove the unnecessary header inclusion.

Cc: Xiaoyao Li <xiaoyao.li@intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
Based-on: <20250513171737.74386-1-philmd@linaro.org>
---
 hw/arm/xen-pvh.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
index 4b26bcff7a5..1a9eeb01c8e 100644
--- a/hw/arm/xen-pvh.c
+++ b/hw/arm/xen-pvh.c
@@ -10,7 +10,6 @@
 #include "hw/boards.h"
 #include "system/system.h"
 #include "hw/xen/xen-pvh-common.h"
-#include "hw/xen/arch_hvm.h"
 
 #define TYPE_XEN_ARM  MACHINE_TYPE_NAME("xenpvh")
 
-- 
2.49.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header
  2025-07-15  7:15 [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header Philippe Mathieu-Daudé
@ 2025-07-15  7:26 ` Xiaoyao Li
  2025-07-15  7:41 ` Manos Pitsidianakis
  2025-07-15 19:25 ` Philippe Mathieu-Daudé
  2 siblings, 0 replies; 4+ messages in thread
From: Xiaoyao Li @ 2025-07-15  7:26 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Anthony PERARD, Pierrick Bouvier, Richard Henderson,
	David Woodhouse, Peter Maydell, Paul Durrant, Edgar E. Iglesias,
	qemu-arm, xen-devel, Stefano Stabellini

On 7/15/2025 3:15 PM, Philippe Mathieu-Daudé wrote:
> "hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and
> arch_xen_set_memory() prototypes, which are not used by xen-pvh.c.
> Remove the unnecessary header inclusion.
> 
> Cc: Xiaoyao Li <xiaoyao.li@intel.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>

> ---
> Based-on: <20250513171737.74386-1-philmd@linaro.org>
> ---
>   hw/arm/xen-pvh.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
> index 4b26bcff7a5..1a9eeb01c8e 100644
> --- a/hw/arm/xen-pvh.c
> +++ b/hw/arm/xen-pvh.c
> @@ -10,7 +10,6 @@
>   #include "hw/boards.h"
>   #include "system/system.h"
>   #include "hw/xen/xen-pvh-common.h"
> -#include "hw/xen/arch_hvm.h"
>   
>   #define TYPE_XEN_ARM  MACHINE_TYPE_NAME("xenpvh")
>   



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header
  2025-07-15  7:15 [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header Philippe Mathieu-Daudé
  2025-07-15  7:26 ` Xiaoyao Li
@ 2025-07-15  7:41 ` Manos Pitsidianakis
  2025-07-15 19:25 ` Philippe Mathieu-Daudé
  2 siblings, 0 replies; 4+ messages in thread
From: Manos Pitsidianakis @ 2025-07-15  7:41 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-devel, Anthony PERARD, Pierrick Bouvier, Richard Henderson,
	David Woodhouse, Peter Maydell, Paul Durrant, Edgar E. Iglesias,
	qemu-arm, xen-devel, Stefano Stabellini, Xiaoyao Li

On Tue, Jul 15, 2025 at 10:19 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> "hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and
> arch_xen_set_memory() prototypes, which are not used by xen-pvh.c.
> Remove the unnecessary header inclusion.
>
> Cc: Xiaoyao Li <xiaoyao.li@intel.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Based-on: <20250513171737.74386-1-philmd@linaro.org>
> ---
>  hw/arm/xen-pvh.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
> index 4b26bcff7a5..1a9eeb01c8e 100644
> --- a/hw/arm/xen-pvh.c
> +++ b/hw/arm/xen-pvh.c
> @@ -10,7 +10,6 @@
>  #include "hw/boards.h"
>  #include "system/system.h"
>  #include "hw/xen/xen-pvh-common.h"
> -#include "hw/xen/arch_hvm.h"
>
>  #define TYPE_XEN_ARM  MACHINE_TYPE_NAME("xenpvh")
>
> --
> 2.49.0
>
>

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header
  2025-07-15  7:15 [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header Philippe Mathieu-Daudé
  2025-07-15  7:26 ` Xiaoyao Li
  2025-07-15  7:41 ` Manos Pitsidianakis
@ 2025-07-15 19:25 ` Philippe Mathieu-Daudé
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-07-15 19:25 UTC (permalink / raw)
  To: qemu-devel
  Cc: Anthony PERARD, Pierrick Bouvier, Richard Henderson,
	David Woodhouse, Peter Maydell, Paul Durrant, Edgar E. Iglesias,
	qemu-arm, xen-devel, Stefano Stabellini, Xiaoyao Li

On 15/7/25 09:15, Philippe Mathieu-Daudé wrote:
> "hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and
> arch_xen_set_memory() prototypes, which are not used by xen-pvh.c.
> Remove the unnecessary header inclusion.
> 
> Cc: Xiaoyao Li <xiaoyao.li@intel.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Based-on: <20250513171737.74386-1-philmd@linaro.org>
> ---
>   hw/arm/xen-pvh.c | 1 -
>   1 file changed, 1 deletion(-)

Queued, thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-15 19:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15  7:15 [PATCH v2] hw/arm/xen-pvh: Remove unnecessary 'hw/xen/arch_hvm.h' header Philippe Mathieu-Daudé
2025-07-15  7:26 ` Xiaoyao Li
2025-07-15  7:41 ` Manos Pitsidianakis
2025-07-15 19:25 ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).