From: Mark Cave-Ayland <mark.caveayland@nutanix.com>
To: npiggin@gmail.com, danielhb413@gmail.com, harshpb@linux.ibm.com,
mjrosato@linux.ibm.com, farman@linux.ibm.com,
pasic@linux.ibm.com, borntraeger@linux.ibm.com, thuth@redhat.com,
richard.henderson@linaro.org, david@redhat.com,
iii@linux.ibm.com, john.levon@nutanix.com,
thanos.makatos@nutanix.com, alex.williamson@redhat.com,
clg@redhat.com, steven.sistare@oracle.com, tomitamoeko@gmail.com,
qemu-ppc@nongnu.org, qemu-s390x@nongnu.org,
qemu-devel@nongnu.org
Subject: [PATCH 06/22] vfio/spapr.c: use QOM casts where appropriate
Date: Tue, 15 Jul 2025 10:25:46 +0100 [thread overview]
Message-ID: <20250715093110.107317-7-mark.caveayland@nutanix.com> (raw)
In-Reply-To: <20250715093110.107317-1-mark.caveayland@nutanix.com>
Use QOM casts to convert between VFIOContainer and VFIOContainerBase instead
of accessing bcontainer directly.
Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
hw/vfio/spapr.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/vfio/spapr.c b/hw/vfio/spapr.c
index 564b70ef97..c41e4588d6 100644
--- a/hw/vfio/spapr.c
+++ b/hw/vfio/spapr.c
@@ -62,7 +62,7 @@ static void vfio_prereg_listener_region_add(MemoryListener *listener,
VFIOSpaprContainer *scontainer = container_of(listener, VFIOSpaprContainer,
prereg_listener);
VFIOContainer *container = &scontainer->container;
- VFIOContainerBase *bcontainer = &container->bcontainer;
+ VFIOContainerBase *bcontainer = VFIO_IOMMU(container);
const hwaddr gpa = section->offset_within_address_space;
hwaddr end;
int ret;
@@ -244,7 +244,7 @@ static bool vfio_spapr_create_window(VFIOContainer *container,
hwaddr *pgsize, Error **errp)
{
int ret = 0;
- VFIOContainerBase *bcontainer = &container->bcontainer;
+ VFIOContainerBase *bcontainer = VFIO_IOMMU(container);
VFIOSpaprContainer *scontainer = container_of(container, VFIOSpaprContainer,
container);
IOMMUMemoryRegion *iommu_mr = IOMMU_MEMORY_REGION(section->mr);
@@ -352,8 +352,7 @@ vfio_spapr_container_add_section_window(VFIOContainerBase *bcontainer,
MemoryRegionSection *section,
Error **errp)
{
- VFIOContainer *container = container_of(bcontainer, VFIOContainer,
- bcontainer);
+ VFIOContainer *container = VFIO_IOMMU_LEGACY(bcontainer);
VFIOSpaprContainer *scontainer = container_of(container, VFIOSpaprContainer,
container);
VFIOHostDMAWindow *hostwin;
@@ -443,8 +442,7 @@ static void
vfio_spapr_container_del_section_window(VFIOContainerBase *bcontainer,
MemoryRegionSection *section)
{
- VFIOContainer *container = container_of(bcontainer, VFIOContainer,
- bcontainer);
+ VFIOContainer *container = VFIO_IOMMU_LEGACY(bcontainer);
VFIOSpaprContainer *scontainer = container_of(container, VFIOSpaprContainer,
container);
@@ -465,8 +463,7 @@ vfio_spapr_container_del_section_window(VFIOContainerBase *bcontainer,
static void vfio_spapr_container_release(VFIOContainerBase *bcontainer)
{
- VFIOContainer *container = container_of(bcontainer, VFIOContainer,
- bcontainer);
+ VFIOContainer *container = VFIO_IOMMU_LEGACY(bcontainer);
VFIOSpaprContainer *scontainer = container_of(container, VFIOSpaprContainer,
container);
VFIOHostDMAWindow *hostwin, *next;
@@ -484,8 +481,7 @@ static void vfio_spapr_container_release(VFIOContainerBase *bcontainer)
static bool vfio_spapr_container_setup(VFIOContainerBase *bcontainer,
Error **errp)
{
- VFIOContainer *container = container_of(bcontainer, VFIOContainer,
- bcontainer);
+ VFIOContainer *container = VFIO_IOMMU_LEGACY(bcontainer);
VFIOSpaprContainer *scontainer = container_of(container, VFIOSpaprContainer,
container);
struct vfio_iommu_spapr_tce_info info;
--
2.43.0
next prev parent reply other threads:[~2025-07-15 9:38 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 9:25 [PATCH 00/22] vfio: improve use of QOM and coding guidelines Mark Cave-Ayland
2025-07-15 9:25 ` [PATCH 01/22] vfio/vfio-container-base.h: update VFIOContainerBase declaration Mark Cave-Ayland
2025-08-11 11:45 ` Cédric Le Goater
2025-08-11 11:56 ` Cédric Le Goater
2025-08-29 11:10 ` Mark Cave-Ayland
2025-07-15 9:25 ` [PATCH 02/22] vfio/vfio-container.h: update VFIOContainer declaration Mark Cave-Ayland
2025-07-15 9:39 ` Philippe Mathieu-Daudé
2025-08-11 11:45 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 03/22] hw/vfio/cpr-legacy.c: use QOM casts where appropriate Mark Cave-Ayland
2025-07-15 12:36 ` Steven Sistare
2025-08-11 11:45 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 04/22] hw/vfio/container.c: " Mark Cave-Ayland
2025-08-11 12:19 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 05/22] ppc/spapr_pci_vfio.c: " Mark Cave-Ayland
2025-07-16 7:58 ` Harsh Prateek Bora
2025-08-11 12:19 ` Cédric Le Goater
2025-07-15 9:25 ` Mark Cave-Ayland [this message]
2025-07-16 8:01 ` [PATCH 06/22] vfio/spapr.c: " Harsh Prateek Bora
2025-08-11 12:20 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 07/22] vfio/vfio-container.h: rename VFIOContainer bcontainer field to parent_obj Mark Cave-Ayland
2025-07-15 9:39 ` Philippe Mathieu-Daudé
2025-08-11 12:23 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 08/22] vfio-user/container.h: update VFIOUserContainer declaration Mark Cave-Ayland
2025-07-15 9:39 ` Philippe Mathieu-Daudé
2025-07-15 12:57 ` John Levon
2025-08-11 12:23 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 09/22] vfio/container.c: use QOM casts where appropriate Mark Cave-Ayland
2025-07-15 14:13 ` John Levon
2025-08-28 15:14 ` Mark Cave-Ayland
2025-08-28 15:25 ` John Levon
2025-08-11 12:23 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 10/22] vfio-user/container.h: rename VFIOUserContainer bcontainer field to parent_obj Mark Cave-Ayland
2025-07-15 9:41 ` Philippe Mathieu-Daudé
2025-07-15 14:13 ` John Levon
2025-08-11 12:23 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration Mark Cave-Ayland
2025-07-15 9:42 ` Philippe Mathieu-Daudé
2025-07-15 9:43 ` Philippe Mathieu-Daudé
2025-07-15 13:35 ` BALATON Zoltan
2025-07-15 14:15 ` John Levon
2025-08-11 12:24 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 12/22] vfio-user/pci.c: use QOM casts where appropriate Mark Cave-Ayland
2025-07-15 14:15 ` John Levon
2025-07-15 9:25 ` [PATCH 13/22] vfio-user/pci.c: rename VFIOUserPCIDevice device field to parent_obj Mark Cave-Ayland
2025-07-15 9:42 ` Philippe Mathieu-Daudé
2025-07-15 14:15 ` John Levon
2025-08-11 12:25 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 14/22] vfio/pci.h: update VFIOPCIDevice declaration Mark Cave-Ayland
2025-07-15 9:44 ` Philippe Mathieu-Daudé
2025-08-11 12:25 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 15/22] vfio/pci.h: use QOM casts where appropriate Mark Cave-Ayland
2025-07-15 9:25 ` [PATCH 16/22] vfio/pci.c: " Mark Cave-Ayland
2025-07-15 13:38 ` BALATON Zoltan
2025-08-11 12:45 ` Cédric Le Goater
2025-08-29 11:13 ` Mark Cave-Ayland
2025-08-29 11:07 ` Mark Cave-Ayland
2025-08-29 14:31 ` BALATON Zoltan
2025-09-01 10:24 ` Cédric Le Goater
2025-07-15 9:25 ` [PATCH 17/22] vfio/pci-quirks.c: " Mark Cave-Ayland
2025-07-15 9:25 ` [PATCH 18/22] vfio/cpr.c: " Mark Cave-Ayland
2025-07-15 12:36 ` Steven Sistare
2025-07-15 9:25 ` [PATCH 19/22] vfio/igd.c: " Mark Cave-Ayland
2025-07-18 15:26 ` Tomita Moeko
2025-07-15 9:26 ` [PATCH 20/22] vfio-user/pci.c: " Mark Cave-Ayland
2025-07-15 14:17 ` John Levon
2025-07-15 9:26 ` [PATCH 21/22] s390x/s390-pci-vfio.c: " Mark Cave-Ayland
2025-07-15 13:29 ` Eric Farman
2025-07-15 14:19 ` Matthew Rosato
2025-07-15 9:26 ` [PATCH 22/22] vfio/pci.h: rename VFIOPCIDevice pdev field to parent_obj Mark Cave-Ayland
2025-07-15 9:44 ` Philippe Mathieu-Daudé
2025-07-15 12:36 ` Steven Sistare
2025-08-11 12:46 ` Cédric Le Goater
2025-07-15 14:31 ` [PATCH 00/22] vfio: improve use of QOM and coding guidelines Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715093110.107317-7-mark.caveayland@nutanix.com \
--to=mark.caveayland@nutanix.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=john.levon@nutanix.com \
--cc=mjrosato@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=steven.sistare@oracle.com \
--cc=thanos.makatos@nutanix.com \
--cc=thuth@redhat.com \
--cc=tomitamoeko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).