From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D47CC83F17 for ; Tue, 15 Jul 2025 10:57:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubdLH-0005VO-Cn; Tue, 15 Jul 2025 06:57:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubdL3-0005Pk-AL for qemu-devel@nongnu.org; Tue, 15 Jul 2025 06:56:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubdL1-0001oY-Hn for qemu-devel@nongnu.org; Tue, 15 Jul 2025 06:56:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752577001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfHZACY9n2OlAivJGCo52+McSi1WKy8KSNDBsiyROlU=; b=U3kXA6UaQ7jI23L7ZsoxJ7XGz0BMUNtoJ6LyKnWwnrE0AQKAaDgJRDBZ6arvolIbt+lY28 jvMqYZqz/06mm8j8Z+Pis/eNQbRzNxHpDW2+Lzpb3qAu1eNWMgPY1dHxGl+MVo2b5bP6bD VzxM5tmkyK8AF4qpolwdymut7CyGKYc= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-OXP9bRrMM-G6GPhsS1l_9Q-1; Tue, 15 Jul 2025 06:56:40 -0400 X-MC-Unique: OXP9bRrMM-G6GPhsS1l_9Q-1 X-Mimecast-MFC-AGG-ID: OXP9bRrMM-G6GPhsS1l_9Q_1752576999 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3A96A1955F43 for ; Tue, 15 Jul 2025 10:56:39 +0000 (UTC) Received: from localhost (unknown [10.44.32.10]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D5A0C1808868; Tue, 15 Jul 2025 10:56:32 +0000 (UTC) Date: Tue, 15 Jul 2025 11:56:30 +0100 From: "Richard W.M. Jones" To: Miro =?utf-8?Q?Hron=C4=8Dok?= Cc: jsnow@redhat.com, crosa@redhat.com, qemu-devel@nongnu.org, berrange@redhat.com Subject: Re: [PATCH] python: Replace asyncio.get_event_loop for Python 3.14 Message-ID: <20250715105630.GP7658@redhat.com> References: <20250715105113.623604-1-rjones@redhat.com> <81d639a0-aea2-495a-91d4-6dcc397ef7db@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <81d639a0-aea2-495a-91d4-6dcc397ef7db@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jul 15, 2025 at 12:54:26PM +0200, Miro Hrončok wrote: > On 15. 07. 25 12:51, Richard W.M. Jones wrote: > >In Python 3.14, no asyncio event loop gets generated automatically. > >Instead create one when we need it. This should work with Python 3.13 > >as well. This is a mechanical change as suggested here: > > > >https://bugzilla.redhat.com/show_bug.cgi?id=2375004#c4 > > > >See-also: https://docs.python.org/3.14/whatsnew/3.14.html#id7 > >Thanks: Miro Hrončok > >Signed-off-by: Richard W.M. Jones > >--- > > python/qemu/qmp/legacy.py | 5 ++++- > > python/qemu/qmp/qmp_tui.py | 5 ++++- > > python/qemu/qmp/util.py | 5 ++++- > > python/tests/protocol.py | 5 ++++- > > 4 files changed, 16 insertions(+), 4 deletions(-) > > > >diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py > >index 22a2b5616e..e11d05afbd 100644 > >--- a/python/qemu/qmp/legacy.py > >+++ b/python/qemu/qmp/legacy.py > >@@ -86,7 +86,10 @@ def __init__(self, > > "server argument should be False when passing a socket") > > self._qmp = QMPClient(nickname) > >- self._aloop = asyncio.get_event_loop() > >+ try: > >+ self._aloop = asyncio.get_event_loop() > >+ except RuntimeError: > >+ self._aloop = asyncio.new_event_loop() > > self._address = address > > self._timeout: Optional[float] = None > >diff --git a/python/qemu/qmp/qmp_tui.py b/python/qemu/qmp/qmp_tui.py > >index 2d9ebbd20b..84c5da4e66 100644 > >--- a/python/qemu/qmp/qmp_tui.py > >+++ b/python/qemu/qmp/qmp_tui.py > >@@ -377,7 +377,10 @@ def run(self, debug: bool = False) -> None: > > screen = urwid.raw_display.Screen() > > screen.set_terminal_properties(256) > >- self.aloop = asyncio.get_event_loop() > >+ try: > >+ self.aloop = asyncio.get_event_loop() > >+ except RuntimeError: > >+ self.aloop = asyncio.new_event_loop() > > self.aloop.set_debug(debug) > > # Gracefully handle SIGTERM and SIGINT signals > >diff --git a/python/qemu/qmp/util.py b/python/qemu/qmp/util.py > >index ca6225e9cd..8f9f849a5f 100644 > >--- a/python/qemu/qmp/util.py > >+++ b/python/qemu/qmp/util.py > >@@ -160,7 +160,10 @@ def asyncio_run(coro: Coroutine[Any, Any, T], *, debug: bool = False) -> T: > > return asyncio.run(coro, debug=debug) > > # Python 3.6 > >- loop = asyncio.get_event_loop() > >+ try: > >+ loop = asyncio.get_event_loop() > >+ except RuntimeError: > >+ loop = asyncio.new_event_loop() > > loop.set_debug(debug) > > ret = loop.run_until_complete(coro) > > loop.close() > > This one particular addition should not be necessary as it only runs > on Python 3.6. This code is not reached on Python 3.7+ and hence it > is not reached on Python 3.14. Yup, even says it in the comment :-) I'll submit a v2 in a little while, in case there is any other feedback. Rich. > >diff --git a/python/tests/protocol.py b/python/tests/protocol.py > >index 56c4d441f9..aa7c0e4397 100644 > >--- a/python/tests/protocol.py > >+++ b/python/tests/protocol.py > >@@ -228,7 +228,10 @@ def async_test(async_test_method): > > Decorator; adds SetUp and TearDown to async tests. > > """ > > async def _wrapper(self, *args, **kwargs): > >- loop = asyncio.get_event_loop() > >+ try: > >+ loop = asyncio.get_event_loop() > >+ except RuntimeError: > >+ loop = asyncio.new_event_loop() > > loop.set_debug(True) > > await self._asyncSetUp() > > -- > Miro Hrončok > -- > Phone: +420777974800 > Fedora Matrix: mhroncok -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW