qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hanna Reitz" <hreitz@redhat.com>,
	"Jagannathan Raman" <jag.raman@oracle.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>
Subject: [PATCH 01/14] python: Replace asyncio.get_event_loop for Python 3.14
Date: Tue, 15 Jul 2025 15:30:10 +0100	[thread overview]
Message-ID: <20250715143023.1851000-2-berrange@redhat.com> (raw)
In-Reply-To: <20250715143023.1851000-1-berrange@redhat.com>

From: Richard W.M. Jones <rjones@redhat.com>

In Python 3.14, no asyncio event loop gets generated automatically.
Instead create one when we need it.  This should work with Python 3.13
as well.  This change was suggested here:

https://bugzilla.redhat.com/show_bug.cgi?id=2375004#c4

See-also: https://docs.python.org/3.14/whatsnew/3.14.html#id7
Thanks: Miro Hrončok, Daniel P. Berrangé
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 python/qemu/qmp/legacy.py  | 5 ++++-
 python/qemu/qmp/qmp_tui.py | 2 +-
 python/tests/protocol.py   | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
index 22a2b5616e..e11d05afbd 100644
--- a/python/qemu/qmp/legacy.py
+++ b/python/qemu/qmp/legacy.py
@@ -86,7 +86,10 @@ def __init__(self,
                 "server argument should be False when passing a socket")
 
         self._qmp = QMPClient(nickname)
-        self._aloop = asyncio.get_event_loop()
+        try:
+            self._aloop = asyncio.get_event_loop()
+        except RuntimeError:
+            self._aloop = asyncio.new_event_loop()
         self._address = address
         self._timeout: Optional[float] = None
 
diff --git a/python/qemu/qmp/qmp_tui.py b/python/qemu/qmp/qmp_tui.py
index 2d9ebbd20b..7dfb03c9ad 100644
--- a/python/qemu/qmp/qmp_tui.py
+++ b/python/qemu/qmp/qmp_tui.py
@@ -377,7 +377,7 @@ def run(self, debug: bool = False) -> None:
         screen = urwid.raw_display.Screen()
         screen.set_terminal_properties(256)
 
-        self.aloop = asyncio.get_event_loop()
+        self.aloop = asyncio.new_event_loop()
         self.aloop.set_debug(debug)
 
         # Gracefully handle SIGTERM and SIGINT signals
diff --git a/python/tests/protocol.py b/python/tests/protocol.py
index 56c4d441f9..db5d54d83f 100644
--- a/python/tests/protocol.py
+++ b/python/tests/protocol.py
@@ -228,7 +228,7 @@ def async_test(async_test_method):
         Decorator; adds SetUp and TearDown to async tests.
         """
         async def _wrapper(self, *args, **kwargs):
-            loop = asyncio.get_event_loop()
+            loop = asyncio.new_event_loop()
             loop.set_debug(True)
 
             await self._asyncSetUp()
-- 
2.49.0



  reply	other threads:[~2025-07-15 15:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15 14:30 [PATCH 00/14] python: misc cleanups for python code Daniel P. Berrangé
2025-07-15 14:30 ` Daniel P. Berrangé [this message]
2025-08-19 19:47   ` [PATCH 01/14] python: Replace asyncio.get_event_loop for Python 3.14 John Snow
2025-08-19 19:51     ` Daniel P. Berrangé
2025-08-19 20:00       ` John Snow
2025-07-15 14:30 ` [PATCH 02/14] python: avoid deprecation warning with get_event_loop Daniel P. Berrangé
2025-07-23 21:24   ` Eric Blake
2025-08-19 19:49     ` John Snow
2025-08-19 19:52       ` Daniel P. Berrangé
2025-07-15 14:30 ` [PATCH 03/14] python: drop 'is_closing' back compat helper Daniel P. Berrangé
2025-07-24 12:44   ` Alex Bennée
2025-08-19 19:56   ` John Snow
2025-07-15 14:30 ` [PATCH 04/14] python: drop 'wait_closed' " Daniel P. Berrangé
2025-08-19 19:56   ` John Snow
2025-07-15 14:30 ` [PATCH 05/14] python: drop 'asyncio_run' " Daniel P. Berrangé
2025-08-19 19:57   ` John Snow
2025-07-15 14:30 ` [PATCH 06/14] python: drop 'create_task' " Daniel P. Berrangé
2025-08-19 19:57   ` John Snow
2025-07-15 14:30 ` [PATCH 07/14] iotests: drop compat for old version context manager Daniel P. Berrangé
2025-08-19 20:04   ` John Snow
2025-07-15 14:30 ` [PATCH 08/14] functional: ensure log handlers are closed Daniel P. Berrangé
2025-07-15 14:50   ` Thomas Huth
2025-07-15 14:30 ` [PATCH 09/14] functional: ensure sockets and files " Daniel P. Berrangé
2025-07-15 15:03   ` Thomas Huth
2025-07-15 15:12     ` Daniel P. Berrangé
2025-07-15 15:14       ` Thomas Huth
2025-07-15 14:30 ` [PATCH 10/14] functional: always enable all python warnings Daniel P. Berrangé
2025-07-15 15:15   ` Thomas Huth
2025-08-19 20:08     ` John Snow
2025-07-15 14:30 ` [PATCH 11/14] python: ensure QEMUQtestProtocol closes its socket Daniel P. Berrangé
2025-08-19 20:12   ` John Snow
2025-08-19 20:29     ` Daniel P. Berrangé
2025-07-15 14:30 ` [PATCH 12/14] iotests/147: ensure temporary sockets are closed before exiting Daniel P. Berrangé
2025-08-19 21:37   ` John Snow
2025-07-15 14:30 ` [PATCH 13/14] iotests/151: ensure subprocesses are cleaned up Daniel P. Berrangé
2025-08-19 21:37   ` John Snow
2025-08-20  9:45     ` Daniel P. Berrangé
2025-07-15 14:30 ` [PATCH 14/14] iotests/check: always enable all python warnings Daniel P. Berrangé
2025-08-20  5:03   ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715143023.1851000-2-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=hreitz@redhat.com \
    --cc=jag.raman@oracle.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).