From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hanna Reitz" <hreitz@redhat.com>,
"Jagannathan Raman" <jag.raman@oracle.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"Thomas Huth" <thuth@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 07/14] iotests: drop compat for old version context manager
Date: Tue, 15 Jul 2025 15:30:16 +0100 [thread overview]
Message-ID: <20250715143023.1851000-8-berrange@redhat.com> (raw)
In-Reply-To: <20250715143023.1851000-1-berrange@redhat.com>
Our minimum python is now 3.9, so back compat with prior
python versions is no longer required.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qemu-iotests/testenv.py | 7 ++-----
tests/qemu-iotests/testrunner.py | 9 ++-------
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index 6326e46b7b..29caaa8a34 100644
--- a/tests/qemu-iotests/testenv.py
+++ b/tests/qemu-iotests/testenv.py
@@ -22,15 +22,12 @@
from pathlib import Path
import shutil
import collections
+import contextlib
import random
import subprocess
import glob
from typing import List, Dict, Any, Optional
-if sys.version_info >= (3, 9):
- from contextlib import AbstractContextManager as ContextManager
-else:
- from typing import ContextManager
DEF_GDB_OPTIONS = 'localhost:12345'
@@ -58,7 +55,7 @@ def get_default_machine(qemu_prog: str) -> str:
return default_machine
-class TestEnv(ContextManager['TestEnv']):
+class TestEnv(contextlib.AbstractContextManager['TestEnv']):
"""
Manage system environment for running tests
diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
index 2e236c8fa3..14cc8492f9 100644
--- a/tests/qemu-iotests/testrunner.py
+++ b/tests/qemu-iotests/testrunner.py
@@ -30,11 +30,6 @@
from typing import List, Optional, Any, Sequence, Dict
from testenv import TestEnv
-if sys.version_info >= (3, 9):
- from contextlib import AbstractContextManager as ContextManager
-else:
- from typing import ContextManager
-
def silent_unlink(path: Path) -> None:
try:
@@ -57,7 +52,7 @@ def file_diff(file1: str, file2: str) -> List[str]:
return res
-class LastElapsedTime(ContextManager['LastElapsedTime']):
+class LastElapsedTime(contextlib.AbstractContextManager['LastElapsedTime']):
""" Cache for elapsed time for tests, to show it during new test run
It is safe to use get() at any time. To use update(), you must either
@@ -112,7 +107,7 @@ def __init__(self, status: str, description: str = '',
self.interrupted = interrupted
-class TestRunner(ContextManager['TestRunner']):
+class TestRunner(contextlib.AbstractContextManager['TestRunner']):
shared_self = None
@staticmethod
--
2.49.0
next prev parent reply other threads:[~2025-07-15 15:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 14:30 [PATCH 00/14] python: misc cleanups for python code Daniel P. Berrangé
2025-07-15 14:30 ` [PATCH 01/14] python: Replace asyncio.get_event_loop for Python 3.14 Daniel P. Berrangé
2025-08-19 19:47 ` John Snow
2025-08-19 19:51 ` Daniel P. Berrangé
2025-08-19 20:00 ` John Snow
2025-07-15 14:30 ` [PATCH 02/14] python: avoid deprecation warning with get_event_loop Daniel P. Berrangé
2025-07-23 21:24 ` Eric Blake
2025-08-19 19:49 ` John Snow
2025-08-19 19:52 ` Daniel P. Berrangé
2025-07-15 14:30 ` [PATCH 03/14] python: drop 'is_closing' back compat helper Daniel P. Berrangé
2025-07-24 12:44 ` Alex Bennée
2025-08-19 19:56 ` John Snow
2025-07-15 14:30 ` [PATCH 04/14] python: drop 'wait_closed' " Daniel P. Berrangé
2025-08-19 19:56 ` John Snow
2025-07-15 14:30 ` [PATCH 05/14] python: drop 'asyncio_run' " Daniel P. Berrangé
2025-08-19 19:57 ` John Snow
2025-07-15 14:30 ` [PATCH 06/14] python: drop 'create_task' " Daniel P. Berrangé
2025-08-19 19:57 ` John Snow
2025-07-15 14:30 ` Daniel P. Berrangé [this message]
2025-08-19 20:04 ` [PATCH 07/14] iotests: drop compat for old version context manager John Snow
2025-07-15 14:30 ` [PATCH 08/14] functional: ensure log handlers are closed Daniel P. Berrangé
2025-07-15 14:50 ` Thomas Huth
2025-07-15 14:30 ` [PATCH 09/14] functional: ensure sockets and files " Daniel P. Berrangé
2025-07-15 15:03 ` Thomas Huth
2025-07-15 15:12 ` Daniel P. Berrangé
2025-07-15 15:14 ` Thomas Huth
2025-07-15 14:30 ` [PATCH 10/14] functional: always enable all python warnings Daniel P. Berrangé
2025-07-15 15:15 ` Thomas Huth
2025-08-19 20:08 ` John Snow
2025-07-15 14:30 ` [PATCH 11/14] python: ensure QEMUQtestProtocol closes its socket Daniel P. Berrangé
2025-08-19 20:12 ` John Snow
2025-08-19 20:29 ` Daniel P. Berrangé
2025-07-15 14:30 ` [PATCH 12/14] iotests/147: ensure temporary sockets are closed before exiting Daniel P. Berrangé
2025-08-19 21:37 ` John Snow
2025-07-15 14:30 ` [PATCH 13/14] iotests/151: ensure subprocesses are cleaned up Daniel P. Berrangé
2025-08-19 21:37 ` John Snow
2025-08-20 9:45 ` Daniel P. Berrangé
2025-07-15 14:30 ` [PATCH 14/14] iotests/check: always enable all python warnings Daniel P. Berrangé
2025-08-20 5:03 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715143023.1851000-8-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=hreitz@redhat.com \
--cc=jag.raman@oracle.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).