From: Roman Kiryanov <rkir@google.com>
To: qemu-devel@nongnu.org
Cc: eric.auger@redhat.com, mjt@tls.msk.ru, whollins@google.com,
jansene@google.com, jpcottin@google.com,
Roman Kiryanov <rkir@google.com>
Subject: [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1`
Date: Thu, 17 Jul 2025 13:57:35 -0700 [thread overview]
Message-ID: <20250717205735.2345674-1-rkir@google.com> (raw)
this function is declared in smmu-common.h without
`inline`. It is also used outside of this file
which causes linking errors because the non-inline
version is not generated.
Signed-off-by: Will Hollins <whollins@google.com>
Signed-off-by: Roman Kiryanov <rkir@google.com>
---
hw/arm/smmu-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
index f39b99e526..0dcaf2f589 100644
--- a/hw/arm/smmu-common.c
+++ b/hw/arm/smmu-common.c
@@ -319,7 +319,7 @@ void smmu_iotlb_inv_vmid(SMMUState *s, int vmid)
g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid, &vmid);
}
-inline void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
+void smmu_iotlb_inv_vmid_s1(SMMUState *s, int vmid)
{
trace_smmu_iotlb_inv_vmid_s1(vmid);
g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_vmid_s1, &vmid);
--
2.50.0.727.gbf7dc18ff4-goog
next reply other threads:[~2025-07-17 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 20:57 Roman Kiryanov [this message]
2025-07-18 0:38 ` [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1` Richard Henderson
2025-07-18 6:06 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717205735.2345674-1-rkir@google.com \
--to=rkir@google.com \
--cc=eric.auger@redhat.com \
--cc=jansene@google.com \
--cc=jpcottin@google.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=whollins@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).