From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>
Subject: [PATCH 1/3] tests/functional: add --keep-scratch CLI arg
Date: Fri, 18 Jul 2025 12:12:52 +0300 [thread overview]
Message-ID: <20250718-functional_tests_args-v1-1-54d4c6207690@linaro.org> (raw)
In-Reply-To: <20250718-functional_tests_args-v1-0-54d4c6207690@linaro.org>
Add CLI arg to keep scratch files after test execution, equivalent to
setting QEMU_TEST_KEEP_SCRATCH env var.
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
---
tests/functional/qemu_test/testcase.py | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
index 3ecaaeffd4df2945fb4c44b4ddef6911527099b9..24f0b452964012532530a92018b2c4367b39fb77 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -43,6 +43,13 @@ def parse_args(test_name: str) -> argparse.Namespace:
help="Also print test and console logs on stdout. This will make the"
" TAP output invalid and is meant for debugging only.",
)
+ parser.add_argument(
+ "--keep-scratch",
+ action="store_true",
+ help="Do not purge any scratch files created during the tests. "
+ "This is equivalent to setting QEMU_TEST_KEEP_SCRATCH=1 in the "
+ "environment.",
+ )
return parser.parse_args()
@@ -214,6 +221,10 @@ def setUp(self):
path = os.path.basename(sys.argv[0])[:-3]
args = parse_args(path)
self.stdout_handler = None
+ self.keep_scratch = (
+ "QEMU_TEST_KEEP_SCRATCH" in os.environ
+ or args.keep_scratch
+ )
if args.debug:
self.stdout_handler = logging.StreamHandler(sys.stdout)
self.stdout_handler.setLevel(logging.DEBUG)
@@ -255,8 +266,10 @@ def setUp(self):
self.skipTest('One or more assets is not available')
def tearDown(self):
- if "QEMU_TEST_KEEP_SCRATCH" not in os.environ:
+ if not self.keep_scratch:
shutil.rmtree(self.workdir)
+ else:
+ self.log.info(f"Kept scratch files in {self.workdir}")
if self.socketdir is not None:
shutil.rmtree(self.socketdir.name)
self.socketdir = None
--
2.47.2
next prev parent reply other threads:[~2025-07-18 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 9:12 [PATCH 0/3] tests/functional: add more CLI args Manos Pitsidianakis
2025-07-18 9:12 ` Manos Pitsidianakis [this message]
2025-07-18 9:12 ` [PATCH 2/3] tests/functional: add --list-tests CLI arg Manos Pitsidianakis
2025-07-18 9:12 ` [PATCH 3/3] tests/functional: add -k TEST_NAME_PATTERN " Manos Pitsidianakis
2025-07-18 9:37 ` Paolo Bonzini
2025-07-18 9:44 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718-functional_tests_args-v1-1-54d4c6207690@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).