From: Vadim Chichikalyuk <chichikalyuk@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Vadim Chichikalyuk <chichikalyuk@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH 3/4] hw: arm: acpi: add UART clock frequency to SPCR table
Date: Fri, 18 Jul 2025 19:20:44 +0300 [thread overview]
Message-ID: <20250718162045.49012-4-chichikalyuk@gmail.com> (raw)
In-Reply-To: <20250718162045.49012-1-chichikalyuk@gmail.com>
On the ARM virt machine, there is currently no way to programmatically
discover the frequency of the UART reference clock solely through the use of
UEFI/ACPI (without the DTB). The SPCR table can include this information
as of revision 3.
Bump the revision to 3 and add the clock frequency of 24 MHz to the table.
Signed-off-by: Vadim Chichikalyuk <chichikalyuk@gmail.com>
---
hw/arm/virt-acpi-build.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index b01fc4f8ef..029cbb37f7 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -559,12 +559,13 @@ spcr_setup(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
.pci_function = 0,
.pci_flags = 0,
.pci_segment = 0,
+ .uart_clk_freq = 24000000, /* 24MHz */
};
/*
- * Passing NULL as the SPCR Table for Revision 2 doesn't support
+ * Passing NULL as the SPCR Table for Revision 3 doesn't support
* NameSpaceString.
*/
- build_spcr(table_data, linker, &serial, 2, vms->oem_id, vms->oem_table_id,
+ build_spcr(table_data, linker, &serial, 3, vms->oem_id, vms->oem_table_id,
NULL);
}
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-07-18 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 16:20 [PATCH 0/4] hw: acpi: support SPCR rev. 3 & UART clock freq in ARM SPCR Vadim Chichikalyuk
2025-07-18 16:20 ` [PATCH 1/4] hw: acpi: add support for SPCR revision 3 Vadim Chichikalyuk
2025-07-21 9:39 ` Jonathan Cameron via
2025-07-21 20:12 ` Vadim Chichikalyuk
2025-07-18 16:20 ` [PATCH 2/4] tests: acpi: whitelist expected blobs Vadim Chichikalyuk
2025-07-21 9:39 ` Jonathan Cameron via
2025-07-18 16:20 ` Vadim Chichikalyuk [this message]
2025-07-21 9:41 ` [PATCH 3/4] hw: arm: acpi: add UART clock frequency to SPCR table Jonathan Cameron via
2025-07-21 21:06 ` Vadim Chichikalyuk
2025-07-18 16:20 ` [PATCH 4/4] tests: acpi: update expected blobs Vadim Chichikalyuk
2025-07-21 9:44 ` Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718162045.49012-4-chichikalyuk@gmail.com \
--to=chichikalyuk@gmail.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).