* [PATCH] migration: show error message when postcopy fails
@ 2025-07-21 13:39 Daniel P. Berrangé
2025-07-21 14:29 ` Fabiano Rosas
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrangé @ 2025-07-21 13:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Fabiano Rosas, Peter Xu, Daniel P. Berrangé
The 'info migrate' command only shows the error message when the
migration state is 'failed'. When postcopy is used, however,
the 'postcopy-paused' state is used instead of 'failed', so we
must show the error message there too.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
migration/migration-hmp-cmds.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index cef5608210..07fd227edc 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -153,7 +153,8 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
if (info->has_status) {
monitor_printf(mon, "Status: \t\t%s",
MigrationStatus_str(info->status));
- if (info->status == MIGRATION_STATUS_FAILED && info->error_desc) {
+ if ((info->status == MIGRATION_STATUS_FAILED ||
+ info->status == MIGRATION_STATUS_POSTCOPY_PAUSED) && info->error_desc) {
monitor_printf(mon, " (%s)\n", info->error_desc);
} else {
monitor_printf(mon, "\n");
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] migration: show error message when postcopy fails
2025-07-21 13:39 [PATCH] migration: show error message when postcopy fails Daniel P. Berrangé
@ 2025-07-21 14:29 ` Fabiano Rosas
0 siblings, 0 replies; 2+ messages in thread
From: Fabiano Rosas @ 2025-07-21 14:29 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel; +Cc: Peter Xu, Daniel P. Berrangé
Daniel P. Berrangé <berrange@redhat.com> writes:
> The 'info migrate' command only shows the error message when the
> migration state is 'failed'. When postcopy is used, however,
> the 'postcopy-paused' state is used instead of 'failed', so we
> must show the error message there too.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> migration/migration-hmp-cmds.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
> index cef5608210..07fd227edc 100644
> --- a/migration/migration-hmp-cmds.c
> +++ b/migration/migration-hmp-cmds.c
> @@ -153,7 +153,8 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> if (info->has_status) {
> monitor_printf(mon, "Status: \t\t%s",
> MigrationStatus_str(info->status));
> - if (info->status == MIGRATION_STATUS_FAILED && info->error_desc) {
> + if ((info->status == MIGRATION_STATUS_FAILED ||
> + info->status == MIGRATION_STATUS_POSTCOPY_PAUSED) && info->error_desc) {
> monitor_printf(mon, " (%s)\n", info->error_desc);
> } else {
> monitor_printf(mon, "\n");
Reviewed-by: Fabiano Rosas <farosas@suse.de>
queued
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-21 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 13:39 [PATCH] migration: show error message when postcopy fails Daniel P. Berrangé
2025-07-21 14:29 ` Fabiano Rosas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).