From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93A72C83F25 for ; Mon, 21 Jul 2025 18:12:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uduzu-0000eR-TV; Mon, 21 Jul 2025 14:12:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uduyf-0007fU-2l for qemu-devel@nongnu.org; Mon, 21 Jul 2025 14:11:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uduyc-00016h-KL for qemu-devel@nongnu.org; Mon, 21 Jul 2025 14:11:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753121461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3U6j2ldIL5A3L0cLR69PtJYND77QZRzbv1r4Wr9Ovc=; b=Mte0aU1pnkd688dzeHvi8aOZOH1o2bNiFqhhZhDgsJJN8K/wlh6YMVY32qfAIpmI9V7B6b zt60F4ZlYyjWLIOVWDX/W9futBuZwRNAr++Ae13951qSUuVogLsEV1nWlvGNndfiTq9W0m tW1DlVnfKvtPlyvmludpqtDeRkO/83E= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-NxMDB-CdPHq_rdg59JSxrw-1; Mon, 21 Jul 2025 14:10:57 -0400 X-MC-Unique: NxMDB-CdPHq_rdg59JSxrw-1 X-Mimecast-MFC-AGG-ID: NxMDB-CdPHq_rdg59JSxrw_1753121456 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D81D01956048; Mon, 21 Jul 2025 18:10:55 +0000 (UTC) Received: from localhost (unknown [10.2.16.31]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CC877195608D; Mon, 21 Jul 2025 18:10:54 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Mahmoud Mandour , Stefan Hajnoczi , Alexandre Iooss , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Mads Ynddal , Vladimir Sementsov-Ogievskiy Subject: [PULL 1/1] trace: log.py: human-readable timestamp Date: Mon, 21 Jul 2025 14:10:51 -0400 Message-ID: <20250721181051.61143-2-stefanha@redhat.com> In-Reply-To: <20250721181051.61143-1-stefanha@redhat.com> References: <20250721181051.61143-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.926, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Vladimir Sementsov-Ogievskiy So tired to parse all these timestamps, when need to compare them with other logs. Use iso8601 format as in warn_report() (info_report(), error_report()) already used. Also, start line with date, to be similar with warn_report() as well. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20250626195514.366177-1-vsementsov@yandex-team.ru Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/backend/log.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool/backend/log.py b/scripts/tracetool/backend/log.py index 17ba1cd90e..61118474b1 100644 --- a/scripts/tracetool/backend/log.py +++ b/scripts/tracetool/backend/log.py @@ -39,10 +39,15 @@ def generate_h(event, group): ' if (message_with_timestamp) {', ' struct timeval _now;', ' gettimeofday(&_now, NULL);', + ' time_t _seconds = _now.tv_sec;', + ' struct tm _tm;', + ' gmtime_r(&_seconds, &_tm);', '#line %(event_lineno)d "%(event_filename)s"', - ' qemu_log("%%d@%%zu.%%06zu:%(name)s " %(fmt)s "\\n",', - ' qemu_get_thread_id(),', - ' (size_t)_now.tv_sec, (size_t)_now.tv_usec', + ' qemu_log("%%04d-%%02d-%%02dT%%02d:%%02d:%%02d.%%06ldZ' + ' (%%d) %(name)s " %(fmt)s "\\n",', + ' _tm.tm_year + 1900, _tm.tm_mon + 1, _tm.tm_mday,', + ' _tm.tm_hour, _tm.tm_min, _tm.tm_sec, _now.tv_usec,', + ' qemu_get_thread_id()', ' %(argnames)s);', '#line %(out_next_lineno)d "%(out_filename)s"', ' } else {', -- 2.50.1