* [PULL 0/1] tcg patch queue
@ 2025-07-21 15:11 Richard Henderson
2025-07-21 15:11 ` [PULL 1/1] tcg/optimize: Don't fold INDEX_op_and_vec to extract Richard Henderson
2025-07-21 18:31 ` [PULL 0/1] tcg patch queue Stefan Hajnoczi
0 siblings, 2 replies; 6+ messages in thread
From: Richard Henderson @ 2025-07-21 15:11 UTC (permalink / raw)
To: qemu-devel
The following changes since commit 56a3033abcfcf72a2f4f1376a605a0b1ad526b67:
Merge tag 'pull-request-2025-07-21' of https://gitlab.com/thuth/qemu into staging (2025-07-21 06:34:56 -0400)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20250721
for you to fetch changes up to 2c047bdb77e8f636936edd9ac5000521c9580477:
tcg/optimize: Don't fold INDEX_op_and_vec to extract (2025-07-21 08:09:04 -0700)
----------------------------------------------------------------
tcg/optimize: Don't fold INDEX_op_and_vec to extract
----------------------------------------------------------------
Richard Henderson (1):
tcg/optimize: Don't fold INDEX_op_and_vec to extract
tcg/optimize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PULL 1/1] tcg/optimize: Don't fold INDEX_op_and_vec to extract
2025-07-21 15:11 [PULL 0/1] tcg patch queue Richard Henderson
@ 2025-07-21 15:11 ` Richard Henderson
2025-07-21 18:31 ` [PULL 0/1] tcg patch queue Stefan Hajnoczi
1 sibling, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2025-07-21 15:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Pierrick Bouvier, Peter Maydell
There is no such thing as vector extract.
Fixes: 932522a9ddc1 ("tcg/optimize: Fold and to extract during optimize")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3036
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Tested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
tcg/optimize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 62a128bc9b..3638ab9fea 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1454,7 +1454,7 @@ static bool fold_and(OptContext *ctx, TCGOp *op)
a_mask = t1->z_mask & ~t2->o_mask;
if (!fold_masks_zosa_int(ctx, op, z_mask, o_mask, s_mask, a_mask)) {
- if (ti_is_const(t2)) {
+ if (op->opc == INDEX_op_and && ti_is_const(t2)) {
/*
* Canonicalize on extract, if valid. This aids x86 with its
* 2 operand MOVZBL and 2 operand AND, selecting the TCGOpcode
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PULL 0/1] tcg patch queue
2025-07-21 15:11 [PULL 0/1] tcg patch queue Richard Henderson
2025-07-21 15:11 ` [PULL 1/1] tcg/optimize: Don't fold INDEX_op_and_vec to extract Richard Henderson
@ 2025-07-21 18:31 ` Stefan Hajnoczi
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2025-07-21 18:31 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PULL 0/1] tcg patch queue
@ 2024-08-08 1:42 Richard Henderson
0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2024-08-08 1:42 UTC (permalink / raw)
To: qemu-devel
The following changes since commit 6d00c6f982562222adbd0613966285792125abe5:
Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2024-08-07 07:09:37 +1000)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240808
for you to fetch changes up to 682a05280504d2fab32e16096b58d7ea068435c2:
tcg/ppc: Sync tcg_out_test and constraints (2024-08-08 09:03:35 +1000)
----------------------------------------------------------------
tcg/ppc: Sync tcg_out_test and constraints
----------------------------------------------------------------
Richard Henderson (1):
tcg/ppc: Sync tcg_out_test and constraints
tcg/ppc/tcg-target.c.inc | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PULL 0/1] tcg patch queue
@ 2024-08-07 23:06 Richard Henderson
2024-08-08 1:43 ` Richard Henderson
0 siblings, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2024-08-07 23:06 UTC (permalink / raw)
To: qemu-devel
The following changes since commit 6d00c6f982562222adbd0613966285792125abe5:
Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2024-08-07 07:09:37 +1000)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240808
for you to fetch changes up to 682a05280504d2fab32e16096b58d7ea068435c2:
tcg/ppc: Sync tcg_out_test and constraints (2024-08-08 09:03:35 +1000)
----------------------------------------------------------------
tcg/ppc: Sync tcg_out_test and constraints
----------------------------------------------------------------
Richard Henderson (1):
tcg/ppc: Sync tcg_out_test and constraints
tcg/ppc/tcg-target.c.inc | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PULL 0/1] tcg patch queue
2024-08-07 23:06 Richard Henderson
@ 2024-08-08 1:43 ` Richard Henderson
0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2024-08-08 1:43 UTC (permalink / raw)
To: qemu-devel
On 8/8/24 09:06, Richard Henderson wrote:
> The following changes since commit 6d00c6f982562222adbd0613966285792125abe5:
>
> Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2024-08-07 07:09:37 +1000)
>
> are available in the Git repository at:
>
> https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240808
>
> for you to fetch changes up to 682a05280504d2fab32e16096b58d7ea068435c2:
>
> tcg/ppc: Sync tcg_out_test and constraints (2024-08-08 09:03:35 +1000)
>
> ----------------------------------------------------------------
> tcg/ppc: Sync tcg_out_test and constraints
>
> ----------------------------------------------------------------
> Richard Henderson (1):
> tcg/ppc: Sync tcg_out_test and constraints
>
> tcg/ppc/tcg-target.c.inc | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/9.1 as appropriate.
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-21 18:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 15:11 [PULL 0/1] tcg patch queue Richard Henderson
2025-07-21 15:11 ` [PULL 1/1] tcg/optimize: Don't fold INDEX_op_and_vec to extract Richard Henderson
2025-07-21 18:31 ` [PULL 0/1] tcg patch queue Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2024-08-08 1:42 Richard Henderson
2024-08-07 23:06 Richard Henderson
2024-08-08 1:43 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).