* [PULL 0/5] QAPI patches for 2025-07-29
@ 2025-07-29 13:11 Markus Armbruster
2025-07-29 13:11 ` [PULL 1/5] qapi: Add more cross-references Markus Armbruster
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Markus Armbruster @ 2025-07-29 13:11 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha
The following changes since commit 92c05be4dfb59a71033d4c57dac944b29f7dabf0:
Merge tag 'pull-qga-2025-07-28' of https://repo.or.cz/qemu/armbru into staging (2025-07-28 09:31:19 -0400)
are available in the Git repository at:
https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2025-07-29
for you to fetch changes up to a95b3c0ad857055198cdb272bca2af975092d060:
MAINTAINERS: Cover docs/devel/qapi-domain.rst properly (2025-07-29 14:51:39 +0200)
----------------------------------------------------------------
QAPI patches for 2025-07-29
----------------------------------------------------------------
Markus Armbruster (5):
qapi: Add more cross-references
qapi/accelerator: Fix markup of heading
tests/qapi-schema: Bury dead test case doc-non-first-section
docs/qapi-domain: Fix typos
MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
MAINTAINERS | 1 +
docs/devel/qapi-domain.rst | 4 ++--
qapi/accelerator.json | 4 +++-
qapi/dump.json | 2 +-
qapi/machine.json | 2 +-
qapi/migration.json | 4 ++--
qapi/misc-i386.json | 2 +-
qapi/run-state.json | 2 +-
qapi/sockets.json | 2 +-
tests/qapi-schema/doc-non-first-section.err | 1 -
tests/qapi-schema/doc-non-first-section.json | 6 ------
tests/qapi-schema/doc-non-first-section.out | 0
12 files changed, 13 insertions(+), 17 deletions(-)
delete mode 100644 tests/qapi-schema/doc-non-first-section.err
delete mode 100644 tests/qapi-schema/doc-non-first-section.json
delete mode 100644 tests/qapi-schema/doc-non-first-section.out
--
2.49.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PULL 1/5] qapi: Add more cross-references
2025-07-29 13:11 [PULL 0/5] QAPI patches for 2025-07-29 Markus Armbruster
@ 2025-07-29 13:11 ` Markus Armbruster
2025-07-29 13:11 ` [PULL 2/5] qapi/accelerator: Fix markup of heading Markus Armbruster
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2025-07-29 13:11 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, Daniel P. Berrangé, John Snow
We recently (merge commit 504632dcc631) enclosed command and type
names in `backquotes`, so they become links in generated HTML. Take
care of a few we missed.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250717115751.3832597-1-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/dump.json | 2 +-
qapi/machine.json | 2 +-
qapi/migration.json | 4 ++--
qapi/misc-i386.json | 2 +-
qapi/run-state.json | 2 +-
qapi/sockets.json | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/qapi/dump.json b/qapi/dump.json
index 32c8c1f06e..726b520870 100644
--- a/qapi/dump.json
+++ b/qapi/dump.json
@@ -79,7 +79,7 @@
#
# @detach: if true, QMP will return immediately rather than waiting
# for the dump to finish. The user can track progress using
-# "query-dump". (since 2.6).
+# `query-dump`. (since 2.6).
#
# @begin: if specified, the starting physical address.
#
diff --git a/qapi/machine.json b/qapi/machine.json
index 6f59f70ca6..038eab281c 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -2087,7 +2087,7 @@
#
# @deprecated-props: an optional list of properties that are flagged as
# deprecated by the CPU vendor. The list depends on the
-# CpuModelExpansionType: "static" properties are a subset of the
+# `CpuModelExpansionType`: "static" properties are a subset of the
# enabled-properties for the expanded model; "full" properties are
# a set of properties that are deprecated across all models for
# the architecture. (since: 10.1 -- since 9.1 on s390x --).
diff --git a/qapi/migration.json b/qapi/migration.json
index e08a99bb82..2387c21e9c 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -641,7 +641,7 @@
#
# This mode supports VFIO devices provided the user first puts the
# guest in the suspended runstate, such as by issuing
-# guest-suspend-ram to the QEMU guest agent.
+# `guest-suspend-ram` to the QEMU guest agent.
#
# Best performance is achieved when the memory backend is shared
# and the @x-ignore-shared migration capability is set, but this
@@ -1704,7 +1704,7 @@
#
# .. admonition:: Notes
#
-# 1. The 'query-migrate' command should be used to check
+# 1. The `query-migrate` command should be used to check
# migration's progress and final result (this information is
# provided by the 'status' member).
#
diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json
index c8c91a241c..d1ce8caf25 100644
--- a/qapi/misc-i386.json
+++ b/qapi/misc-i386.json
@@ -8,7 +8,7 @@
#
# Reset the RTC interrupt reinjection backlog. Can be used if another
# mechanism to synchronize guest time is in effect, for example QEMU
-# guest agent's guest-set-time command.
+# guest agent's `guest-set-time` command.
#
# Use of this command is only applicable for x86 machines with an RTC,
# and on other machines will silently return without performing any
diff --git a/qapi/run-state.json b/qapi/run-state.json
index 54ba5c9a3f..4757947ca6 100644
--- a/qapi/run-state.json
+++ b/qapi/run-state.json
@@ -20,7 +20,7 @@
# @inmigrate: guest is paused waiting for an incoming migration. Note
# that this state does not tell whether the machine will start at
# the end of the migration. This depends on the command-line -S
-# option and any invocation of 'stop' or 'cont' that has happened
+# option and any invocation of `stop` or `cont` that has happened
# since QEMU was started.
#
# @internal-error: An internal error that prevents further guest
diff --git a/qapi/sockets.json b/qapi/sockets.json
index 82046b0b3a..32fac51728 100644
--- a/qapi/sockets.json
+++ b/qapi/sockets.json
@@ -143,7 +143,7 @@
#
# @str: decimal is for file descriptor number, otherwise it's a file
# descriptor name. Named file descriptors are permitted in
-# monitor commands, in combination with the 'getfd' command.
+# monitor commands, in combination with the `getfd` command.
# Decimal file descriptors are permitted at startup or other
# contexts where no monitor context is active.
#
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PULL 2/5] qapi/accelerator: Fix markup of heading
2025-07-29 13:11 [PULL 0/5] QAPI patches for 2025-07-29 Markus Armbruster
2025-07-29 13:11 ` [PULL 1/5] qapi: Add more cross-references Markus Armbruster
@ 2025-07-29 13:11 ` Markus Armbruster
2025-07-29 13:11 ` [PULL 3/5] tests/qapi-schema: Bury dead test case doc-non-first-section Markus Armbruster
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2025-07-29 13:11 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha
The docs generated for qapi/accelerator.json shows text "=
Accelerators" instead of a heading. This is because the patch that
added the heading crossed with the commit that changed heading
markup (commit 6c10778826a "docs/sphinx: remove special parsing for
freeform sections"). Fix the markup.
Fixes: 18da42ee4273 (qapi/accel: Move definitions related to accelerators in their own file)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250724091742.1950167-2-armbru@redhat.com>
---
qapi/accelerator.json | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/accelerator.json b/qapi/accelerator.json
index 28d5ff4c49..fb28c8d920 100644
--- a/qapi/accelerator.json
+++ b/qapi/accelerator.json
@@ -4,7 +4,9 @@
# SPDX-License-Identifier: GPL-2.0-or-later
##
-# = Accelerators
+# ************
+# Accelerators
+# ************
##
{ 'include': 'common.json' }
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PULL 3/5] tests/qapi-schema: Bury dead test case doc-non-first-section
2025-07-29 13:11 [PULL 0/5] QAPI patches for 2025-07-29 Markus Armbruster
2025-07-29 13:11 ` [PULL 1/5] qapi: Add more cross-references Markus Armbruster
2025-07-29 13:11 ` [PULL 2/5] qapi/accelerator: Fix markup of heading Markus Armbruster
@ 2025-07-29 13:11 ` Markus Armbruster
2025-07-29 13:11 ` [PULL 4/5] docs/qapi-domain: Fix typos Markus Armbruster
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2025-07-29 13:11 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, Daniel P. Berrangé, John Snow
The test passed when it was added. However, the commit adding it
neglected to make Meson aware of it, so it never ran automatically.
The test stopped making sense when we changed headings markup, and
ceased to pass then. It should've been removed then. Do that now.
Fixes: 6c10778826a8 (docs/sphinx: remove special parsing for freeform sections)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250724091742.1950167-3-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
tests/qapi-schema/doc-non-first-section.err | 1 -
tests/qapi-schema/doc-non-first-section.json | 6 ------
tests/qapi-schema/doc-non-first-section.out | 0
3 files changed, 7 deletions(-)
delete mode 100644 tests/qapi-schema/doc-non-first-section.err
delete mode 100644 tests/qapi-schema/doc-non-first-section.json
delete mode 100644 tests/qapi-schema/doc-non-first-section.out
diff --git a/tests/qapi-schema/doc-non-first-section.err b/tests/qapi-schema/doc-non-first-section.err
deleted file mode 100644
index eeced2bca7..0000000000
--- a/tests/qapi-schema/doc-non-first-section.err
+++ /dev/null
@@ -1 +0,0 @@
-doc-non-first-section.json:5:1: '=' heading must come first in a comment block
diff --git a/tests/qapi-schema/doc-non-first-section.json b/tests/qapi-schema/doc-non-first-section.json
deleted file mode 100644
index 1590876061..0000000000
--- a/tests/qapi-schema/doc-non-first-section.json
+++ /dev/null
@@ -1,6 +0,0 @@
-# = section must be first line
-
-##
-#
-# = Not first
-##
diff --git a/tests/qapi-schema/doc-non-first-section.out b/tests/qapi-schema/doc-non-first-section.out
deleted file mode 100644
index e69de29bb2..0000000000
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PULL 4/5] docs/qapi-domain: Fix typos
2025-07-29 13:11 [PULL 0/5] QAPI patches for 2025-07-29 Markus Armbruster
` (2 preceding siblings ...)
2025-07-29 13:11 ` [PULL 3/5] tests/qapi-schema: Bury dead test case doc-non-first-section Markus Armbruster
@ 2025-07-29 13:11 ` Markus Armbruster
2025-07-29 13:11 ` [PULL 5/5] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly Markus Armbruster
2025-07-29 16:59 ` [PULL 0/5] QAPI patches for 2025-07-29 Stefan Hajnoczi
5 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2025-07-29 13:11 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, Manos Pitsidianakis
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250729091642.3513895-2-armbru@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
---
docs/devel/qapi-domain.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-domain.rst b/docs/devel/qapi-domain.rst
index b71890f660..fe540d1e40 100644
--- a/docs/devel/qapi-domain.rst
+++ b/docs/devel/qapi-domain.rst
@@ -9,7 +9,7 @@ in Sphinx is provided by the QAPI Domain, located in
`Python Domain
<https://www.sphinx-doc.org/en/master/usage/domains/python.html>`_
included with Sphinx, but provides special directives and roles
-speciically for annotating and documenting QAPI definitions
+for annotating and documenting QAPI definitions
specifically.
A `Domain
@@ -101,7 +101,7 @@ without types. The QAPI domain uses this class for features, returns,
and enum values.
TypedField:
- * Creates a grouped, typed field. Multiple adjacent entres will be
+ * Creates a grouped, typed field. Multiple adjacent entries will be
merged into one section, and the content will form a bulleted list.
* *Must* take at least one argument, but supports up to two -
nominally, a name and a type.
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PULL 5/5] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly
2025-07-29 13:11 [PULL 0/5] QAPI patches for 2025-07-29 Markus Armbruster
` (3 preceding siblings ...)
2025-07-29 13:11 ` [PULL 4/5] docs/qapi-domain: Fix typos Markus Armbruster
@ 2025-07-29 13:11 ` Markus Armbruster
2025-07-29 16:59 ` [PULL 0/5] QAPI patches for 2025-07-29 Stefan Hajnoczi
5 siblings, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2025-07-29 13:11 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, Manos Pitsidianakis
Section QAPI already covers it, and that's fine. It's missing from
"Sphinx documentation configuration and build machinery". Add it
there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250729091642.3513895-3-armbru@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
[Improved commit message]
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 37879ab64e..069d77f2f8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4433,6 +4433,7 @@ F: docs/requirements.txt
F: docs/sphinx/
F: docs/_templates/
F: docs/devel/docs.rst
+F: docs/devel/qapi-domain.rst
Rust build system integration
M: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
--
2.49.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PULL 0/5] QAPI patches for 2025-07-29
2025-07-29 13:11 [PULL 0/5] QAPI patches for 2025-07-29 Markus Armbruster
` (4 preceding siblings ...)
2025-07-29 13:11 ` [PULL 5/5] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly Markus Armbruster
@ 2025-07-29 16:59 ` Stefan Hajnoczi
5 siblings, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2025-07-29 16:59 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, stefanha
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-07-29 18:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-29 13:11 [PULL 0/5] QAPI patches for 2025-07-29 Markus Armbruster
2025-07-29 13:11 ` [PULL 1/5] qapi: Add more cross-references Markus Armbruster
2025-07-29 13:11 ` [PULL 2/5] qapi/accelerator: Fix markup of heading Markus Armbruster
2025-07-29 13:11 ` [PULL 3/5] tests/qapi-schema: Bury dead test case doc-non-first-section Markus Armbruster
2025-07-29 13:11 ` [PULL 4/5] docs/qapi-domain: Fix typos Markus Armbruster
2025-07-29 13:11 ` [PULL 5/5] MAINTAINERS: Cover docs/devel/qapi-domain.rst properly Markus Armbruster
2025-07-29 16:59 ` [PULL 0/5] QAPI patches for 2025-07-29 Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).