From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
qemu-riscv@nongnu.org, qemu-arm@nongnu.org,
"Bin Meng" <bmeng.cn@gmail.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Ben Dooks" <ben.dooks@codethink.co.uk>,
"Weiwei Li" <liwei1518@gmail.com>,
qemu-block@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH-for-10.1 01/11] hw/sd/sdcard: Do not ignore errors in sd_cmd_to_sendingdata()
Date: Thu, 31 Jul 2025 23:27:56 +0200 [thread overview]
Message-ID: <20250731212807.2706-2-philmd@linaro.org> (raw)
In-Reply-To: <20250731212807.2706-1-philmd@linaro.org>
Unfortunately when adding sd_cmd_to_sendingdata() in commit
f486bf7d109 we neglected to return any possible error. Fix.
Fixes: f486bf7d109 ("hw/sd/sdcard: Introduce sd_cmd_to_sendingdata and sd_generic_read_byte")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sd/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index c275fdda2d0..0bb385268ed 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1305,7 +1305,7 @@ static sd_rsp_type_t sd_cmd_to_sendingdata(SDState *sd, SDRequest req,
const void *data, size_t size)
{
if (sd->state != sd_transfer_state) {
- sd_invalid_state_for_cmd(sd, req);
+ return sd_invalid_state_for_cmd(sd, req);
}
sd->state = sd_sendingdata_state;
--
2.49.0
next prev parent reply other threads:[~2025-07-31 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 21:27 [PATCH-for-10.1 00/11] hw/sd: Fix SD cards in SPI mode Philippe Mathieu-Daudé
2025-07-31 21:27 ` Philippe Mathieu-Daudé [this message]
2025-08-01 6:40 ` [PATCH-for-10.1 01/11] hw/sd/sdcard: Do not ignore errors in sd_cmd_to_sendingdata() Richard Henderson
2025-07-31 21:27 ` [PATCH-for-10.1 02/11] hw/sd/sdbus: Provide buffer size to sdbus_do_command() Philippe Mathieu-Daudé
2025-08-01 7:08 ` Richard Henderson
2025-07-31 21:27 ` [PATCH-for-10.1 03/11] hw/sd/sdcard: Propagate response size to sd_response_r*_make() Philippe Mathieu-Daudé
2025-08-01 7:17 ` Richard Henderson
2025-07-31 21:27 ` [PATCH-for-10.1 04/11] hw/sd/sdcard: Fill SPI response bits in card code Philippe Mathieu-Daudé
2025-08-01 7:19 ` Richard Henderson
2025-08-04 9:11 ` Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 05/11] hw/sd/sdcard: Implement SPI R2 return value Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 06/11] hw/sd/sdcard: Use complete SEND_OP_COND implementation in SPI mode Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 07/11] hw/sd/sdcard: Allow using SWITCH_FUNCTION in more SPI states Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 08/11] hw/sd/sdcard: Factor spi_cmd_SEND_CxD() out Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 09/11] hw/sd/sdcard: Disable checking STBY mode in SPI SEND_CSD/CID Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 10/11] hw/sd/sdcard: Remove SDState::mode field Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 11/11] tests/functional: Test SD cards in SPI mode (using sifive_u machine) Philippe Mathieu-Daudé
2025-07-31 21:34 ` [PATCH-for-10.1 00/11] hw/sd: Fix SD cards in SPI mode Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731212807.2706-2-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=b.galvani@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bmeng.cn@gmail.com \
--cc=dbarboza@ventanamicro.com \
--cc=linux@roeck-us.net \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=strahinja.p.jankovic@gmail.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).