From: Shameer Kolothum <shameerkolothum@gmail.com>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: eric.auger@redhat.com, peter.maydell@linaro.org,
cohuck@redhat.com, sebott@redhat.com, berrange@redhat.com,
maz@kernel.org, oliver.upton@linux.dev, armbru@redhat.com,
linuxarm@huawei.com, wangzhou1@hisilicon.com,
jiangkunkun@huawei.com, jonathan.cameron@huawei.com,
salil.mehta@huawei.com, yangjinqian1@huawei.com,
shameerkolothum@gmail.com, shameerali.kolothum.thodi@huawei.com
Subject: [RFC PATCH RESEND 3/4] target/arm/kvm: Handle KVM Target Imp CPU hypercalls
Date: Fri, 1 Aug 2025 08:47:29 +0100 [thread overview]
Message-ID: <20250801074730.28329-4-shameerkolothum@gmail.com> (raw)
In-Reply-To: <20250801074730.28329-1-shameerkolothum@gmail.com>
From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
When target implementation CPUs are set, handle the related hyper calls
correctly by returning the information requested.
Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
target/arm/kvm.c | 99 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 8f325c4ca4..5adecc864e 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -1697,6 +1697,71 @@ static bool kvm_arm_handle_debug(ARMCPU *cpu,
return false;
}
+/* Only supports HYP_KVM_DISCOVER_IMPL_XXX hypercalls */
+static void arm_handle_smccc_kvm_vendor_hypercall(ARMCPU *cpu)
+{
+ CPUARMState *env = &cpu->env;
+ uint64_t param[4] = { };
+ uint64_t idx;
+
+ if (!is_a64(env)) {
+ env->regs[0] = SMCCC_RET_NOT_SUPPORTED;
+ return;
+ }
+
+ memcpy(param, env->xregs, sizeof(param));
+
+ switch (param[0]) {
+ case ARM_SMCCC_VENDOR_HYP_KVM_DISCOVER_IMPL_VER_FUNC_ID:
+ if (!target_impl_cpus_num) {
+ env->xregs[0] = SMCCC_RET_NOT_SUPPORTED;
+ return;
+ }
+ env->xregs[0] = SMCCC_RET_SUCCESS;
+ env->xregs[1] = PSCI_VERSION(1, 0);
+ env->xregs[2] = target_impl_cpus_num;
+ break;
+ case ARM_SMCCC_VENDOR_HYP_KVM_DISCOVER_IMPL_CPUS_FUNC_ID:
+ idx = param[1];
+
+ if (!target_impl_cpus_num || idx >= target_impl_cpus_num) {
+ env->xregs[0] = SMCCC_RET_INVALID_PARAMETER;
+ return;
+ }
+
+ env->xregs[0] = SMCCC_RET_SUCCESS;
+ env->xregs[1] = target_impl_cpus[idx].midr;
+ env->xregs[2] = target_impl_cpus[idx].revidr;
+ env->xregs[3] = target_impl_cpus[idx].aidr;
+ break;
+ default:
+ env->xregs[0] = SMCCC_RET_NOT_SUPPORTED;
+ }
+}
+
+static int kvm_arm_handle_hypercall(CPUState *cs, struct kvm_run *run)
+{
+ ARMCPU *cpu = ARM_CPU(cs);
+ CPUARMState *env = &cpu->env;
+
+ kvm_cpu_synchronize_state(cs);
+
+ if (run->hypercall.flags == KVM_HYPERCALL_EXIT_SMC) {
+ cs->exception_index = EXCP_SMC;
+ env->exception.syndrome = syn_aa64_smc(0);
+ } else {
+ cs->exception_index = EXCP_HVC;
+ env->exception.syndrome = syn_aa64_hvc(0);
+ }
+ env->exception.target_el = 1;
+
+ bql_lock();
+ arm_handle_smccc_kvm_vendor_hypercall(cpu);
+ bql_unlock();
+
+ return EXCP_INTERRUPT;
+}
+
int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run)
{
ARMCPU *cpu = ARM_CPU(cs);
@@ -1713,6 +1778,9 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run)
ret = kvm_arm_handle_dabt_nisv(cpu, run->arm_nisv.esr_iss,
run->arm_nisv.fault_ipa);
break;
+ case KVM_EXIT_HYPERCALL:
+ ret = kvm_arm_handle_hypercall(cs, run);
+ break;
default:
qemu_log_mask(LOG_UNIMP, "%s: un-handled exit reason %d\n",
__func__, run->exit_reason);
@@ -2212,6 +2280,29 @@ static int kvm_arm_sve_set_vls(ARMCPU *cpu)
return kvm_set_one_reg(CPU(cpu), KVM_REG_ARM64_SVE_VLS, &vls[0]);
}
+/*
+ * Supported Target Implementation CPU hypercalls:
+ * KVM_REG_ARM_VENDOR_HYP_BIT_DISCOVER_IMPL_VER = 0,
+ * KVM_REG_ARM_VENDOR_HYP_BIT_DISCOVER_IMPL_CPUS = 1
+ *
+ * Setting these bits advertises the availability of the corresponding
+ * Target Implementation CPU hypercalls to the guest.
+ */
+#define BMAP_2_DISCOVER_IMPL_BITS 0x3ULL
+static int kvm_arm_target_impl_cpus_set_hyp_bmap2(ARMCPU *cpu)
+{
+ uint64_t bmap2;
+ int ret;
+
+ ret = kvm_get_one_reg(CPU(cpu), KVM_REG_ARM_VENDOR_HYP_BMAP_2, &bmap2);
+ if (ret) {
+ return ret;
+ }
+
+ bmap2 |= BMAP_2_DISCOVER_IMPL_BITS;
+ return kvm_set_one_reg(CPU(cpu), KVM_REG_ARM_VENDOR_HYP_BMAP_2, &bmap2);
+}
+
#define ARM_CPU_ID_MPIDR 3, 0, 0, 0, 5
int kvm_arch_init_vcpu(CPUState *cs)
@@ -2293,6 +2384,14 @@ int kvm_arch_init_vcpu(CPUState *cs)
}
cpu->mp_affinity = mpidr & ARM64_AFFINITY_MASK;
+ /* Set KVM_REG_ARM_VENDOR_HYP_BMAP_2 if target impl CPUs are required */
+ if (target_impl_cpus_num) {
+ ret = kvm_arm_target_impl_cpus_set_hyp_bmap2(cpu);
+ if (ret) {
+ return ret;
+ }
+ }
+
ret = kvm_arm_init_cpreg_list(cpu);
if (ret) {
return ret;
--
2.34.1
next prev parent reply other threads:[~2025-08-01 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 7:47 [RFC PATCH RESEND 0/4] hw/arm/virt: Add support for Target Implementation CPUs Shameer Kolothum
2025-08-01 7:47 ` [RFC PATCH RESEND 1/4] target/arm/kvm: Introduce helper to check target impl CPU support Shameer Kolothum
2025-08-09 16:21 ` Eric Auger
2025-08-01 7:47 ` [RFC PATCH RESEND 2/4] target/arm/kvm: Add QAPI struct ArmTargetImplCPU Shameer Kolothum
2025-08-09 16:23 ` Eric Auger
2025-08-01 7:47 ` Shameer Kolothum [this message]
2025-09-19 10:51 ` [RFC PATCH RESEND 3/4] target/arm/kvm: Handle KVM Target Imp CPU hypercalls Sebastian Ott
2025-08-01 7:47 ` [RFC PATCH RESEND 4/4] hw/arm/virt: Add Target Implementation CPU support Shameer Kolothum
2025-08-09 16:21 ` Eric Auger
2025-08-01 8:31 ` [RFC PATCH RESEND 0/4] hw/arm/virt: Add support for Target Implementation CPUs Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801074730.28329-4-shameerkolothum@gmail.com \
--to=shameerkolothum@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jiangkunkun@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linuxarm@huawei.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=salil.mehta@huawei.com \
--cc=sebott@redhat.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yangjinqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).