qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: [PATCH v2 15/85] target/arm: Implement PIR_ELx, PIRE0_ELx, S2PIR_EL2 registers
Date: Sun,  3 Aug 2025 09:28:43 +1000	[thread overview]
Message-ID: <20250802232953.413294-16-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250802232953.413294-1-richard.henderson@linaro.org>

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/cpregs.h |  2 ++
 target/arm/cpu.h    |  4 +++
 target/arm/cpu.c    |  4 +++
 target/arm/helper.c | 70 +++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 80 insertions(+)

diff --git a/target/arm/cpregs.h b/target/arm/cpregs.h
index 2a4826f5c4..9efe9238c1 100644
--- a/target/arm/cpregs.h
+++ b/target/arm/cpregs.h
@@ -776,6 +776,8 @@ typedef enum FGTBit {
     DO_BIT(HFGRTR, ERRIDR_EL1),
     DO_REV_BIT(HFGRTR, NSMPRI_EL1),
     DO_REV_BIT(HFGRTR, NTPIDR2_EL0),
+    DO_REV_BIT(HFGRTR, NPIRE0_EL1),
+    DO_REV_BIT(HFGRTR, NPIR_EL1),
 
     /* Trap bits in HDFGRTR_EL2 / HDFGWTR_EL2, starting from bit 0. */
     DO_BIT(HDFGRTR, DBGBCRN_EL1),
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index defe2852f2..fb87fcc3e6 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -369,6 +369,9 @@ typedef struct CPUArchState {
         uint64_t tcr2_el[3];
         uint64_t vtcr_el2; /* Virtualization Translation Control.  */
         uint64_t vstcr_el2; /* Secure Virtualization Translation Control. */
+        uint64_t pir_el[4]; /* PIRE0_EL1, PIR_EL1, PIR_EL2, PIR_EL3 */
+        uint64_t pire0_el2;
+        uint64_t s2pir_el2;
         uint32_t c2_data; /* MPU data cacheable bits.  */
         uint32_t c2_insn; /* MPU instruction cacheable bits.  */
         union { /* MMU domain access control register
@@ -1738,6 +1741,7 @@ static inline void xpsr_write(CPUARMState *env, uint32_t val, uint32_t mask)
 #define SCR_ENTP2             (1ULL << 41)
 #define SCR_TCR2EN            (1ULL << 43)
 #define SCR_SCTLR2EN          (1ULL << 44)
+#define SCR_PIEN              (1ULL << 45)
 #define SCR_GPF               (1ULL << 48)
 #define SCR_MECEN             (1ULL << 49)
 #define SCR_NSE               (1ULL << 62)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index f0545a276e..b472992b4a 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -650,6 +650,10 @@ void arm_emulate_firmware_reset(CPUState *cpustate, int target_el)
             if (cpu_isar_feature(aa64_sctlr2, cpu)) {
                 env->cp15.scr_el3 |= SCR_SCTLR2EN;
             }
+            if (cpu_isar_feature(aa64_s1pie, cpu) ||
+                cpu_isar_feature(aa64_s2pie, cpu)) {
+                env->cp15.scr_el3 |= SCR_PIEN;
+            }
             if (cpu_isar_feature(aa64_mec, cpu)) {
                 env->cp15.scr_el3 |= SCR_MECEN;
             }
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 61ba9ba5b2..6353b2dea1 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -747,6 +747,10 @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
         if (cpu_isar_feature(aa64_sctlr2, cpu)) {
             valid_mask |= SCR_SCTLR2EN;
         }
+        if (cpu_isar_feature(aa64_s1pie, cpu) ||
+            cpu_isar_feature(aa64_s2pie, cpu)) {
+            valid_mask |= SCR_PIEN;
+        }
         if (cpu_isar_feature(aa64_mec, cpu)) {
             valid_mask |= SCR_MECEN;
         }
@@ -4578,6 +4582,11 @@ static void define_arm_vh_e2h_redirects_aliases(ARMCPU *cpu)
           "SCXTNUM_EL1", "SCXTNUM_EL2", "SCXTNUM_EL12",
           isar_feature_aa64_scxtnum },
 
+        { K(3, 0, 10, 2, 3), K(3, 4, 10, 2, 3), K(3, 5, 10, 2, 3),
+          "PIR_EL1", "PIR_EL2", "PIR_EL12", isar_feature_aa64_s1pie },
+        { K(3, 0, 10, 2, 2), K(3, 4, 10, 2, 2), K(3, 5, 10, 2, 2),
+          "PIRE0_EL1", "PIRE0_EL2", "PIRE0_EL12", isar_feature_aa64_s1pie },
+
         /* TODO: ARMv8.2-SPE -- PMSCR_EL2 */
         /* TODO: ARMv8.4-Trace -- TRFCR_EL2 */
     };
@@ -6242,6 +6251,60 @@ static const ARMCPRegInfo tcr2_reginfo[] = {
       .fieldoffset = offsetof(CPUARMState, cp15.tcr2_el[2]) },
 };
 
+static CPAccessResult pien_access(CPUARMState *env, const ARMCPRegInfo *ri,
+                                  bool isread)
+{
+    if (arm_feature(env, ARM_FEATURE_EL3)
+        && !(env->cp15.scr_el3 & SCR_PIEN)
+        && arm_current_el(env) < 3) {
+        return CP_ACCESS_TRAP_EL3;
+    }
+    return CP_ACCESS_OK;
+}
+
+static CPAccessResult pien_el1_access(CPUARMState *env, const ARMCPRegInfo *ri,
+                                      bool isread)
+{
+    CPAccessResult ret = access_tvm_trvm(env, ri, isread);
+    if (ret == CP_ACCESS_OK) {
+        ret = pien_access(env, ri, isread);
+    }
+    return ret;
+}
+
+static const ARMCPRegInfo s1pie_reginfo[] = {
+    { .name = "PIR_EL1", .state = ARM_CP_STATE_AA64,
+      .opc0 = 3, .opc1 = 0, .opc2 = 3, .crn = 10, .crm = 2,
+      .access = PL1_RW, .accessfn = pien_el1_access,
+      .fgt = FGT_NPIR_EL1, .nv2_redirect_offset = 0x2a0 | NV2_REDIR_NV1,
+      .fieldoffset = offsetof(CPUARMState, cp15.pir_el[1]) },
+    { .name = "PIR_EL2", .state = ARM_CP_STATE_AA64,
+      .opc0 = 3, .opc1 = 4, .opc2 = 3, .crn = 10, .crm = 2,
+      .access = PL2_RW, .accessfn = pien_access,
+      .fieldoffset = offsetof(CPUARMState, cp15.pir_el[2]) },
+    { .name = "PIR_EL3", .state = ARM_CP_STATE_AA64,
+      .opc0 = 3, .opc1 = 6, .opc2 = 3, .crn = 10, .crm = 2,
+      .access = PL3_RW,
+      .fieldoffset = offsetof(CPUARMState, cp15.pir_el[3]) },
+    { .name = "PIRE0_EL1", .state = ARM_CP_STATE_AA64,
+      .opc0 = 3, .opc1 = 0, .opc2 = 2, .crn = 10, .crm = 2,
+      .access = PL1_RW, .accessfn = pien_el1_access,
+      .fgt = FGT_NPIRE0_EL1, .nv2_redirect_offset = 0x290 | NV2_REDIR_NV1,
+      .fieldoffset = offsetof(CPUARMState, cp15.pir_el[0]) },
+    { .name = "PIRE0_EL2", .state = ARM_CP_STATE_AA64,
+      .opc0 = 3, .opc1 = 4, .opc2 = 2, .crn = 10, .crm = 2,
+      .access = PL2_RW, .accessfn = pien_access,
+      .fieldoffset = offsetof(CPUARMState, cp15.pire0_el2) },
+};
+
+static const ARMCPRegInfo s2pie_reginfo[] = {
+    { .name = "S2PIR_EL2", .state = ARM_CP_STATE_AA64,
+      .opc0 = 3, .opc1 = 4, .opc2 = 5, .crn = 10, .crm = 2,
+      .access = PL2_RW, .accessfn = pien_access,
+      .nv2_redirect_offset = 0x2b0,
+      .fieldoffset = offsetof(CPUARMState, cp15.s2pir_el2) },
+};
+
 void register_cp_regs_for_features(ARMCPU *cpu)
 {
     /* Register all the coprocessor registers based on feature bits */
@@ -7479,6 +7542,13 @@ void register_cp_regs_for_features(ARMCPU *cpu)
         define_arm_cp_regs(cpu, tcr2_reginfo);
     }
 
+    if (cpu_isar_feature(aa64_s1pie, cpu)) {
+        define_arm_cp_regs(cpu, s1pie_reginfo);
+    }
+    if (cpu_isar_feature(aa64_s2pie, cpu)) {
+        define_arm_cp_regs(cpu, s2pie_reginfo);
+    }
+
     if (cpu_isar_feature(aa64_mec, cpu)) {
         define_arm_cp_regs(cpu, mec_reginfo);
         if (cpu_isar_feature(aa64_mte, cpu)) {
-- 
2.43.0



  parent reply	other threads:[~2025-08-02 23:39 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-02 23:28 [PATCH v2 00/85] target/arm: Implement FEAT_GCS Richard Henderson
2025-08-02 23:28 ` [PATCH v2 01/85] linux-user/aarch64: Split out signal_for_exception Richard Henderson
2025-08-12  6:33   ` Philippe Mathieu-Daudé
2025-08-02 23:28 ` [PATCH v2 02/85] linux-user/aarch64: Check syndrome for EXCP_UDEF Richard Henderson
2025-08-02 23:28 ` [PATCH v2 03/85] linux-user/aarch64: Generate ESR signal records Richard Henderson
2025-08-02 23:28 ` [PATCH v2 04/85] target/arm: Add prot_check parameter to pmsav8_mpu_lookup Richard Henderson
2025-08-12  6:34   ` Philippe Mathieu-Daudé
2025-08-02 23:28 ` [PATCH v2 05/85] target/arm: Add in_prot_check to S1Translate Richard Henderson
2025-08-02 23:28 ` [PATCH v2 06/85] target/arm: Skip permission check from arm_cpu_get_phys_page_attrs_debug Richard Henderson
2025-08-02 23:28 ` [PATCH v2 07/85] target/arm: Introduce get_phys_addr_for_at Richard Henderson
2025-08-02 23:28 ` [PATCH v2 08/85] target/arm: Skip AF and DB updates for AccessType_AT Richard Henderson
2025-08-02 23:28 ` [PATCH v2 09/85] target/arm: Add prot_check parameter to do_ats_write Richard Henderson
2025-08-02 23:28 ` [PATCH v2 10/85] target/arm: Fill in HFG[RWI]TR_EL2 bits for Arm v9.5 Richard Henderson
2025-08-02 23:28 ` [PATCH v2 11/85] target/arm: Remove outdated comment for ZCR_EL12 Richard Henderson
2025-08-02 23:28 ` [PATCH v2 12/85] target/arm: Implement FEAT_ATS1A Richard Henderson
2025-08-02 23:28 ` [PATCH v2 13/85] target/arm: Add isar feature test for FEAT_S1PIE, FEAT_S2PIE Richard Henderson
2025-08-02 23:28 ` [PATCH v2 14/85] target/arm: Enable TCR2_ELx.PIE Richard Henderson
2025-08-02 23:28 ` Richard Henderson [this message]
2025-08-02 23:28 ` [PATCH v2 16/85] target/arm: Force HPD for stage2 translations Richard Henderson
2025-08-02 23:28 ` [PATCH v2 17/85] target/arm: Cache NV1 early in get_phys_addr_lpae Richard Henderson
2025-08-02 23:28 ` [PATCH v2 18/85] target/arm: Populate PIE in aa64_va_parameters Richard Henderson
2025-08-02 23:28 ` [PATCH v2 19/85] target/arm: Implement get_S1prot_indirect Richard Henderson
2025-08-02 23:28 ` [PATCH v2 20/85] target/arm: Implement get_S2prot_indirect Richard Henderson
2025-08-02 23:28 ` [PATCH v2 21/85] target/arm: Do not migrate env->exception Richard Henderson
2025-08-12  6:24   ` Philippe Mathieu-Daudé
2025-08-02 23:28 ` [PATCH v2 22/85] target/arm: Expand CPUARMState.exception.syndrome to 64 bits Richard Henderson
2025-08-02 23:28 ` [PATCH v2 23/85] target/arm: Expand syndrome parameter to raise_exception* Richard Henderson
2025-08-12  6:26   ` Philippe Mathieu-Daudé
2025-08-12 12:15     ` Richard Henderson
2025-08-12 13:14       ` Philippe Mathieu-Daudé
2025-08-02 23:28 ` [PATCH v2 24/85] target/arm: Implement dirtybit check for PIE Richard Henderson
2025-08-02 23:28 ` [PATCH v2 25/85] target/arm: Enable FEAT_S1PIE and FEAT_S2PIE on -cpu max Richard Henderson
2025-08-02 23:28 ` [PATCH v2 26/85] include/hw/core/cpu: Introduce MMUIdxMap Richard Henderson
2025-08-12  6:22   ` Philippe Mathieu-Daudé
2025-08-02 23:28 ` [PATCH v2 27/85] include/hw/core/cpu: Introduce cpu_tlb_fast Richard Henderson
2025-08-12  6:22   ` Philippe Mathieu-Daudé
2025-08-02 23:28 ` [PATCH v2 28/85] include/hw/core/cpu: Invert the indexing into CPUTLBDescFast Richard Henderson
2025-08-12  6:23   ` Philippe Mathieu-Daudé
2025-08-02 23:28 ` [PATCH v2 29/85] target/hppa: Adjust mmu indexes to begin with 0 Richard Henderson
2025-08-02 23:28 ` [PATCH v2 30/85] include/exec/memopidx: Adjust for 32 mmu indexes Richard Henderson
2025-08-02 23:28 ` [PATCH v2 31/85] include/hw/core/cpu: Widen MMUIdxMap Richard Henderson
2025-08-12  6:16   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 32/85] target/arm: Split out mmuidx.h from cpu.h Richard Henderson
2025-08-12  6:17   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 33/85] target/arm: Convert arm_mmu_idx_to_el from switch to table Richard Henderson
2025-08-04 17:45   ` Pierrick Bouvier
2025-08-02 23:29 ` [PATCH v2 34/85] target/arm: Remove unused env argument from regime_el Richard Henderson
2025-08-12  6:15   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 35/85] target/arm: Convert regime_el from switch to table Richard Henderson
2025-08-02 23:29 ` [PATCH v2 36/85] target/arm: Convert regime_has_2_ranges " Richard Henderson
2025-08-02 23:29 ` [PATCH v2 37/85] target/arm: Remove unused env argument from regime_is_pan Richard Henderson
2025-08-12  6:15   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 38/85] target/arm: Convert regime_is_pan from switch to table Richard Henderson
2025-08-02 23:29 ` [PATCH v2 39/85] target/arm: Remove unused env argument from regime_is_user Richard Henderson
2025-08-12  6:14   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 40/85] target/arm: Convert regime_is_user from switch to table Richard Henderson
2025-08-12  6:13   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 41/85] target/arm: Convert arm_mmu_idx_is_stage1_of_2 " Richard Henderson
2025-08-12  6:14   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 42/85] target/arm: Convert regime_is_stage2 " Richard Henderson
2025-08-12  6:13   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 43/85] target/arm: Introduce mmu indexes for GCS Richard Henderson
2025-08-02 23:29 ` [PATCH v2 44/85] target/arm: Introduce regime_to_gcs Richard Henderson
2025-08-02 23:29 ` [PATCH v2 45/85] target/arm: Support page protections for GCS mmu indexes Richard Henderson
2025-08-02 23:29 ` [PATCH v2 46/85] target/arm: Implement gcs bit for data abort Richard Henderson
2025-08-02 23:29 ` [PATCH v2 47/85] target/arm: Add GCS cpregs Richard Henderson
2025-08-02 23:29 ` [PATCH v2 48/85] target/arm: Add GCS enable and trap levels to DisasContext Richard Henderson
2025-08-02 23:29 ` [PATCH v2 49/85] target/arm: Implement FEAT_CHK Richard Henderson
2025-08-02 23:29 ` [PATCH v2 50/85] target/arm: Expand pstate to 64 bits Richard Henderson
2025-08-12  6:11   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 51/85] target/arm: Add syndrome data for EC_GCS Richard Henderson
2025-08-02 23:29 ` [PATCH v2 52/85] target/arm: Implement EXLOCKException for ELR_ELx and SPSR_ELx Richard Henderson
2025-08-02 23:29 ` [PATCH v2 53/85] target/arm: Split {arm,core}_user_mem_index Richard Henderson
2025-08-02 23:29 ` [PATCH v2 54/85] target/arm: Introduce delay_exception{_el} Richard Henderson
2025-08-02 23:29 ` [PATCH v2 55/85] target/arm: Emit HSTR trap exception out of line Richard Henderson
2025-08-02 23:29 ` [PATCH v2 56/85] target/arm: Emit v7m LTPSIZE " Richard Henderson
2025-08-02 23:29 ` [PATCH v2 57/85] target/arm: Implement GCSSTR, GCSSTTR Richard Henderson
2025-08-02 23:29 ` [PATCH v2 58/85] target/arm: Implement GCSB Richard Henderson
2025-08-02 23:29 ` [PATCH v2 59/85] target/arm: Implement GCSPUSHM Richard Henderson
2025-08-02 23:29 ` [PATCH v2 60/85] target/arm: Implement GCSPOPM Richard Henderson
2025-08-02 23:29 ` [PATCH v2 61/85] target/arm: Implement GCSPUSHX Richard Henderson
2025-08-02 23:29 ` [PATCH v2 62/85] target/arm: Implement GCSPOPX Richard Henderson
2025-08-02 23:29 ` [PATCH v2 63/85] target/arm: Implement GCSPOPCX Richard Henderson
2025-08-02 23:29 ` [PATCH v2 64/85] target/arm: Implement GCSSS1 Richard Henderson
2025-08-02 23:29 ` [PATCH v2 65/85] target/arm: Implement GCSSS2 Richard Henderson
2025-08-02 23:29 ` [PATCH v2 66/85] target/arm: Add gcs record for BL Richard Henderson
2025-08-02 23:29 ` [PATCH v2 67/85] target/arm: Add gcs record for BLR Richard Henderson
2025-08-02 23:29 ` [PATCH v2 68/85] target/arm: Add gcs record for BLR with PAuth Richard Henderson
2025-08-02 23:29 ` [PATCH v2 69/85] target/arm: Load gcs record for RET Richard Henderson
2025-08-02 23:29 ` [PATCH v2 70/85] target/arm: Load gcs record for RET with PAuth Richard Henderson
2025-08-02 23:29 ` [PATCH v2 71/85] target/arm: Copy EXLOCKEn to EXLOCK on exception to the same EL Richard Henderson
2025-08-02 23:29 ` [PATCH v2 72/85] target/arm: Implement EXLOCK check during exception return Richard Henderson
2025-08-02 23:29 ` [PATCH v2 73/85] target/arm: Enable FEAT_GCS with -cpu max Richard Henderson
2025-08-02 23:29 ` [PATCH v2 74/85] linux-user/aarch64: Implement prctls for GCS Richard Henderson
2025-08-02 23:29 ` [PATCH v2 75/85] linux-user/aarch64: Allocate new gcs stack on clone Richard Henderson
2025-08-02 23:29 ` [PATCH v2 76/85] linux-user/aarch64: Release gcs stack on thread exit Richard Henderson
2025-08-02 23:29 ` [PATCH v2 77/85] linux-user/aarch64: Implement map_shadow_stack syscall Richard Henderson
2025-08-02 23:29 ` [PATCH v2 78/85] target/arm: Enable GCSPR_EL0 for read in user-mode Richard Henderson
2025-08-02 23:29 ` [PATCH v2 79/85] linux-user/aarch64: Inject SIGSEGV for GCS faults Richard Henderson
2025-08-02 23:29 ` [PATCH v2 80/85] linux-user/aarch64: Generate GCS signal records Richard Henderson
2025-08-02 23:29 ` [PATCH v2 81/85] linux-user: Change exported get_elf_hwcap to abi_ulong Richard Henderson
2025-08-12  6:44   ` Philippe Mathieu-Daudé
2025-08-02 23:29 ` [PATCH v2 82/85] linux-user/aarch64: Enable GCS in HWCAP Richard Henderson
2025-08-02 23:29 ` [PATCH v2 83/85] tests/tcg/aarch64: Add gcsstr Richard Henderson
2025-08-02 23:29 ` [PATCH v2 84/85] tests/tcg/aarch64: Add gcspushm Richard Henderson
2025-08-02 23:29 ` [PATCH v2 85/85] tests/tcg/aarch64: Add gcsss Richard Henderson
2025-08-12  3:46 ` [PATCH v2 00/85] target/arm: Implement FEAT_GCS Thiago Jung Bauermann
2025-08-12 12:07   ` Richard Henderson
2025-08-14 10:15     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250802232953.413294-16-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).