qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, philmd@linaro.org,
	"Weiwei Li" <liwei1518@gmail.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	richard.henderson@linaro.org,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	qemu-arm@nongnu.org,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: [PATCH v3 10/12] semihosting/arm-compat-semi: eradicate target_long
Date: Mon,  4 Aug 2025 11:39:48 -0700	[thread overview]
Message-ID: <20250804183950.3147154-11-pierrick.bouvier@linaro.org> (raw)
In-Reply-To: <20250804183950.3147154-1-pierrick.bouvier@linaro.org>

We use int64_t or int32_t depending on ret size.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 semihosting/arm-compat-semi.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index f593239cc9a..55d7bf29ad6 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -501,10 +501,13 @@ void do_common_semihosting(CPUState *cs)
         break;
 
     case TARGET_SYS_ISERROR:
+    {
         GET_ARG(0);
-        common_semi_set_ret(cs, (target_long)arg0 < 0);
+        bool ret = is_64bit_semihosting(env) ?
+                   (int64_t)arg0 < 0 : (int32_t)arg0 < 0;
+        common_semi_set_ret(cs, ret);
         break;
-
+    }
     case TARGET_SYS_ISTTY:
         GET_ARG(0);
         semihost_sys_isatty(cs, common_semi_istty_cb, arg0);
-- 
2.47.2



  parent reply	other threads:[~2025-08-04 19:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 18:39 [PATCH v3 00/12] single-binary: compile once semihosting Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 01/12] semihosting/syscalls: compile once in system and per target for user mode Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 02/12] semihosting/syscalls: replace uint64_t with vaddr where appropriate Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 03/12] semihosting/guestfd: compile once for system/user Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 04/12] semihosting/arm-compat-semi: change common_semi_sys_exit_extended Pierrick Bouvier
2025-08-04 22:23   ` Richard Henderson
2025-08-04 18:39 ` [PATCH v3 05/12] target/riscv/common-semi-target: remove sizeof(target_ulong) Pierrick Bouvier
2025-08-04 22:24   ` Richard Henderson
2025-08-04 18:39 ` [PATCH v3 06/12] target/{arm, riscv}/common-semi-target: eradicate target_ulong Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 07/12] include/semihosting/common-semi: extract common_semi API Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 08/12] semihosting/arm-compat-semi: eradicate sizeof(target_ulong) Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 09/12] semihosting/arm-compat-semi: replace target_ulong with uint64_t Pierrick Bouvier
2025-08-04 22:42   ` Philippe Mathieu-Daudé
2025-08-04 22:43     ` Pierrick Bouvier
2025-08-04 18:39 ` Pierrick Bouvier [this message]
2025-08-04 18:39 ` [PATCH v3 11/12] semihosting/arm-compat-semi: remove dependency on cpu.h Pierrick Bouvier
2025-08-04 18:39 ` [PATCH v3 12/12] semihosting/arm-compat-semi: compile once in system and per target for user mode Pierrick Bouvier
2025-08-22 14:31 ` [PATCH v3 00/12] single-binary: compile once semihosting Pierrick Bouvier
2025-08-22 14:56   ` Philippe Mathieu-Daudé
2025-08-22 14:57     ` Pierrick Bouvier
2025-08-22 15:04       ` Pierrick Bouvier
2025-08-25  9:56       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250804183950.3147154-11-pierrick.bouvier@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=liwei1518@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).