qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Mads Ynddal" <mads@ynddal.dk>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 1/6] checkpatch: cull trailing '*/' in SPDX check
Date: Tue,  5 Aug 2025 21:03:29 +0100	[thread overview]
Message-ID: <20250805200334.629493-2-berrange@redhat.com> (raw)
In-Reply-To: <20250805200334.629493-1-berrange@redhat.com>

Sometimes SPDX expressions appear inside C comments, and this
confuses checkpatch.pl. Drop the closing C comment characters
to avoid this.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 scripts/checkpatch.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 833f20f555..91616c974f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1368,6 +1368,9 @@ sub checkspdx {
     $expr =~ s/^\s*//g;
     $expr =~ s/\s*$//g;
 
+    # Cull C comment end
+    $expr =~ s/\*\/.*//;
+
     my @bits = split / +/, $expr;
 
     my $prefer = "GPL-2.0-or-later";
-- 
2.50.1



  reply	other threads:[~2025-08-05 20:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05 20:03 [PATCH 0/6] tracetool: add test suite to improve reviewability Daniel P. Berrangé
2025-08-05 20:03 ` Daniel P. Berrangé [this message]
2025-08-05 20:03 ` [PATCH 2/6] tracetool: eliminate trailing whitespace in C format Daniel P. Berrangé
2025-08-06  6:42   ` Philippe Mathieu-Daudé
2025-08-05 20:03 ` [PATCH 3/6] tracetool: avoid space after "*" in arg types Daniel P. Berrangé
2025-08-06  6:43   ` Philippe Mathieu-Daudé
2025-08-05 20:03 ` [PATCH 4/6] tracetool: include SPDX-License-Identifier in generated files Daniel P. Berrangé
2025-08-06  6:44   ` Philippe Mathieu-Daudé
2025-08-06  9:00   ` Thomas Huth
2025-08-05 20:03 ` [PATCH 5/6] tracetool: add test suite for tracetool with reference output Daniel P. Berrangé
2025-08-06  9:08   ` Thomas Huth
2025-08-05 20:03 ` [PATCH 6/6] tracetool: drop the probe "__nocheck__" wrapping Daniel P. Berrangé
2025-08-06  6:46   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250805200334.629493-2-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mads@ynddal.dk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).