From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 422E9C87FCA for ; Thu, 7 Aug 2025 11:51:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ujz8c-000076-Dt; Thu, 07 Aug 2025 07:50:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujz8Z-0008Mo-Ko for qemu-devel@nongnu.org; Thu, 07 Aug 2025 07:50:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujz8X-0002AB-So for qemu-devel@nongnu.org; Thu, 07 Aug 2025 07:50:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754567420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PfVMRjMgFrK9uJtjCSCHS1Hxw5F1UT56EZV0qI+RxhI=; b=RIgOBPapis9TBdAMRs72nTEWGofmIXKwz7jsQA3+L9Jn/VCeUcBOTaZ9+WwQFR+v6tvMOZ IwFpo9K5fL2hjkMG2PaUhnxzdcNyctKHXxKpo0kIHyNJ67jllVo8s8mV6Zko0tfq4RnTYV cB6T4iBtAobuvt9FPpyRFvR/B81PDnk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-H_ubU73IMSucerB-3GwloA-1; Thu, 07 Aug 2025 07:50:16 -0400 X-MC-Unique: H_ubU73IMSucerB-3GwloA-1 X-Mimecast-MFC-AGG-ID: H_ubU73IMSucerB-3GwloA_1754567416 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 82B451800451; Thu, 7 Aug 2025 11:50:15 +0000 (UTC) Received: from fedora (unknown [10.43.3.128]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1146519560AD; Thu, 7 Aug 2025 11:50:12 +0000 (UTC) From: Juraj Marcin To: qemu-devel@nongnu.org Cc: Juraj Marcin , Jiri Denemark , Stefan Weil , Paolo Bonzini , Peter Xu , Fabiano Rosas Subject: [RFC PATCH 1/4] qemu-thread: Introduce qemu_thread_detach() Date: Thu, 7 Aug 2025 13:49:09 +0200 Message-ID: <20250807114922.1013286-2-jmarcin@redhat.com> In-Reply-To: <20250807114922.1013286-1-jmarcin@redhat.com> References: <20250807114922.1013286-1-jmarcin@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=jmarcin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Juraj Marcin Currently, QEMU threads abstraction supports both joinable and detached threads, but once a thread is marked as joinable it must be joined using qemu_thread_join() and cannot be detached later. For POSIX implementation, pthread_detach() is used. For Windows, marking the thread as detached and releasing critical section is enough as thread handle is released by qemu_thread_create(). Signed-off-by: Juraj Marcin --- include/qemu/thread.h | 1 + util/qemu-thread-posix.c | 8 ++++++++ util/qemu-thread-win32.c | 10 ++++++++++ 3 files changed, 19 insertions(+) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index f0302ed01f..8a6d1ba98e 100644 --- a/include/qemu/thread.h +++ b/include/qemu/thread.h @@ -212,6 +212,7 @@ int qemu_thread_set_affinity(QemuThread *thread, unsigned long *host_cpus, int qemu_thread_get_affinity(QemuThread *thread, unsigned long **host_cpus, unsigned long *nbits); void *qemu_thread_join(QemuThread *thread); +void qemu_thread_detach(QemuThread *thread); void qemu_thread_get_self(QemuThread *thread); bool qemu_thread_is_self(QemuThread *thread); G_NORETURN void qemu_thread_exit(void *retval); diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c index ba725444ba..20442456b5 100644 --- a/util/qemu-thread-posix.c +++ b/util/qemu-thread-posix.c @@ -536,3 +536,11 @@ void *qemu_thread_join(QemuThread *thread) } return ret; } + +void qemu_thread_detach(QemuThread *thread) +{ + int err = pthread_detach(thread->thread); + if (err) { + error_exit(err, __func__); + } +} diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c index ca2e0b512e..bdfb7b4aee 100644 --- a/util/qemu-thread-win32.c +++ b/util/qemu-thread-win32.c @@ -328,6 +328,16 @@ void *qemu_thread_join(QemuThread *thread) return ret; } +void qemu_thread_detach(QemuThread *thread) +{ + QemuThreadData *data; + + if (data->mode == QEMU_THREAD_JOINABLE) { + data->mode = QEMU_THREAD_DETACHED; + DeleteCriticalSection(&data->cs); + } +} + static bool set_thread_description(HANDLE h, const char *name) { HRESULT hr; -- 2.50.1