* [PULL 1/3] docs/devel/qapi-code-gen: Add two cross-references we missed
2025-08-09 5:50 [PULL 0/3] QAPI patches for 2025-08-09 Markus Armbruster
@ 2025-08-09 5:50 ` Markus Armbruster
2025-08-09 5:50 ` [PULL 2/3] docs/devel/qapi-code-gen: Fix typos in QAPI schema language grammar Markus Armbruster
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2025-08-09 5:50 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, John Snow
Missed in commit 9c66762a601 (docs/qapi-code-gen: add
cross-references).
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250731054044.4011789-2-armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
docs/devel/qapi-code-gen.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index dfdbeac5a5..138921b386 100644
--- a/docs/devel/qapi-code-gen.rst
+++ b/docs/devel/qapi-code-gen.rst
@@ -646,9 +646,9 @@ Member 'event' names the event. This is the event name used in the
Client JSON Protocol.
Member 'data' defines the event-specific data. It defaults to an
-empty MEMBERS object.
+empty MEMBERS_ object.
-If 'data' is a MEMBERS object, then MEMBERS defines event-specific
+If 'data' is a MEMBERS_ object, then MEMBERS defines event-specific
data just like a struct type's 'data' defines struct type members.
If 'data' is a STRING, then STRING names a complex type whose members
--
2.49.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PULL 2/3] docs/devel/qapi-code-gen: Fix typos in QAPI schema language grammar
2025-08-09 5:50 [PULL 0/3] QAPI patches for 2025-08-09 Markus Armbruster
2025-08-09 5:50 ` [PULL 1/3] docs/devel/qapi-code-gen: Add two cross-references we missed Markus Armbruster
@ 2025-08-09 5:50 ` Markus Armbruster
2025-08-09 5:50 ` [PULL 3/3] docs/devel/qapi-code-gen: Update cross-reference syntax Markus Armbruster
2025-08-11 20:43 ` [PULL 0/3] QAPI patches for 2025-08-09 Stefan Hajnoczi
3 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2025-08-09 5:50 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, John Snow
Fixes: 3248c1aaf2db (docs: update the documentation upfront about schema configuration)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250731054044.4011789-3-armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
docs/devel/qapi-code-gen.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index 138921b386..2cd51729c3 100644
--- a/docs/devel/qapi-code-gen.rst
+++ b/docs/devel/qapi-code-gen.rst
@@ -786,8 +786,8 @@ Configuring the schema
Syntax::
COND = STRING
- | { 'all: [ COND, ... ] }
- | { 'any: [ COND, ... ] }
+ | { 'all': [ COND, ... ] }
+ | { 'any': [ COND, ... ] }
| { 'not': COND }
All definitions take an optional 'if' member. Its value must be a
--
2.49.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PULL 3/3] docs/devel/qapi-code-gen: Update cross-reference syntax
2025-08-09 5:50 [PULL 0/3] QAPI patches for 2025-08-09 Markus Armbruster
2025-08-09 5:50 ` [PULL 1/3] docs/devel/qapi-code-gen: Add two cross-references we missed Markus Armbruster
2025-08-09 5:50 ` [PULL 2/3] docs/devel/qapi-code-gen: Fix typos in QAPI schema language grammar Markus Armbruster
@ 2025-08-09 5:50 ` Markus Armbruster
2025-08-11 20:43 ` [PULL 0/3] QAPI patches for 2025-08-09 Stefan Hajnoczi
3 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2025-08-09 5:50 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, John Snow
The new QAPI code generator creates a cross-reference target for each
definition documentation. Enabled for the QEMU QMP Reference manual
in commit a377f39f38f, and for the QEMU Storage Daemon QMP Reference
Manual and the QEMU Guest Agent Protocol Reference in commit
a6af5443440. We've put these targets to use since, but neglected to
update doc comment markup documentation. Do that now.
Co-developed-by: John Snow <jsnow@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250731054044.4011789-4-armbru@redhat.com>
---
docs/devel/qapi-code-gen.rst | 11 ++++++++---
docs/devel/qapi-domain.rst | 1 +
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index 2cd51729c3..d97602f464 100644
--- a/docs/devel/qapi-code-gen.rst
+++ b/docs/devel/qapi-code-gen.rst
@@ -943,9 +943,14 @@ The usual ****strong****, *\*emphasized\** and ````literal```` markup
should be used. If you need a single literal ``*``, you will need to
backslash-escape it.
-Use ``@foo`` to reference a name in the schema. This is an rST
-extension. It is rendered the same way as ````foo````, but carries
-additional meaning.
+Use ```foo``` to reference a definition in the schema. This generates
+a link to the definition. In the event that such a cross-reference is
+ambiguous, you can use `QAPI cross-reference roles
+<QAPI-domain-cross-references>` to disambiguate.
+
+Use @foo to reference a member description within the current
+definition. This is an rST extension. It is currently rendered the
+same way as ````foo````, but carries additional meaning.
Example::
diff --git a/docs/devel/qapi-domain.rst b/docs/devel/qapi-domain.rst
index fe540d1e40..1924f12d42 100644
--- a/docs/devel/qapi-domain.rst
+++ b/docs/devel/qapi-domain.rst
@@ -375,6 +375,7 @@ Will allow you to add arbitrary field lists in QAPI directives::
:see also: Lorem ipsum, dolor sit amet ...
+.. _QAPI-domain-cross-references:
Cross-references
================
--
2.49.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PULL 0/3] QAPI patches for 2025-08-09
2025-08-09 5:50 [PULL 0/3] QAPI patches for 2025-08-09 Markus Armbruster
` (2 preceding siblings ...)
2025-08-09 5:50 ` [PULL 3/3] docs/devel/qapi-code-gen: Update cross-reference syntax Markus Armbruster
@ 2025-08-11 20:43 ` Stefan Hajnoczi
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2025-08-11 20:43 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, stefanha
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread