From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99C88CA0EC4 for ; Tue, 12 Aug 2025 17:04:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulsOO-0004dn-A5; Tue, 12 Aug 2025 13:02:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulsON-0004cL-1h for qemu-devel@nongnu.org; Tue, 12 Aug 2025 13:02:31 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ulsOI-00089N-3b for qemu-devel@nongnu.org; Tue, 12 Aug 2025 13:02:28 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3b7892609a5so3397781f8f.1 for ; Tue, 12 Aug 2025 10:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755018139; x=1755622939; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dJY01AiwGpenoup2DC6cwZzWsgWRqxLsf1J5dtZCptc=; b=VIrL8hNm+lgWhclOEPpnklB6QP2lmDlb1Mw1irwl3MS1mkmmnCYwRch57hfKtaLXlc WqwNsGXw1qrKaYm/RF5SdoctwvndLNtAERg5nSCAdeUN9N+Xg2p1fBbiz1FzHnGzXrMl r6lhqxgL8Igud0kuKJRn0MbvQJJkvW2vYsuCKwTzNj3lsw5uJCcnMk+pXFxzlitWeorC 30OGtH1Lz8EE+6lEpfvLCGkTXk03kG4Z5N+JXyN9mQuQA7SWiNtI8FpH8T1rzsgpWYY5 Nv3/WkapmVsPBUUn/7c2xjzx3BmWMLaOM2j7qmJEsTNt7pcZSgsil5D93GpP4UouEnTj en3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755018139; x=1755622939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dJY01AiwGpenoup2DC6cwZzWsgWRqxLsf1J5dtZCptc=; b=PSItEdvf4hX4Ihupjr3Z5LhIhXWO+jteU90+Fg4OYhzCzVpEEAO+KhK4QE6T6D6x1Y IWKmGZ06KI/Ez1G2wd+WqIlJCQ/0mBpV2QODpswg2PHGgGFEbT28Fs5j/HtpiuSwi0m9 NMKl9FASUN5vWoIDQn/kjMw0PQ0G2bcPs3btv1XePwrvr3vF/6+R4xiDlUmMdAmXNoyX KRKheQ+6S+usP9g5ruVzkhNH95SXEwayu2bDDyWDOr6bhtb2f+mF3rXwOMd+qPEa/nNn enX7sp0fzCu6F+iPbuIu3b3xpnxKAj1X8Lm1k6iF+Gd0VvGMfz2R4MSqkNbIC9MUpzHp FwwQ== X-Gm-Message-State: AOJu0Yy9iaG1uAZV6aLGmlHDFun6YQoO+wxHpSiBW9bRwK5FdU4mCUOA GBQz+hkoshYY6pL20Dpyd/jZTVSL8IiuOfTQbA5ABjE5H6mNILd8RSUS6KMaHFJDwrAJZ8fTpDU g3lH2 X-Gm-Gg: ASbGncsf37aJOX2oYujNbolkaKNHRCn7tFkChmtRXh3qF+fMANKjMj13qI9Nha5hsX1 59uNOEbHoSx3nj7lLNxyeC4d8E/sMAr64/WVh97WpikZlt/O/zclZPgwSGvUiZ7YLpN62ddp+pc 6C5JgCpbpdkHw7HD//rhsgbkqNxuEx352Or4YZMp7SG2tO6bS1/xGzsff75xDsIm6jU6mylPNTC zmpWPpRfXpRLiJ3wABuHlHrxct202mPSes71PY2cvi7hfraBw/bI8s1tfhIK9mnZLTYsHUCM+J6 3HX5ol9b/lPdQ1o0oEJGLh+AqqJt/fjtpfJoRR9meJLV+Y1+jxjLeT6ZmqkbAGvX+sbD1+DG69x WG2AHYFqM8s1mVi7fSUzsGboHBEUQtwo0mBUf7pcf+OVKqfDkX2pAL+/BFJOd4KTR+db+LUjb X-Google-Smtp-Source: AGHT+IGfN6do/RZU+7MN5AJSRmaQ0spPgWUakyiB7qSGoVI/RQcgLmCUE5BLD6FnUt303XRbYtfukg== X-Received: by 2002:a05:6000:40cd:b0:3b5:dd38:3523 with SMTP id ffacd0b85a97d-3b917246236mr128443f8f.8.1755018138720; Tue, 12 Aug 2025 10:02:18 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e587e154sm328347905e9.27.2025.08.12.10.02.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Aug 2025 10:02:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Guenter Roeck , Gustavo Romero , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alistair Francis , Palmer Dabbelt , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-riscv@nongnu.org Subject: [PULL 2/2] tests/functional: Test SPI-SD adapter without SD card connected Date: Tue, 12 Aug 2025 19:02:14 +0200 Message-ID: <20250812170214.81484-1-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250812165642.81157-1-philmd@linaro.org> References: <20250812165642.81157-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org SPI-SD adapter should be usable, even without any SD card wired. Refactor test_riscv64_sifive_u_mmc_spi() to make it more generic and add another test, inspired by this report: https://lore.kernel.org/qemu-devel/5b2dc427-f0db-4332-a997-fe0c82415acd@roeck-us.net/ Inspired-by: Guenter Roeck Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Gustavo Romero Reviewed-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20250812140415.70153-3-philmd@linaro.org> --- tests/functional/test_riscv64_sifive_u.py | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tests/functional/test_riscv64_sifive_u.py b/tests/functional/test_riscv64_sifive_u.py index dc4cb8a4a96..358ff0d1f60 100755 --- a/tests/functional/test_riscv64_sifive_u.py +++ b/tests/functional/test_riscv64_sifive_u.py @@ -27,25 +27,37 @@ class SifiveU(LinuxKernelTest): 'rootfs.ext2.gz'), 'b6ed95610310b7956f9bf20c4c9c0c05fea647900df441da9dfe767d24e8b28b') - def test_riscv64_sifive_u_mmc_spi(self): + def do_test_riscv64_sifive_u_mmc_spi(self, connect_card): self.set_machine('sifive_u') kernel_path = self.ASSET_KERNEL.fetch() rootfs_path = self.uncompress(self.ASSET_ROOTFS) self.vm.set_console() kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + - 'root=/dev/mmcblk0 rootwait ' 'earlycon=sbi console=ttySIF0 ' - 'panic=-1 noreboot') + 'root=/dev/mmcblk0 ') self.vm.add_args('-kernel', kernel_path, - '-drive', f'file={rootfs_path},if=sd,format=raw', '-append', kernel_command_line, '-no-reboot') + if connect_card: + kernel_command_line += 'panic=-1 noreboot rootwait ' + self.vm.add_args('-drive', f'file={rootfs_path},if=sd,format=raw') + pattern = 'Boot successful.' + else: + kernel_command_line += 'panic=0 noreboot ' + pattern = 'Cannot open root device "mmcblk0" or unknown-block(0,0)' + self.vm.launch() - self.wait_for_console_pattern('Boot successful.') + self.wait_for_console_pattern(pattern) os.remove(rootfs_path) + def test_riscv64_sifive_u_nommc_spi(self): + self.do_test_riscv64_sifive_u_mmc_spi(False) + + def test_riscv64_sifive_u_mmc_spi(self): + self.do_test_riscv64_sifive_u_mmc_spi(True) + if __name__ == '__main__': LinuxKernelTest.main() -- 2.49.0