From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 008B9CA0EE4 for ; Thu, 14 Aug 2025 08:39:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1umTTb-0007Iz-UM; Thu, 14 Aug 2025 04:38:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umTTZ-0007Id-Jq for qemu-devel@nongnu.org; Thu, 14 Aug 2025 04:38:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umTTW-00060Q-Fu for qemu-devel@nongnu.org; Thu, 14 Aug 2025 04:38:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755160694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Vt3vAQMbGJrssHjDe9lFN8tyhmuabahHNW+6vZ7Fa1g=; b=Q+lFT2EY11Lc5UiND5rEULuq0sam5D61GmGTiY87Iin36t9U55pJvi7piCXvemXn/Jl6ZG WURYfRoK1M4nrWd3GtHymdNOi7nSjwgF5+fE4XFcJFt6y8CJVRk6tJKI5eQomFIy4Awpmm q2s9iMTwVuCziHG3n2S99qfZVn6P2mI= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-1lSjWVapMUWP_viHOV_HzQ-1; Thu, 14 Aug 2025 04:38:08 -0400 X-MC-Unique: 1lSjWVapMUWP_viHOV_HzQ-1 X-Mimecast-MFC-AGG-ID: 1lSjWVapMUWP_viHOV_HzQ_1755160687 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 50D8F1955D48; Thu, 14 Aug 2025 08:38:06 +0000 (UTC) Received: from localhost.localdomain (unknown [10.45.225.203]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DDF9B180035C; Thu, 14 Aug 2025 08:37:58 +0000 (UTC) From: Albert Esteve To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Fabiano Rosas , hi@alyssa.is, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , slp@redhat.com, Stefano Garzarella , Paolo Bonzini , david@redhat.com, jasowang@redhat.com, stefanha@redhat.com, dbassey@redhat.com, stevensd@chromium.org, Albert Esteve Subject: [PATCH v6 0/8] vhost-user: Add SHMEM_MAP/UNMAP requests Date: Thu, 14 Aug 2025 10:37:41 +0200 Message-ID: <20250814083749.1317197-1-aesteve@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=aesteve@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi all, v5->v6 - Added intermediate QOM object to manage shared MemoryRegion lifecycle with reference counting, automatic cleanup, and proper mmap/munmap handling - Resolved BAR conflict, change from 2 to 3 to avoid conflict with `modern-pio-notify=on` - Added SHMEM_CONFIG validation in vhost-user-test - Changed VirtSharedMemory -> VirtioSharedMemory - Changed MappedMemoryRegion -> VirtioSharedMemoryMapping - Changed from heap-allocated MemoryRegion *mr to embedded MemoryRegion mr in VirtioSharedMemory structure to eliminate memory leaks and simplify cleanup - Fixed VirtioSharedMemory initialization and cleanup with memory_region_init() and object_unparent() - Other minor fixes, typos, and updates. This patch series implements dynamic fd-backed memory mapping support for vhost-user backends, enabling backends to dynamically request memory mappings and unmappings during runtime through the new VHOST_USER_BACKEND_SHMEM_MAP/UNMAP protocol messages. This feature benefits various VIRTIO devices that require dynamic shared memory management, including virtiofs (for DAX mappings), virtio-gpu (for resource sharing), and the recently standardized virtio-media device. The implementation introduces a robust QOM-based architecture for managing shared memory lifecycle: - VhostUserShmemObject: an intermediate object that manages individual memory mappings - VIRTIO Shared Memory Regions: generic container regions declared in VirtIODevice to support any vhost-user device type - Dynamic Mapping: backends can request mappings via SHMEM_MAP messages, with the frontend creating MemoryRegions from the provided file descriptors and adding them as subregions When a SHMEM_MAP request is received, the frontend: 1. Creates VhostUserShmemObject to manage the mapping lifecycle 2. Maps the provided fd with mmap() 3. Creates a MemoryRegion backed by the mapped memory 4. Adds it as a subregion of the appropiate VIRTIO Shared Memory Region The QOM reference counting ensures automatic cleanup when mappings are removed or the device is destroyed. This patch also includes: - VHOST_USER_GET_SHMEM_CONFIG: a new frontend request allowing generic vhost-user devices to query shared memory configuration from backends at device initialization, enabling the generic vhost-user-device frontend to work with any backend regardless of specific shared memory requirements. The implementation has been tested with rust-vmm based backends and includes SHMEM_CONFIG QTest validation. Albert Esteve (8): vhost-user: Add VirtIO Shared Memory map request vhost_user.rst: Align VhostUserMsg excerpt members vhost_user.rst: Add SHMEM_MAP/_UNMAP to spec vhost_user: Add frontend get_shmem_config command vhost_user.rst: Add GET_SHMEM_CONFIG message tests/qtest: Add GET_SHMEM validation test qmp: add shmem feature map vhost-user-device: Add shared memory BAR docs/interop/vhost-user.rst | 101 +++++++++ hw/virtio/meson.build | 1 + hw/virtio/vhost-user-base.c | 49 ++++- hw/virtio/vhost-user-device-pci.c | 34 ++- hw/virtio/vhost-user-shmem.c | 166 ++++++++++++++ hw/virtio/vhost-user.c | 250 +++++++++++++++++++++- hw/virtio/virtio-qmp.c | 3 + hw/virtio/virtio.c | 111 ++++++++++ include/hw/virtio/vhost-backend.h | 10 + include/hw/virtio/vhost-user-shmem.h | 106 +++++++++ include/hw/virtio/vhost-user.h | 1 + include/hw/virtio/virtio.h | 95 ++++++++ subprojects/libvhost-user/libvhost-user.c | 70 ++++++ subprojects/libvhost-user/libvhost-user.h | 54 +++++ tests/qtest/vhost-user-test.c | 91 ++++++++ 15 files changed, 1135 insertions(+), 7 deletions(-) create mode 100644 hw/virtio/vhost-user-shmem.c create mode 100644 include/hw/virtio/vhost-user-shmem.h -- 2.49.0