qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	devel@lists.libvirt.org, "Stefan Weil" <sw@weilnetz.de>,
	qemu-block@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 12/12] util: add brackets around guest name in message context
Date: Tue, 19 Aug 2025 21:27:08 +0100	[thread overview]
Message-ID: <20250819202708.1185594-13-berrange@redhat.com> (raw)
In-Reply-To: <20250819202708.1185594-1-berrange@redhat.com>

The message context can optionally include the guest name if the
argument '-msg guest-name=on' is given. The formatting, however,
does not look good if the guest name contains whitespace. Change
the output to include square brackets to demarcate the name.

Before:

  # qemu-system-x86_64 -object tls-creds-x509,id=t0,dir=fish -d 'trace:qcrypto*' -msg guest-name=on -name "fish food"
  fish food qemu-system-x86_64(1146846:main): qcrypto_tls_creds_x509_load TLS creds x509 load creds=0x55657e94e690 dir=fish
  fish food qemu-system-x86_64(1146846:main): qcrypto_tls_creds_get_path TLS creds path creds=0x55657e94e690 filename=ca-cert.pem path=<none>
  fish food qemu-system-x86_64(1146846:main): Unable to access credentials fish/ca-cert.pem: No such file or directory

After:

  # qemu-system-x86_64 -object tls-creds-x509,id=t0,dir=fish -d 'trace:qcrypto*' -msg guest-name=on -name "fish food"
  [fish food] qemu-system-x86_64(1144713:main): qcrypto_tls_creds_x509_load TLS creds x509 load creds=0x5604ada2c950 dir=fish
  [fish food] qemu-system-x86_64(1144713:main): qcrypto_tls_creds_get_path TLS creds path creds=0x5604ada2c950 filename=ca-cert.pem path=<none>
  [fish food] qemu-system-x86_64(1144713:main): Unable to access credentials fish/ca-cert.pem: No such file or directory

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 util/message.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/util/message.c b/util/message.c
index 300dc10a4f..9ce2e27f5b 100644
--- a/util/message.c
+++ b/util/message.c
@@ -48,19 +48,21 @@ char *qmessage_context(int flags)
         uint64_t thid = qemu_thread_get_id();
         const char *thname = qemu_thread_get_name();
 
-        return g_strdup_printf("%s%s%s%s%s(%" PRIu64 ":%s): ",
+        return g_strdup_printf("%s%s%s%s%s%s(%" PRIu64 ":%s): ",
                                timestr ? timestr : "",
                                timestr ? " " : "",
+                               wknamestr ? "[" : "",
                                wknamestr ? wknamestr : "",
-                               wknamestr ? " " : "",
+                               wknamestr ? "] " : "",
                                pgnamestr ? pgnamestr : "",
                                thid, thname);
     } else {
-        return g_strdup_printf("%s%s%s%s%s%s",
+        return g_strdup_printf("%s%s%s%s%s%s%s",
                                timestr ? timestr : "",
                                timestr ? " " : "",
+                               wknamestr ? "[" : "",
                                wknamestr ? wknamestr : "",
-                               wknamestr ? " " : "",
+                               wknamestr ? "] " : "",
                                pgnamestr ? pgnamestr : "",
                                pgnamestr ? ": " : "");
     }
-- 
2.50.1



      parent reply	other threads:[~2025-08-19 20:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 20:26 [PATCH 00/12] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 01/12] include: define constant for early constructor priority Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 02/12] monitor: initialize global data from a constructor Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 03/12] system: unconditionally enable thread naming Daniel P. Berrangé
2025-08-19 22:00   ` Dr. David Alan Gilbert
2025-08-19 20:27 ` [PATCH 04/12] util: set the name for the 'main' thread Daniel P. Berrangé
2025-08-19 23:18   ` Dr. David Alan Gilbert
2025-08-20 10:29     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 05/12] util: add API to fetch the current thread id Daniel P. Berrangé
2025-08-19 21:38   ` Richard Henderson
2025-08-19 23:35   ` Dr. David Alan Gilbert
2025-08-20 10:47     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 06/12] util: add API to fetch the current thread name Daniel P. Berrangé
2025-08-19 21:50   ` Richard Henderson
2025-08-20 10:50     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 07/12] util: introduce common helper for error-report & log code Daniel P. Berrangé
2025-08-19 21:57   ` Richard Henderson
2025-08-20 11:00     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 08/12] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2025-08-19 22:02   ` Richard Henderson
2025-08-20 11:12     ` Daniel P. Berrangé
2025-08-29 18:07     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 09/12] util: add support for formatting a workload name in messages Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 10/12] util: add support for formatting a program " Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 11/12] util: add support for formatting thread info " Daniel P. Berrangé
2025-08-19 20:27 ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819202708.1185594-13-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=devel@lists.libvirt.org \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).