qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	devel@lists.libvirt.org, "Stefan Weil" <sw@weilnetz.de>,
	qemu-block@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 06/12] util: add API to fetch the current thread name
Date: Tue, 19 Aug 2025 21:27:02 +0100	[thread overview]
Message-ID: <20250819202708.1185594-7-berrange@redhat.com> (raw)
In-Reply-To: <20250819202708.1185594-1-berrange@redhat.com>

This will be used to include the thread name in error reports
in a later patch. It returns a const string stored in a thread
local to avoid memory allocation on POSIX platforms, at the
cost of having to store an allocated string pointer on Windows.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 include/qemu/thread.h    |  1 +
 meson.build              | 21 +++++++++++++++++
 util/qemu-thread-posix.c | 25 +++++++++++++++++++-
 util/qemu-thread-win32.c | 50 ++++++++++++++++++++++++++++++++++++----
 4 files changed, 92 insertions(+), 5 deletions(-)

diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index 96eee82679..0366cb743d 100644
--- a/include/qemu/thread.h
+++ b/include/qemu/thread.h
@@ -216,6 +216,7 @@ void qemu_thread_get_self(QemuThread *thread);
 bool qemu_thread_is_self(QemuThread *thread);
 G_NORETURN void qemu_thread_exit(void *retval);
 uint64_t qemu_thread_get_id(void);
+const char *qemu_thread_get_name(void);
 
 struct Notifier;
 /**
diff --git a/meson.build b/meson.build
index 50c774a195..ebdcb5d65d 100644
--- a/meson.build
+++ b/meson.build
@@ -2920,6 +2920,27 @@ config_host_data.set('CONFIG_PTHREAD_SET_NAME_NP', cc.links(osdep_prefix + '''
     pthread_set_name_np(thread, "QEMU");
     return 0;
   }''', dependencies: threads))
+
+config_host_data.set('CONFIG_PTHREAD_GETNAME_NP', cc.links(osdep_prefix + '''
+  #include <pthread.h>
+
+  int main(void)
+  {
+    char buf[16];
+    pthread_getname_np(pthread_self(), buf, sizeof(buf));
+    return 0;
+  }''', dependencies: threads))
+config_host_data.set('CONFIG_PTHREAD_GET_NAME_NP', cc.links(osdep_prefix + '''
+  #include <pthread.h>
+  #include <pthread_np.h>
+
+  int main(void)
+  {
+    char buf[16];
+    pthread_get_name_np(pthread_self(), buf, sizeof(buf));
+    return 0;
+  }''', dependencies: threads))
+
 config_host_data.set('CONFIG_PTHREAD_CONDATTR_SETCLOCK', cc.links(osdep_prefix + '''
   #include <pthread.h>
 
diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index f240a93632..282802bc39 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -18,7 +18,7 @@
 #include "qemu/tsan.h"
 #include "qemu/bitmap.h"
 
-#ifdef CONFIG_PTHREAD_SET_NAME_NP
+#if defined(CONFIG_PTHREAD_SET_NAME_NP) || defined(CONFIG_PTHREAD_GET_NAME_NP)
 #include <pthread_np.h>
 #endif
 
@@ -543,3 +543,26 @@ uint64_t qemu_thread_get_id(void)
     return (uint64_t)pthread_self();
 #endif
 }
+
+#ifndef PTHREAD_MAX_NAMELEN_NP
+#define PTHREAD_MAX_NAMELEN_NP 16
+#endif
+
+static __thread char namebuf[PTHREAD_MAX_NAMELEN_NP];
+
+const char *qemu_thread_get_name(void)
+{
+    int rv;
+# if defined(CONFIG_PTHREAD_GETNAME_NP)
+    rv = pthread_getname_np(pthread_self(), namebuf, sizeof(namebuf));
+# elif defined(CONFIG_PTHREAD_GET_NAME_NP)
+    rv = pthread_get_name_np(pthread_self(), namebuf, sizeof(namebuf));
+# else
+    rv = -1;
+# endif
+    if (rv != 0) {
+        strncpy(namebuf, "unnamed", sizeof(namebuf) - 1);
+        namebuf[sizeof(namebuf) - 1] = '\0';
+    }
+    return namebuf;
+}
diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
index f6956717b2..c31a8a6bc8 100644
--- a/util/qemu-thread-win32.c
+++ b/util/qemu-thread-win32.c
@@ -19,10 +19,13 @@
 
 typedef HRESULT (WINAPI *pSetThreadDescription) (HANDLE hThread,
                                                  PCWSTR lpThreadDescription);
+typedef HRESULT (WINAPI *pGetThreadDescription) (HANDLE hThread,
+                                                 PWSTR *lpThreadDescription);
 static pSetThreadDescription SetThreadDescriptionFunc;
+static pGetThreadDescription GetThreadDescriptionFunc;
 static HMODULE kernel32_module;
 
-static bool load_set_thread_description(void)
+static bool load_thread_description(void)
 {
     static gsize _init_once = 0;
 
@@ -32,14 +35,17 @@ static bool load_set_thread_description(void)
             SetThreadDescriptionFunc =
                 (pSetThreadDescription)GetProcAddress(kernel32_module,
                                                       "SetThreadDescription");
-            if (!SetThreadDescriptionFunc) {
+            GetThreadDescriptionFunc =
+                (pGetThreadDescription)GetProcAddress(kernel32_module,
+                                                      "GetThreadDescription");
+            if (!SetThreadDescriptionFunc || !GetThreadDescriptionFunc) {
                 FreeLibrary(kernel32_module);
             }
         }
         g_once_init_leave(&_init_once, 1);
     }
 
-    return !!SetThreadDescriptionFunc;
+    return !!(SetThreadDescriptionFunc && GetThreadDescriptionFunc);
 }
 
 static void error_exit(int err, const char *msg)
@@ -320,7 +326,7 @@ static void set_thread_description(HANDLE h, const char *name)
 {
     g_autofree wchar_t *namew = NULL;
 
-    if (!load_set_thread_description()) {
+    if (!load_thread_description()) {
         return;
     }
 
@@ -417,3 +423,39 @@ uint64_t qemu_thread_get_id(void)
 {
     return (uint64_t)GetCurrentThreadId();
 }
+
+static __thread char *namebuf;
+
+const char *qemu_thread_get_name(void)
+{
+    HRESULT hr;
+    wchar_t *namew = NULL;
+    g_autofree char *name = NULL;
+
+    if (!load_thread_description()) {
+        goto error;
+    }
+
+    hr = GetThreadDescriptionFunc(GetCurrentThread(), &namew);
+    if (!SUCCEEDED(hr)) {
+        goto error;
+    }
+
+    g_free(namebuf);
+    namebuf = g_utf16_to_utf8(namew, -1, NULL, NULL, NULL);
+    if (!namebuf) {
+        goto error;
+    }
+
+ cleanup:
+    if (namew) {
+        LocalFree(namew);
+    }
+    return namebuf;
+
+ error:
+    if (!namebuf) {
+        namebuf = g_strdup("unnamed");
+    }
+    goto cleanup;
+}
-- 
2.50.1



  parent reply	other threads:[~2025-08-19 20:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 20:26 [PATCH 00/12] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 01/12] include: define constant for early constructor priority Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 02/12] monitor: initialize global data from a constructor Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 03/12] system: unconditionally enable thread naming Daniel P. Berrangé
2025-08-19 22:00   ` Dr. David Alan Gilbert
2025-08-19 20:27 ` [PATCH 04/12] util: set the name for the 'main' thread Daniel P. Berrangé
2025-08-19 23:18   ` Dr. David Alan Gilbert
2025-08-20 10:29     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 05/12] util: add API to fetch the current thread id Daniel P. Berrangé
2025-08-19 21:38   ` Richard Henderson
2025-08-19 23:35   ` Dr. David Alan Gilbert
2025-08-20 10:47     ` Daniel P. Berrangé
2025-08-19 20:27 ` Daniel P. Berrangé [this message]
2025-08-19 21:50   ` [PATCH 06/12] util: add API to fetch the current thread name Richard Henderson
2025-08-20 10:50     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 07/12] util: introduce common helper for error-report & log code Daniel P. Berrangé
2025-08-19 21:57   ` Richard Henderson
2025-08-20 11:00     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 08/12] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2025-08-19 22:02   ` Richard Henderson
2025-08-20 11:12     ` Daniel P. Berrangé
2025-08-29 18:07     ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 09/12] util: add support for formatting a workload name in messages Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 10/12] util: add support for formatting a program " Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 11/12] util: add support for formatting thread info " Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 12/12] util: add brackets around guest name in message context Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819202708.1185594-7-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=devel@lists.libvirt.org \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).