* [PATCH] i6300esb: fix incorrect mask for interrupt type
@ 2025-08-20 16:41 ShengYi Hung
0 siblings, 0 replies; 2+ messages in thread
From: ShengYi Hung @ 2025-08-20 16:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Michael S. Tsirkin, ShengYi Hung
According to Intel 6300ESB Controller Hub Datasheet 14.4.15, the interrupt type
mask should be 0x03 (0b11) instead of 0x11. In the original
implementation, when we want to disable all interrupt by setting the
value to 0x03, we will get 0x01 which will be incorrect when we reading
the value again. However, there is no problem since 0x1 is reserved and
unused.
Signed-off-by: ShengYi Hung <aokblast@FreeBSD.org>
Sponsored by: The FreeBSD Foundation
---
hw/watchdog/wdt_i6300esb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
index bb8a2766b6..3aa01b8d68 100644
--- a/hw/watchdog/wdt_i6300esb.c
+++ b/hw/watchdog/wdt_i6300esb.c
@@ -55,7 +55,7 @@
/* Config register bits */
#define ESB_WDT_REBOOT (0x01 << 5) /* Enable reboot on timeout */
#define ESB_WDT_FREQ (0x01 << 2) /* Decrement frequency */
-#define ESB_WDT_INTTYPE (0x11 << 0) /* Interrupt type on timer1 timeout */
+#define ESB_WDT_INTTYPE (0x03 << 0) /* Interrupt type on timer1 timeout */
/* Reload register bits */
#define ESB_WDT_RELOAD (0x01 << 8) /* prevent timeout */
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] i6300esb: fix incorrect mask for interrupt type
@ 2025-08-20 18:37 ShengYi Hung
0 siblings, 0 replies; 2+ messages in thread
From: ShengYi Hung @ 2025-08-20 18:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Michael S. Tsirkin, ShengYi Hung
According to Intel 6300ESB Controller Hub Datasheet 14.4.15, the interrupt type
mask should be 0x03 (0b11) instead of 0x11. In the original
implementation, when we want to disable all interrupt by setting the
value to 0x03, we will get 0x01 which will be incorrect when we reading
the value again. However, there is no problem since 0x1 is reserved and
unused.
Signed-off-by: ShengYi Hung <aokblast@FreeBSD.org>
Sponsored by: The FreeBSD Foundation
---
hw/watchdog/wdt_i6300esb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
index bb8a2766b6..3aa01b8d68 100644
--- a/hw/watchdog/wdt_i6300esb.c
+++ b/hw/watchdog/wdt_i6300esb.c
@@ -55,7 +55,7 @@
/* Config register bits */
#define ESB_WDT_REBOOT (0x01 << 5) /* Enable reboot on timeout */
#define ESB_WDT_FREQ (0x01 << 2) /* Decrement frequency */
-#define ESB_WDT_INTTYPE (0x11 << 0) /* Interrupt type on timer1 timeout */
+#define ESB_WDT_INTTYPE (0x03 << 0) /* Interrupt type on timer1 timeout */
/* Reload register bits */
#define ESB_WDT_RELOAD (0x01 << 8) /* prevent timeout */
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-20 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 16:41 [PATCH] i6300esb: fix incorrect mask for interrupt type ShengYi Hung
-- strict thread matches above, loose matches on Subject: below --
2025-08-20 18:37 ShengYi Hung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).