qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Subject: [PULL 13/14] rust: declare self as qemu_api for proc-macros
Date: Wed, 27 Aug 2025 20:25:31 +0200	[thread overview]
Message-ID: <20250827182533.854476-14-pbonzini@redhat.com> (raw)
In-Reply-To: <20250827182533.854476-1-pbonzini@redhat.com>

From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

Fix an outstanding TODO.

Declaring `extern crate self as qemu_api` allows use of `qemu_api`
within the qemu_api crate; this allows the Wrapper derive macro and
future proc macros to be used interchangeably in the qemu_api crate and
other crates. This is not required currently and is only for
future-proofing.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Link: https://lore.kernel.org/r/20250728-self-as-qemu_api-v1-1-001c339cccc8@linaro.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 rust/qemu-api-macros/src/lib.rs | 14 ++++++--------
 rust/qemu-api/src/lib.rs        |  4 ++++
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/rust/qemu-api-macros/src/lib.rs b/rust/qemu-api-macros/src/lib.rs
index a6147418891..959726efe6d 100644
--- a/rust/qemu-api-macros/src/lib.rs
+++ b/rust/qemu-api-macros/src/lib.rs
@@ -123,23 +123,21 @@ fn derive_opaque_or_error(input: DeriveInput) -> Result<proc_macro2::TokenStream
     let field = &get_unnamed_field(&input, "#[derive(Wrapper)]")?;
     let typ = &field.ty;
 
-    // TODO: how to add "::qemu_api"?  For now, this is only used in the
-    // qemu_api crate so it's not a problem.
     Ok(quote! {
-        unsafe impl crate::cell::Wrapper for #name {
-            type Wrapped = <#typ as crate::cell::Wrapper>::Wrapped;
+        unsafe impl ::qemu_api::cell::Wrapper for #name {
+            type Wrapped = <#typ as ::qemu_api::cell::Wrapper>::Wrapped;
         }
         impl #name {
-            pub unsafe fn from_raw<'a>(ptr: *mut <Self as crate::cell::Wrapper>::Wrapped) -> &'a Self {
+            pub unsafe fn from_raw<'a>(ptr: *mut <Self as ::qemu_api::cell::Wrapper>::Wrapped) -> &'a Self {
                 let ptr = ::std::ptr::NonNull::new(ptr).unwrap().cast::<Self>();
                 unsafe { ptr.as_ref() }
             }
 
-            pub const fn as_mut_ptr(&self) -> *mut <Self as crate::cell::Wrapper>::Wrapped {
+            pub const fn as_mut_ptr(&self) -> *mut <Self as ::qemu_api::cell::Wrapper>::Wrapped {
                 self.0.as_mut_ptr()
             }
 
-            pub const fn as_ptr(&self) -> *const <Self as crate::cell::Wrapper>::Wrapped {
+            pub const fn as_ptr(&self) -> *const <Self as ::qemu_api::cell::Wrapper>::Wrapped {
                 self.0.as_ptr()
             }
 
@@ -147,7 +145,7 @@ pub const fn as_void_ptr(&self) -> *mut ::core::ffi::c_void {
                 self.0.as_void_ptr()
             }
 
-            pub const fn raw_get(slot: *mut Self) -> *mut <Self as crate::cell::Wrapper>::Wrapped {
+            pub const fn raw_get(slot: *mut Self) -> *mut <Self as ::qemu_api::cell::Wrapper>::Wrapped {
                 slot.cast()
             }
         }
diff --git a/rust/qemu-api/src/lib.rs b/rust/qemu-api/src/lib.rs
index 86dcd8ef17a..bcb51c7986a 100644
--- a/rust/qemu-api/src/lib.rs
+++ b/rust/qemu-api/src/lib.rs
@@ -32,6 +32,10 @@
 pub mod vmstate;
 pub mod zeroable;
 
+// Allow proc-macros to refer to `::qemu_api` inside the `qemu_api` crate (this
+// crate).
+extern crate self as qemu_api;
+
 use std::{
     alloc::{GlobalAlloc, Layout},
     ffi::c_void,
-- 
2.51.0



  parent reply	other threads:[~2025-08-27 18:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 18:25 [PULL 00/14] QEMU patches for 2025-08-27 Paolo Bonzini
2025-08-27 18:25 ` [PULL 01/14] target/i386: Add support for save/load of exception error code Paolo Bonzini
2025-08-27 18:25 ` [PULL 02/14] scripts/minikconf.py: fix invalid attribute access Paolo Bonzini
2025-08-27 18:25 ` [PULL 03/14] scripts/minikconf.py: s/Error/KconfigParserError Paolo Bonzini
2025-08-27 18:25 ` [PULL 04/14] python: mkvenv: fix messages printed by mkvenv Paolo Bonzini
2025-08-27 18:25 ` [PULL 05/14] MAINTAINERS: add a few more files to "Top Level Makefile and configure" Paolo Bonzini
2025-08-27 18:25 ` [PULL 06/14] x86/loader: Don't update kernel header for CoCo VMs Paolo Bonzini
2025-08-27 18:25 ` [PULL 07/14] i386/tcg/svm: fix incorrect canonicalization Paolo Bonzini
2025-08-27 18:25 ` [PULL 08/14] kvm/kvm-all: make kvm_park/unpark_vcpu local to kvm-all.c Paolo Bonzini
2025-08-27 18:25 ` [PULL 09/14] rust: disable borrow_as_ptr warning Paolo Bonzini
2025-08-27 18:25 ` [PULL 10/14] rust: qemu-api-macros: support matching more than one error Paolo Bonzini
2025-08-27 18:25 ` [PULL 11/14] subprojects: update proc-macro2 and syn Paolo Bonzini
2025-08-27 18:25 ` [PULL 12/14] rust/qemu-api-macros: make derive(Object) friendly when missing parent Paolo Bonzini
2025-08-27 18:25 ` Paolo Bonzini [this message]
2025-08-27 18:25 ` [PULL 14/14] rust: move dependencies to rust/Cargo.toml Paolo Bonzini
2025-08-27 22:50 ` [PULL 00/14] QEMU patches for 2025-08-27 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250827182533.854476-14-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).