From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL 44/46] linux-user: Remove do_init_main_thread
Date: Thu, 28 Aug 2025 09:20:21 +1000 [thread overview]
Message-ID: <20250827232023.50398-45-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250827232023.50398-1-richard.henderson@linaro.org>
All targets have been converted, so we can call init_main_thread
directly. Remove do_init_main_thread and HAVE_INIT_MAIN_THREAD.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/loader.h | 1 -
linux-user/qemu.h | 2 --
linux-user/elfload.c | 46 --------------------------------------------
linux-user/main.c | 2 +-
4 files changed, 1 insertion(+), 50 deletions(-)
diff --git a/linux-user/loader.h b/linux-user/loader.h
index e0291cc3b0..6482c7c90c 100644
--- a/linux-user/loader.h
+++ b/linux-user/loader.h
@@ -82,7 +82,6 @@ struct linux_binprm {
int (*core_dump)(int, const CPUArchState *); /* coredump routine */
};
-void do_init_main_thread(CPUState *cs, struct image_info *infop);
abi_ulong loader_build_argptr(int envc, int argc, abi_ulong sp,
abi_ulong stringp, int push_ptr);
int loader_exec(int fdexec, const char *filename, char **argv, char **envp,
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 8a9500d4f4..e4dca0c20f 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -359,8 +359,6 @@ void *lock_user_string(abi_ulong guest_addr);
/* Clone cpu state */
CPUArchState *cpu_copy(CPUArchState *env);
-typedef struct target_pt_regs target_pt_regs;
-void target_cpu_copy_regs(CPUArchState *env, target_pt_regs *regs);
void init_main_thread(CPUState *cs, struct image_info *info);
#endif /* QEMU_H */
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 4417c2d99a..fce4c05674 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -149,8 +149,6 @@ typedef abi_int target_pid_t;
#ifdef TARGET_I386
-#define HAVE_INIT_MAIN_THREAD
-
#ifdef TARGET_X86_64
#define ELF_CLASS ELFCLASS64
#define ELF_ARCH EM_X86_64
@@ -293,8 +291,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUX86State *en
#define ELF_CLASS ELFCLASS32
#define EXSTACK_DEFAULT true
-#define HAVE_INIT_MAIN_THREAD
-
#define ELF_NREG 18
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -395,8 +391,6 @@ static const VdsoImageInfo *vdso_image_info(uint32_t elf_flags)
#define ELF_ARCH EM_AARCH64
#define ELF_CLASS ELFCLASS64
-#define HAVE_INIT_MAIN_THREAD
-
#define ELF_NREG 34
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -438,8 +432,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs,
# define ELF_ARCH EM_SPARCV9
#endif
-#define HAVE_INIT_MAIN_THREAD
-
#endif /* TARGET_SPARC */
#ifdef TARGET_PPC
@@ -485,8 +477,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs,
NEW_AUX_ENT(AT_UCACHEBSIZE, 0); \
} while (0)
-#define HAVE_INIT_MAIN_THREAD
-
/* See linux kernel: arch/powerpc/include/asm/elf.h. */
#define ELF_NREG 48
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -533,8 +523,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUPPCState *en
#define VDSO_HEADER "vdso.c.inc"
-#define HAVE_INIT_MAIN_THREAD
-
/* See linux kernel: arch/loongarch/include/asm/elf.h */
#define ELF_NREG 45
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -581,8 +569,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs,
#define elf_check_abi(x) (!((x) & EF_MIPS_ABI2))
#endif
-#define HAVE_INIT_MAIN_THREAD
-
/* See linux kernel: arch/mips/include/asm/elf.h. */
#define ELF_NREG 45
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -640,8 +626,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUMIPSState *e
#define ELF_CLASS ELFCLASS32
#define ELF_ARCH EM_MICROBLAZE
-#define HAVE_INIT_MAIN_THREAD
-
#define ELF_EXEC_PAGESIZE 4096
#define USE_ELF_CORE_DUMP
@@ -673,8 +657,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUMBState *env
#define ELF_CLASS ELFCLASS32
#define ELF_DATA ELFDATA2MSB
-#define HAVE_INIT_MAIN_THREAD
-
#define USE_ELF_CORE_DUMP
#define ELF_EXEC_PAGESIZE 8192
@@ -701,8 +683,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs,
#define ELF_CLASS ELFCLASS32
#define ELF_ARCH EM_SH
-#define HAVE_INIT_MAIN_THREAD
-
/* See linux kernel: arch/sh/include/asm/elf.h. */
#define ELF_NREG 23
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -746,8 +726,6 @@ static inline void elf_core_copy_regs(target_elf_gregset_t *regs,
#define ELF_CLASS ELFCLASS32
#define ELF_ARCH EM_68K
-#define HAVE_INIT_MAIN_THREAD
-
/* See linux kernel: arch/m68k/include/asm/elf.h. */
#define ELF_NREG 20
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -786,8 +764,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUM68KState *e
#define ELF_CLASS ELFCLASS64
#define ELF_ARCH EM_ALPHA
-#define HAVE_INIT_MAIN_THREAD
-
#define ELF_EXEC_PAGESIZE 8192
#endif /* TARGET_ALPHA */
@@ -798,8 +774,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUM68KState *e
#define ELF_DATA ELFDATA2MSB
#define ELF_ARCH EM_S390
-#define HAVE_INIT_MAIN_THREAD
-
/* See linux kernel: arch/s390/include/uapi/asm/ptrace.h (s390_regs). */
#define ELF_NREG 27
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -849,8 +823,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs,
#define VDSO_HEADER "vdso-64.c.inc"
#endif
-#define HAVE_INIT_MAIN_THREAD
-
#define ELF_EXEC_PAGESIZE 4096
#endif /* TARGET_RISCV */
@@ -864,8 +836,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs,
#define VDSO_HEADER "vdso.c.inc"
-#define HAVE_INIT_MAIN_THREAD
-
#define LO_COMMPAGE 0
static bool init_guest_commpage(void)
@@ -905,8 +875,6 @@ static bool init_guest_commpage(void)
#define ELF_CLASS ELFCLASS32
#define ELF_ARCH EM_XTENSA
-#define HAVE_INIT_MAIN_THREAD
-
/* See linux kernel: arch/xtensa/include/asm/elf.h. */
#define ELF_NREG 128
typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG];
@@ -954,8 +922,6 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs,
#define ELF_CLASS ELFCLASS32
#define ELF_ARCH EM_HEXAGON
-#define HAVE_INIT_MAIN_THREAD
-
#endif /* TARGET_HEXAGON */
#ifndef ELF_MACHINE
@@ -3438,15 +3404,3 @@ static int elf_core_dump(int signr, const CPUArchState *env)
return ret;
}
#endif /* USE_ELF_CORE_DUMP */
-
-void do_init_main_thread(CPUState *cs, struct image_info *infop)
-{
-#ifdef HAVE_INIT_MAIN_THREAD
- init_main_thread(cs, infop);
-#else
- target_pt_regs regs = { };
-
- init_thread(®s, infop);
- target_cpu_copy_regs(cpu_env(cs), ®s);
-#endif
-}
diff --git a/linux-user/main.c b/linux-user/main.c
index e21842bde9..6edeeecef3 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -1037,7 +1037,7 @@ int main(int argc, char **argv, char **envp)
the real value of GUEST_BASE into account. */
tcg_prologue_init();
- do_init_main_thread(cpu, info);
+ init_main_thread(cpu, info);
if (gdbstub) {
gdbserver_start(gdbstub, &error_fatal);
--
2.43.0
next prev parent reply other threads:[~2025-08-27 23:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 23:19 [PULL 00/46] linux-user patch queue Richard Henderson
2025-08-27 23:19 ` [PULL 01/46] semihosting: Retrieve stack top from image_info Richard Henderson
2025-08-27 23:19 ` [PULL 02/46] semihosting: Initialize heap once per process Richard Henderson
2025-08-27 23:19 ` [PULL 03/46] linux-user: Create target/elfload.c files Richard Henderson
2025-08-27 23:19 ` [PULL 04/46] linux-user: Move ppc uabi/asm/elf.h workaround to osdep.h Richard Henderson
2025-08-27 23:19 ` [PULL 05/46] linux-user: Move get_elf_cpu_model to target/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 06/46] linux-user: Move get_elf_hwcap to {i386, x86_64}/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 07/46] linux-user: Move hwcap functions to {arm, aarch64}/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 08/46] linux-user: Move get_elf_hwcap to sparc/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 09/46] linux-user: Move hwcap functions to ppc/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 10/46] linux-user: Move get_elf_hwcap to loongarch64/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 11/46] linux-user: Move get_elf_hwcap to mips/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 12/46] linux-user: Move get_elf_hwcap to sh4/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 13/46] linux-user: Move hwcap functions to s390x/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 14/46] linux-user: Move get_elf_hwcap to riscv/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 15/46] linux-user: Remove ELF_HWCAP Richard Henderson
2025-08-27 23:19 ` [PULL 16/46] linux-user: Remove ELF_HWCAP2 Richard Henderson
2025-08-27 23:19 ` [PULL 17/46] linux-user: Move get_elf_platform to {i386, x86_64}/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 18/46] linux-user/i386: Return const data from get_elf_platform Richard Henderson
2025-08-27 23:19 ` [PULL 19/46] linux-user: Move get_elf_platform to arm/elfload.c Richard Henderson
2025-08-27 23:19 ` [PULL 20/46] linux-user/loongarch64: Create get_elf_platform Richard Henderson
2025-08-27 23:19 ` [PULL 21/46] linux-user/hppa: " Richard Henderson
2025-08-27 23:19 ` [PULL 22/46] linux-user: Remove ELF_PLATFORM Richard Henderson
2025-08-27 23:20 ` [PULL 23/46] linux-user: Move get_elf_base_platform to mips/elfload.c Richard Henderson
2025-08-27 23:20 ` [PULL 24/46] linux-user: Move target_cpu_copy_regs decl to qemu.h Richard Henderson
2025-08-27 23:20 ` [PULL 25/46] linux-user: Create do_init_main_thread Richard Henderson
2025-08-27 23:20 ` [PULL 26/46] linux-user/i386: Create init_main_thread Richard Henderson
2025-08-27 23:20 ` [PULL 27/46] linux-user/arm: " Richard Henderson
2025-08-27 23:20 ` [PULL 28/46] linux-user/arm: Remove a.out startup remenents Richard Henderson
2025-08-27 23:20 ` [PULL 29/46] linux-user/aarch64: Create init_main_thread Richard Henderson
2025-08-27 23:20 ` [PULL 30/46] linux-user/sparc: " Richard Henderson
2025-08-27 23:20 ` [PULL 31/46] linux-user/ppc: " Richard Henderson
2025-08-27 23:20 ` [PULL 32/46] linux-user/loongarch64: " Richard Henderson
2025-08-27 23:20 ` [PULL 33/46] linux-user/mips: " Richard Henderson
2025-08-27 23:20 ` [PULL 34/46] linux-user/microblaze: " Richard Henderson
2025-08-27 23:20 ` [PULL 35/46] linux-user/openrisc: " Richard Henderson
2025-08-27 23:20 ` [PULL 36/46] linux-user/sh4: " Richard Henderson
2025-08-27 23:20 ` [PULL 37/46] linux-user/m68k: " Richard Henderson
2025-08-27 23:20 ` [PULL 38/46] linux-user/alpha: " Richard Henderson
2025-08-27 23:20 ` [PULL 39/46] linux-user/s390x: " Richard Henderson
2025-08-27 23:20 ` [PULL 40/46] linux-user/riscv: " Richard Henderson
2025-08-27 23:20 ` [PULL 41/46] linux-user/hppa: " Richard Henderson
2025-08-27 23:20 ` [PULL 42/46] linux-user/xtensa: " Richard Henderson
2025-08-27 23:20 ` [PULL 43/46] linux-user/hexagon: " Richard Henderson
2025-08-27 23:20 ` Richard Henderson [this message]
2025-08-27 23:20 ` [PULL 45/46] linux-user: Add strace for rseq Richard Henderson
2025-08-27 23:20 ` [PULL 46/46] linux-user: do not print IP socket options by default Richard Henderson
2025-08-28 2:47 ` [PULL 00/46] linux-user patch queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827232023.50398-45-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).