From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [PATCH v3 15/87] linux-user: Declare elf_core_copy_regs in loader.h
Date: Thu, 28 Aug 2025 22:07:24 +1000	[thread overview]
Message-ID: <20250828120836.195358-16-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250828120836.195358-1-richard.henderson@linaro.org>
Drop the static from all implementations.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/loader.h  |  3 +++
 linux-user/elfload.c | 33 ++++++++++++++-------------------
 2 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/linux-user/loader.h b/linux-user/loader.h
index 6482c7c90c..8f4a7f69ac 100644
--- a/linux-user/loader.h
+++ b/linux-user/loader.h
@@ -106,4 +106,7 @@ const char *elf_hwcap2_str(uint32_t bit);
 const char *get_elf_platform(CPUState *cs);
 const char *get_elf_base_platform(CPUState *cs);
 
+struct target_elf_gregset_t;
+void elf_core_copy_regs(struct target_elf_gregset_t *, const CPUArchState *);
+
 #endif /* LINUX_USER_LOADER_H */
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 74f88dfa68..5ed5b3c544 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -165,7 +165,7 @@ typedef struct target_elf_gregset_t {
  *
  * See linux kernel: arch/x86/include/asm/elf.h
  */
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUX86State *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUX86State *env)
 {
     r->regs[0] = tswapreg(env->regs[15]);
     r->regs[1] = tswapreg(env->regs[14]);
@@ -244,7 +244,7 @@ typedef struct target_elf_gregset_t {
  *
  * See linux kernel: arch/x86/include/asm/elf.h
  */
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUX86State *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUX86State *env)
 {
     r->regs[0] = tswapreg(env->regs[R_EBX]);
     r->regs[1] = tswapreg(env->regs[R_ECX]);
@@ -300,7 +300,7 @@ typedef struct target_elf_gregset_t {
     target_elf_greg_t regs[ELF_NREG];
 } target_elf_gregset_t;
 
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUARMState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUARMState *env)
 {
     for (int i = 0; i < 16; ++i) {
         r->regs[i] = tswapreg(env->regs[i]);
@@ -388,7 +388,7 @@ typedef struct target_elf_gregset_t {
     target_elf_greg_t regs[ELF_NREG];
 } target_elf_gregset_t;
 
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUARMState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUARMState *env)
 {
     for (int i = 0; i < 32; i++) {
         r->regs[i] = tswapreg(env->xregs[i]);
@@ -474,7 +474,7 @@ typedef struct target_elf_gregset_t {
     target_elf_greg_t regs[ELF_NREG];
 } target_elf_gregset_t;
 
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUPPCState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUPPCState *env)
 {
     int i;
     target_ulong ccr = 0;
@@ -528,8 +528,7 @@ enum {
     TARGET_EF_CSR_BADV = TARGET_EF_R0 + 34,
 };
 
-static void elf_core_copy_regs(target_elf_gregset_t *r,
-                               const CPULoongArchState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPULoongArchState *env)
 {
     r->regs[TARGET_EF_R0] = 0;
 
@@ -586,7 +585,7 @@ enum {
 };
 
 /* See linux kernel: arch/mips/kernel/process.c:elf_dump_regs.  */
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUMIPSState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUMIPSState *env)
 {
     int i;
 
@@ -628,7 +627,7 @@ typedef struct target_elf_gregset_t {
 } target_elf_gregset_t;
 
 /* See linux kernel: arch/mips/kernel/process.c:elf_dump_regs.  */
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUMBState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUMBState *env)
 {
     for (int i = 0; i < 32; i++) {
         r->regs[i] = tswapreg(env->regs[i]);
@@ -659,8 +658,7 @@ typedef struct target_elf_gregset_t {
     target_elf_greg_t regs[ELF_NREG];
 } target_elf_gregset_t;
 
-static void elf_core_copy_regs(target_elf_gregset_t *r,
-                               const CPUOpenRISCState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUOpenRISCState *env)
 {
     for (int i = 0; i < 32; i++) {
         r->regs[i] = tswapreg(cpu_get_gpr(env, i));
@@ -693,7 +691,7 @@ enum {
     TARGET_REG_SYSCALL = 22
 };
 
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUSH4State *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUSH4State *env)
 {
     for (int i = 0; i < 16; i++) {
         r->regs[i] = tswapreg(env->gregs[i]);
@@ -724,7 +722,7 @@ typedef struct target_elf_gregset_t {
     target_elf_greg_t regs[ELF_NREG];
 } target_elf_gregset_t;
 
-static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUM68KState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUM68KState *env)
 {
     r->regs[0] = tswapreg(env->dregs[1]);
     r->regs[1] = tswapreg(env->dregs[2]);
@@ -782,8 +780,7 @@ enum {
     TARGET_REG_ORIG_R2 = 26,
 };
 
-static void elf_core_copy_regs(target_elf_gregset_t *r,
-                               const CPUS390XState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUS390XState *env)
 {
     int i;
     uint32_t *aregs;
@@ -890,8 +887,7 @@ enum {
     TARGET_REG_AR0 = 64,
 };
 
-static void elf_core_copy_regs(target_elf_gregset_t *r,
-                               const CPUXtensaState *env)
+void elf_core_copy_regs(target_elf_gregset_t *r, const CPUXtensaState *env)
 {
     unsigned i;
 
@@ -2865,8 +2861,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct image_info *info)
  * Last step is to implement target specific function that copies registers
  * from given cpu into just specified register set.  Prototype is:
  *
- * static void elf_core_copy_regs(taret_elf_gregset_t *regs,
- *                                const CPUArchState *env);
+ * void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUArchState *env);
  *
  * Parameters:
  *     regs - copy register values into here (allocated and zeroed by caller)
-- 
2.43.0
next prev parent reply	other threads:[~2025-08-28 12:17 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 12:07 [PATCH v3 00/87] linux-user: Split up elfload.c Richard Henderson
2025-08-28 12:07 ` [PATCH v3 01/87] linux-user/x86_64: Convert target_elf_gregset_t to a struct Richard Henderson
2025-08-28 14:17   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 02/87] linux-user/i386: " Richard Henderson
2025-08-28 14:17   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 03/87] linux-user/arm: " Richard Henderson
2025-08-28 14:18   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 04/87] linux-user/aarch64: " Richard Henderson
2025-08-28 14:18   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 05/87] linux-user/ppc: " Richard Henderson
2025-08-28 14:18   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 06/87] linux-user/loongarch64: " Richard Henderson
2025-08-28 14:18   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 07/87] linux-user/mips: " Richard Henderson
2025-08-28 14:20   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 08/87] linux-user/microblaze: " Richard Henderson
2025-08-28 14:20   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 09/87] linux-user/openrisc: " Richard Henderson
2025-08-28 14:21   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 10/87] linux-user/sh4: " Richard Henderson
2025-08-28 14:21   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 11/87] linux-user/m68k: " Richard Henderson
2025-08-28 14:21   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 12/87] linux-user/s390x: " Richard Henderson
2025-08-28 14:27   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 13/87] linux-user/xtensa: " Richard Henderson
2025-08-28 14:27   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 14/87] linux-user: Update comment for target_elf_gregset_t Richard Henderson
2025-08-28 14:27   ` Peter Maydell
2025-08-28 12:07 ` Richard Henderson [this message]
2025-08-28 14:28   ` [PATCH v3 15/87] linux-user: Declare elf_core_copy_regs in loader.h Peter Maydell
2025-08-28 12:07 ` [PATCH v3 16/87] linux-user: Rename USE_ELF_CORE_DUMP to HAVE_ELF_CORE_DUMP Richard Henderson
2025-08-28 14:28   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 17/87] linux-user: Move elf_core_copy_regs to {i386, x86_64}/elfload.c Richard Henderson
2025-08-28 14:29   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 18/87] linux-user: Move elf_core_copy_regs to arm/elfload.c Richard Henderson
2025-08-28 14:30   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 19/87] linux-user: Move elf_core_copy_regs to aarch64/elfload.c Richard Henderson
2025-08-28 14:30   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 20/87] linux-user: Move elf_core_copy_regs to ppc/elfload.c Richard Henderson
2025-08-28 14:30   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 21/87] linux-user: Move elf_core_copy_regs to loongarch64/elfload.c Richard Henderson
2025-08-28 14:31   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 22/87] linux-user: Move elf_core_copy_regs to mips/elfload.c Richard Henderson
2025-08-28 14:31   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 23/87] linux-user: Move elf_core_copy_regs to microblaze/elfload.c Richard Henderson
2025-08-28 14:31   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 24/87] linux-user: Move elf_core_copy_regs to openrisc/elfload.c Richard Henderson
2025-08-28 14:32   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 25/87] linux-user: Move elf_core_copy_regs to sh4/elfload.c Richard Henderson
2025-08-28 14:32   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 26/87] linux-user: Move elf_core_copy_regs to m68k/elfload.c Richard Henderson
2025-08-28 14:32   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 27/87] linux-user: Move elf_core_copy_regs to s390x/elfload.c Richard Henderson
2025-08-28 14:33   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 28/87] linux-user: Move elf_core_copy_regs to xtensa/elfload.c Richard Henderson
2025-08-28 14:33   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 29/87] linux-user: Remove target_elf_greg_t, tswapreg from elfload.c Richard Henderson
2025-08-28 14:33   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 30/87] linux-user/i386: Create target_ptrace.h Richard Henderson
2025-08-28 14:42   ` Peter Maydell
2025-08-28 22:14     ` Richard Henderson
2025-08-29  8:31       ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 31/87] linux-user/i386: Expand target_elf_gregset_t Richard Henderson
2025-08-28 14:43   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 32/87] linux-user/x86_64: Create target_ptrace.h Richard Henderson
2025-08-28 14:45   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 33/87] linux-user/x86_64: Expand target_elf_gregset_t Richard Henderson
2025-08-28 14:45   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 34/87] linux-user/x86_64: Fix dump of fs_base, gs_base Richard Henderson
2025-08-28 14:45   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 35/87] linux-user/aarch64: Create target_ptrace.h Richard Henderson
2025-08-28 14:46   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 36/87] linux-user/aarch64: Expand target_elf_gregset_t Richard Henderson
2025-08-28 14:46   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 37/87] linux-user/arm: Create target_ptrace.h Richard Henderson
2025-08-28 14:47   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 38/87] linux-user/arm: Expand target_elf_gregset_t Richard Henderson
2025-08-28 14:47   ` Peter Maydell
2025-08-28 22:28     ` Richard Henderson
2025-08-29  8:35       ` Peter Maydell
2025-08-29 10:03         ` Richard Henderson
2025-08-28 12:07 ` [PATCH v3 39/87] linux-user/loongarch64: Create target_ptrace.h Richard Henderson
2025-08-28 14:49   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 40/87] linux-user/loongarch64: Expand target_elf_gregset_t Richard Henderson
2025-08-28 14:49   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 41/87] linux-user/m68k: " Richard Henderson
2025-08-28 14:53   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 42/87] linux-user/microblaze: Create target_ptrace.h Richard Henderson
2025-08-28 14:53   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 43/87] linux-user/microblaze: Fold target_pt_regs.r* to an array Richard Henderson
2025-08-28 14:54   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 44/87] linux-user/microblaze: Expand target_elf_gregset_t Richard Henderson
2025-08-28 14:56   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 45/87] linux-user/mips: Create target_ptrace.h Richard Henderson
2025-08-28 14:57   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 46/87] linux-user/mips: Use target_ulong for target_elf_greg_t Richard Henderson
2025-08-28 15:04   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 47/87] linux-user/openrisc: Create target_ptrace.h Richard Henderson
2025-08-28 15:04   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 48/87] linux-user/openrisc: Expand target_elf_gregset_t Richard Henderson
2025-08-28 15:04   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 49/87] linux-user/ppc: Create target_ptrace.h Richard Henderson
2025-08-28 15:05   ` Peter Maydell
2025-08-28 12:07 ` [PATCH v3 50/87] linux-user/ppc: Expand target_elf_gregset_t Richard Henderson
2025-08-28 15:06   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 51/87] linux-user/s390x: Create target_ptrace.h Richard Henderson
2025-08-28 15:10   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 52/87] linux-user/s390x: Expand target_elf_gregset_t Richard Henderson
2025-08-28 15:16   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 53/87] linux-user/sh4: Create target_ptrace.h Richard Henderson
2025-08-28 15:16   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 54/87] linux-user/sh4: Expand target_elf_gregset_t Richard Henderson
2025-08-28 15:17   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 55/87] linux-user/xtensa: Create target_ptrace.h Richard Henderson
2025-08-28 15:18   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 56/87] linux-user/xtensa: Expand target_elf_gregset_t Richard Henderson
2025-08-28 15:18   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 57/87] linux-user: Move init_guest_commpage to x86_64/elfload.c Richard Henderson
2025-08-28 12:08 ` [PATCH v3 58/87] linux-user: Move init_guest_commpage to arm/elfload.c Richard Henderson
2025-08-28 12:08 ` [PATCH v3 59/87] linux-user: Move init_guest_commpage to hppa/elfload.c Richard Henderson
2025-08-28 12:08 ` [PATCH v3 60/87] linux-user: Replace init_guest_commpage macro with function Richard Henderson
2025-08-28 12:08 ` [PATCH v3 61/87] linux-user: Move get_vdso_image_info to arm/elfload.c Richard Henderson
2025-08-28 12:08 ` [PATCH v3 62/87] linux-user: Remove ELF_EXEC_PAGESIZE Richard Henderson
2025-08-28 12:08 ` [PATCH v3 63/87] linux-user: Remove redundant ELF_DATA definitons Richard Henderson
2025-08-28 12:08 ` [PATCH v3 64/87] linux-user: Move elf parameters to {i386, x86_64}/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 65/87] linux-user: Move elf parameters to {arm, aarch64}/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 66/87] linux-user: Move elf parameters to sparc/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 67/87] linux-user: Move elf parameters to ppc/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 68/87] linux-user: Move elf parameters to loongarch64/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 69/87] linux-user: Move elf parameters to {mips, mips64}/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 70/87] linux-user: Move elf parameters to microblaze/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 71/87] linux-user: Move elf parameters to openrisc/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 72/87] linux-user: Move elf parameters to sh4/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 73/87] linux-user: Move elf parameters to m68k/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 74/87] linux-user: Move elf parameters to alpha/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 75/87] linux-user: Move elf parameters to s390x/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 76/87] linux-user: Move elf parameters to riscv/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 77/87] linux-user: Move elf parameters to hppa/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 78/87] linux-user: Move elf parameters to xtensa/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 79/87] linux-user: Move elf parameters to hexagon/target_elf.h Richard Henderson
2025-08-28 12:08 ` [PATCH v3 80/87] linux-user: Standardize on ELF_MACHINE not ELF_ARCH Richard Henderson
2025-08-28 12:08 ` [PATCH v3 81/87] linux-user: Rename elf_check_arch Richard Henderson
2025-08-28 12:08 ` [PATCH v3 82/87] linux-user: Remove ELIBBAD from elfload.c Richard Henderson
2025-08-28 12:08 ` [PATCH v3 83/87] linux-user: Remove MAP_DENYWRITE " Richard Henderson
2025-08-28 12:08 ` [PATCH v3 84/87] linux-user: Move arch_parse_elf_property to aarch64/elfload.c Richard Henderson
2025-08-28 12:08 ` [PATCH v3 85/87] linux-user: Remove a.out declarations from elfload.c Richard Henderson
2025-08-28 12:08 ` [PATCH v3 86/87] linux-user/sparc: Create target_ptrace.h Richard Henderson
2025-08-28 15:19   ` Peter Maydell
2025-08-28 12:08 ` [PATCH v3 87/87] linux-user: Remove target_pt_regs from target_syscall.h Richard Henderson
2025-08-28 15:20   ` Peter Maydell
2025-08-28 15:21 ` [PATCH v3 00/87] linux-user: Split up elfload.c Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20250828120836.195358-16-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).