From: Ben Hillier <bhillier@google.com>
To: wuhaotsh@google.com, kfting@nuvoton.com
Cc: philmd@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Titus Rwantare <titusr@google.com>
Subject: [PATCH v2] hw/sensor: add stub for ADM1266 blackbox
Date: Thu, 28 Aug 2025 18:49:39 +0000 [thread overview]
Message-ID: <20250828184939.3140841-1-bhillier@google.com> (raw)
From: Titus Rwantare <titusr@google.com>
This patch fixes a bug that causes a kernel panic when calling ADM1266_BLACKBOX_INFORMATION.
Log Message:
adm1266 5-0042: Could not read blackbox!
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: adm1266_nvmem_read+0x168/0x170
Signed-off-by: Titus Rwantare <titusr@google.com>
---
hw/sensor/adm1266.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/hw/sensor/adm1266.c b/hw/sensor/adm1266.c
index 9017ce6116..cd11526c2b 100644
--- a/hw/sensor/adm1266.c
+++ b/hw/sensor/adm1266.c
@@ -75,6 +75,7 @@ typedef struct ADM1266State {
static const uint8_t adm1266_ic_device_id[] = {0x03, 0x41, 0x12, 0x66};
static const uint8_t adm1266_ic_device_rev[] = {0x08, 0x01, 0x08, 0x07, 0x0,
0x0, 0x07, 0x41, 0x30};
+static const uint8_t adm1266_blackbox_info[] = {0x04, 0x00, 0x00, 0x00, 0x00};
static void adm1266_exit_reset(Object *obj, ResetType type)
{
@@ -125,6 +126,17 @@ static uint8_t adm1266_read_byte(PMBusDevice *pmdev)
pmbus_send(pmdev, adm1266_ic_device_rev, sizeof(adm1266_ic_device_rev));
break;
+ case ADM1266_BLACKBOX_CONFIG:
+ return 0;
+
+ case ADM1266_READ_BLACKBOX:
+ return 0;
+
+ case ADM1266_BLACKBOX_INFORMATION:
+ pmbus_send(pmdev, adm1266_blackbox_info,
+ sizeof(adm1266_blackbox_info));
+ break;
+
default:
qemu_log_mask(LOG_UNIMP,
"%s: reading from unimplemented register: 0x%02x\n",
@@ -154,6 +166,9 @@ static int adm1266_write_data(PMBusDevice *pmdev, const uint8_t *buf,
pmbus_receive_block(pmdev, (uint8_t *)s->mfr_rev, sizeof(s->mfr_rev));
break;
+ case ADM1266_BLACKBOX_CONFIG:
+ case ADM1266_READ_BLACKBOX:
+ case ADM1266_BLACKBOX_INFORMATION:
case ADM1266_SET_RTC: /* do nothing */
break;
--
2.51.0.rc0.155.g4a0f42376b-goog
next reply other threads:[~2025-08-30 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 18:49 Ben Hillier [this message]
2025-08-29 16:23 ` [PATCH v2] hw/sensor: add stub for ADM1266 blackbox Philippe Mathieu-Daudé
2025-09-08 17:17 ` Titus Rwantare
-- strict thread matches above, loose matches on Subject: below --
2025-08-11 21:36 Ben Hillier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828184939.3140841-1-bhillier@google.com \
--to=bhillier@google.com \
--cc=kfting@nuvoton.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).