* [PATCH] tcg/arm: Fix tgen_deposit
@ 2025-08-29 13:52 Richard Henderson
2025-08-31 5:02 ` Michael Tokarev
2025-09-01 6:32 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2025-08-29 13:52 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-stable, Michael Tokarev
When converting from tcg_out_deposit, the arguments were not
shuffled properly.
Cc: qemu-stable@nongnu.org
Fixes: cf4905c03135f1181e8 ("tcg: Convert deposit to TCGOutOpDeposit")
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/arm/tcg-target.c.inc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index 836894b16a..338c57b061 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -975,7 +975,8 @@ static void tgen_deposit(TCGContext *s, TCGType type, TCGReg a0, TCGReg a1,
TCGReg a2, unsigned ofs, unsigned len)
{
/* bfi/bfc */
- tcg_out32(s, 0x07c00010 | (COND_AL << 28) | (a0 << 12) | a1
+ tcg_debug_assert(a0 == a1);
+ tcg_out32(s, 0x07c00010 | (COND_AL << 28) | (a0 << 12) | a2
| (ofs << 7) | ((ofs + len - 1) << 16));
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg/arm: Fix tgen_deposit
2025-08-29 13:52 [PATCH] tcg/arm: Fix tgen_deposit Richard Henderson
@ 2025-08-31 5:02 ` Michael Tokarev
2025-09-01 6:32 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2025-08-31 5:02 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-stable
On 29.08.2025 16:52, Richard Henderson wrote:
> When converting from tcg_out_deposit, the arguments were not
> shuffled properly.
>
> Cc: qemu-stable@nongnu.org
> Fixes: cf4905c03135f1181e8 ("tcg: Convert deposit to TCGOutOpDeposit")
It fixed the prob indeed, - debian infra has finally catched up and ran
the CI tests on armhf and armel where it all cleared up now.
Tested-by: Michael Tokarev <mjt@tls.msk.ru>
Thanks,
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg/arm: Fix tgen_deposit
2025-08-29 13:52 [PATCH] tcg/arm: Fix tgen_deposit Richard Henderson
2025-08-31 5:02 ` Michael Tokarev
@ 2025-09-01 6:32 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-09-01 6:32 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-stable, Michael Tokarev
On 29/8/25 15:52, Richard Henderson wrote:
> When converting from tcg_out_deposit, the arguments were not
> shuffled properly.
>
> Cc: qemu-stable@nongnu.org
> Fixes: cf4905c03135f1181e8 ("tcg: Convert deposit to TCGOutOpDeposit")
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/arm/tcg-target.c.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-01 6:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-29 13:52 [PATCH] tcg/arm: Fix tgen_deposit Richard Henderson
2025-08-31 5:02 ` Michael Tokarev
2025-09-01 6:32 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).