qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL 66/91] linux-user: Remove ELF_EXEC_PAGESIZE
Date: Sat, 30 Aug 2025 08:24:02 +1000	[thread overview]
Message-ID: <20250829222427.289668-67-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250829222427.289668-1-richard.henderson@linaro.org>

Use TARGET_PAGE_SIZE instead.  If the target page size may vary,
using a different fixed size is wrong.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/elfload.c | 32 ++------------------------------
 1 file changed, 2 insertions(+), 30 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index aed390ebb3..59e6605e36 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -167,8 +167,6 @@ typedef abi_int         target_pid_t;
 
 #define VDSO_HEADER "vdso.c.inc"
 
-#define ELF_EXEC_PAGESIZE       4096
-
 #endif /* TARGET_I386 */
 
 #ifdef TARGET_ARM
@@ -180,16 +178,12 @@ typedef abi_int         target_pid_t;
 #define ELF_CLASS       ELFCLASS32
 #define EXSTACK_DEFAULT true
 
-#define ELF_EXEC_PAGESIZE       4096
-
 #else
 /* 64 bit ARM definitions */
 
 #define ELF_ARCH        EM_AARCH64
 #define ELF_CLASS       ELFCLASS64
 
-#define ELF_EXEC_PAGESIZE       4096
-
 #if TARGET_BIG_ENDIAN
 # define VDSO_HEADER  "vdso-be.c.inc"
 #else
@@ -258,8 +252,6 @@ typedef abi_int         target_pid_t;
         NEW_AUX_ENT(AT_UCACHEBSIZE, 0);                 \
     } while (0)
 
-#define ELF_EXEC_PAGESIZE       4096
-
 #ifndef TARGET_PPC64
 # define VDSO_HEADER  "vdso-32.c.inc"
 #elif TARGET_BIG_ENDIAN
@@ -280,8 +272,6 @@ typedef abi_int         target_pid_t;
 
 #define VDSO_HEADER "vdso.c.inc"
 
-#define ELF_EXEC_PAGESIZE        4096
-
 #endif /* TARGET_LOONGARCH64 */
 
 #ifdef TARGET_MIPS
@@ -300,8 +290,6 @@ typedef abi_int         target_pid_t;
 #define elf_check_abi(x) (!((x) & EF_MIPS_ABI2))
 #endif
 
-#define ELF_EXEC_PAGESIZE        4096
-
 #endif /* TARGET_MIPS */
 
 #ifdef TARGET_MICROBLAZE
@@ -311,8 +299,6 @@ typedef abi_int         target_pid_t;
 #define ELF_CLASS   ELFCLASS32
 #define ELF_ARCH    EM_MICROBLAZE
 
-#define ELF_EXEC_PAGESIZE        4096
-
 #endif /* TARGET_MICROBLAZE */
 
 #ifdef TARGET_OPENRISC
@@ -321,8 +307,6 @@ typedef abi_int         target_pid_t;
 #define ELF_CLASS ELFCLASS32
 #define ELF_DATA  ELFDATA2MSB
 
-#define ELF_EXEC_PAGESIZE 8192
-
 #endif /* TARGET_OPENRISC */
 
 #ifdef TARGET_SH4
@@ -330,8 +314,6 @@ typedef abi_int         target_pid_t;
 #define ELF_CLASS ELFCLASS32
 #define ELF_ARCH  EM_SH
 
-#define ELF_EXEC_PAGESIZE        4096
-
 #endif
 
 #ifdef TARGET_M68K
@@ -339,8 +321,6 @@ typedef abi_int         target_pid_t;
 #define ELF_CLASS       ELFCLASS32
 #define ELF_ARCH        EM_68K
 
-#define ELF_EXEC_PAGESIZE       8192
-
 #endif
 
 #ifdef TARGET_ALPHA
@@ -348,8 +328,6 @@ typedef abi_int         target_pid_t;
 #define ELF_CLASS      ELFCLASS64
 #define ELF_ARCH       EM_ALPHA
 
-#define ELF_EXEC_PAGESIZE        8192
-
 #endif /* TARGET_ALPHA */
 
 #ifdef TARGET_S390X
@@ -358,8 +336,6 @@ typedef abi_int         target_pid_t;
 #define ELF_DATA	ELFDATA2MSB
 #define ELF_ARCH	EM_S390
 
-#define ELF_EXEC_PAGESIZE 4096
-
 #define VDSO_HEADER "vdso.c.inc"
 
 #endif /* TARGET_S390X */
@@ -376,8 +352,6 @@ typedef abi_int         target_pid_t;
 #define VDSO_HEADER "vdso-64.c.inc"
 #endif
 
-#define ELF_EXEC_PAGESIZE 4096
-
 #endif /* TARGET_RISCV */
 
 #ifdef TARGET_HPPA
@@ -396,8 +370,6 @@ typedef abi_int         target_pid_t;
 #define ELF_CLASS       ELFCLASS32
 #define ELF_ARCH        EM_XTENSA
 
-#define ELF_EXEC_PAGESIZE       4096
-
 #endif /* TARGET_XTENSA */
 
 #ifdef TARGET_HEXAGON
@@ -2697,7 +2669,7 @@ static int wmr_fill_region_phdr(void *opaque, vaddr start,
     phdr->p_flags = (flags & PAGE_READ ? PF_R : 0)
                   | (flags & PAGE_WRITE_ORG ? PF_W : 0)
                   | (flags & PAGE_EXEC ? PF_X : 0);
-    phdr->p_align = ELF_EXEC_PAGESIZE;
+    phdr->p_align = TARGET_PAGE_SIZE;
 
     bswap_phdr(phdr, 1);
     d->phdr = phdr + 1;
@@ -2805,7 +2777,7 @@ static int elf_core_dump(int signr, const CPUArchState *env)
     offset += size_note("CORE", sizeof(struct target_elf_prpsinfo));
     offset += size_note("CORE", sizeof(struct target_elf_prstatus)) * cpus;
     note_size = offset - note_offset;
-    data_offset = ROUND_UP(offset, ELF_EXEC_PAGESIZE);
+    data_offset = TARGET_PAGE_ALIGN(offset);
 
     /* Do not dump if the corefile size exceeds the limit. */
     if (dumpsize.rlim_cur != RLIM_INFINITY
-- 
2.43.0



  parent reply	other threads:[~2025-08-30 16:07 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 22:22 [PULL 00/91] linux-user patch queue Richard Henderson
2025-08-29 22:22 ` [PULL 01/91] hw/core: Dump cpu_reset in the reset.exit phase Richard Henderson
2025-08-29 22:22 ` [PULL 02/91] hw/core: Use qemu_log_trylock/unlock in cpu_common_reset_exit Richard Henderson
2025-08-29 22:22 ` [PULL 03/91] linux-user: Tidy print_socket_protocol Richard Henderson
2025-08-29 22:23 ` [PULL 04/91] linux-user: Drop deprecated -p option Richard Henderson
2025-08-29 22:23 ` [PULL 05/91] linux-user/x86_64: Convert target_elf_gregset_t to a struct Richard Henderson
2025-08-29 22:23 ` [PULL 06/91] linux-user/i386: " Richard Henderson
2025-08-29 22:23 ` [PULL 07/91] linux-user/arm: " Richard Henderson
2025-08-29 22:23 ` [PULL 08/91] linux-user/aarch64: " Richard Henderson
2025-08-29 22:23 ` [PULL 09/91] linux-user/ppc: " Richard Henderson
2025-08-29 22:23 ` [PULL 10/91] linux-user/loongarch64: " Richard Henderson
2025-08-29 22:23 ` [PULL 11/91] linux-user/mips: " Richard Henderson
2025-08-29 22:23 ` [PULL 12/91] linux-user/microblaze: " Richard Henderson
2025-08-29 22:23 ` [PULL 13/91] linux-user/openrisc: " Richard Henderson
2025-08-29 22:23 ` [PULL 14/91] linux-user/sh4: " Richard Henderson
2025-08-29 22:23 ` [PULL 15/91] linux-user/m68k: " Richard Henderson
2025-08-29 22:23 ` [PULL 16/91] linux-user/s390x: " Richard Henderson
2025-08-29 22:23 ` [PULL 17/91] linux-user/xtensa: " Richard Henderson
2025-08-29 22:23 ` [PULL 18/91] linux-user: Update comment for target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 19/91] linux-user: Declare elf_core_copy_regs in loader.h Richard Henderson
2025-08-29 22:23 ` [PULL 20/91] linux-user: Rename USE_ELF_CORE_DUMP to HAVE_ELF_CORE_DUMP Richard Henderson
2025-08-29 22:23 ` [PULL 21/91] linux-user: Move elf_core_copy_regs to {i386, x86_64}/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 22/91] linux-user: Move elf_core_copy_regs to arm/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 23/91] linux-user: Move elf_core_copy_regs to aarch64/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 24/91] linux-user: Move elf_core_copy_regs to ppc/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 25/91] linux-user: Move elf_core_copy_regs to loongarch64/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 26/91] linux-user: Move elf_core_copy_regs to mips/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 27/91] linux-user: Move elf_core_copy_regs to microblaze/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 28/91] linux-user: Move elf_core_copy_regs to openrisc/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 29/91] linux-user: Move elf_core_copy_regs to sh4/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 30/91] linux-user: Move elf_core_copy_regs to m68k/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 31/91] linux-user: Move elf_core_copy_regs to s390x/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 32/91] linux-user: Move elf_core_copy_regs to xtensa/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 33/91] linux-user: Remove target_elf_greg_t, tswapreg from elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 34/91] linux-user/i386: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 35/91] linux-user/i386: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 36/91] linux-user/x86_64: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 37/91] linux-user/x86_64: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 38/91] linux-user/x86_64: Fix dump of fs_base, gs_base Richard Henderson
2025-08-29 22:23 ` [PULL 39/91] linux-user/aarch64: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 40/91] linux-user/aarch64: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 41/91] linux-user/arm: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 42/91] linux-user/arm: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 43/91] linux-user/loongarch64: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 44/91] linux-user/loongarch64: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 45/91] linux-user/m68k: " Richard Henderson
2025-08-29 22:23 ` [PULL 46/91] linux-user/microblaze: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 47/91] linux-user/microblaze: Fold target_pt_regs.r* to an array Richard Henderson
2025-08-29 22:23 ` [PULL 48/91] linux-user/microblaze: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 49/91] linux-user/mips: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 50/91] linux-user/mips: Use target_ulong for target_elf_greg_t Richard Henderson
2025-08-29 22:23 ` [PULL 51/91] linux-user/openrisc: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 52/91] linux-user/openrisc: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 53/91] linux-user/ppc: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 54/91] linux-user/ppc: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 55/91] linux-user/s390x: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 56/91] linux-user/s390x: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 57/91] linux-user/sh4: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 58/91] linux-user/sh4: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 59/91] linux-user/xtensa: Create target_ptrace.h Richard Henderson
2025-08-29 22:23 ` [PULL 60/91] linux-user/xtensa: Expand target_elf_gregset_t Richard Henderson
2025-08-29 22:23 ` [PULL 61/91] linux-user: Move init_guest_commpage to x86_64/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 62/91] linux-user: Move init_guest_commpage to arm/elfload.c Richard Henderson
2025-08-29 22:23 ` [PULL 63/91] linux-user: Move init_guest_commpage to hppa/elfload.c Richard Henderson
2025-08-29 22:24 ` [PULL 64/91] linux-user: Replace init_guest_commpage macro with function Richard Henderson
2025-08-29 22:24 ` [PULL 65/91] linux-user: Move get_vdso_image_info to arm/elfload.c Richard Henderson
2025-08-29 22:24 ` Richard Henderson [this message]
2025-08-29 22:24 ` [PULL 67/91] linux-user: Remove redundant ELF_DATA definitons Richard Henderson
2025-08-29 22:24 ` [PULL 68/91] linux-user: Move elf parameters to {i386, x86_64}/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 69/91] linux-user: Move elf parameters to {arm, aarch64}/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 70/91] linux-user: Move elf parameters to sparc/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 71/91] linux-user: Move elf parameters to ppc/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 72/91] linux-user: Move elf parameters to loongarch64/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 73/91] linux-user: Move elf parameters to {mips, mips64}/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 74/91] linux-user: Move elf parameters to microblaze/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 75/91] linux-user: Move elf parameters to openrisc/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 76/91] linux-user: Move elf parameters to sh4/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 77/91] linux-user: Move elf parameters to m68k/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 78/91] linux-user: Move elf parameters to alpha/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 79/91] linux-user: Move elf parameters to s390x/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 80/91] linux-user: Move elf parameters to riscv/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 81/91] linux-user: Move elf parameters to hppa/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 82/91] linux-user: Move elf parameters to xtensa/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 83/91] linux-user: Move elf parameters to hexagon/target_elf.h Richard Henderson
2025-08-29 22:24 ` [PULL 84/91] linux-user: Standardize on ELF_MACHINE not ELF_ARCH Richard Henderson
2025-08-29 22:24 ` [PULL 85/91] linux-user: Rename elf_check_arch Richard Henderson
2025-08-29 22:24 ` [PULL 86/91] linux-user: Remove ELIBBAD from elfload.c Richard Henderson
2025-08-29 22:24 ` [PULL 87/91] linux-user: Remove MAP_DENYWRITE " Richard Henderson
2025-08-29 22:24 ` [PULL 88/91] linux-user: Move arch_parse_elf_property to aarch64/elfload.c Richard Henderson
2025-08-29 22:24 ` [PULL 89/91] linux-user: Remove a.out declarations from elfload.c Richard Henderson
2025-08-29 22:24 ` [PULL 90/91] linux-user/sparc: Create target_ptrace.h Richard Henderson
2025-08-29 22:24 ` [PULL 91/91] linux-user: Remove target_pt_regs from target_syscall.h Richard Henderson
2025-08-30  1:46 ` [PULL 00/91] linux-user patch queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250829222427.289668-67-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).