* [PATCH] docs/about/removed-features: Clarify 'device_add' is removed
@ 2025-09-01 11:39 Philippe Mathieu-Daudé
2025-09-01 11:42 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-09-01 11:39 UTC (permalink / raw)
To: qemu-devel
Cc: Markus Armbruster, Thomas Huth, Stefan Hajnoczi,
Philippe Mathieu-Daudé
All other titles in removed-features.rst mention when
the feature was removed using "removed in". Use that
instead of "since" which we use for when a feature is
deprecated.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
docs/about/removed-features.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
index 25a904032c5..00e248de60b 100644
--- a/docs/about/removed-features.rst
+++ b/docs/about/removed-features.rst
@@ -730,8 +730,8 @@ Use ``multifd-channels`` instead.
Use ``multifd-compression`` instead.
-Incorrectly typed ``device_add`` arguments (since 9.2)
-''''''''''''''''''''''''''''''''''''''''''''''''''''''
+Incorrectly typed ``device_add`` arguments (removed in 9.2)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
Due to shortcomings in the internal implementation of ``device_add``,
QEMU used to incorrectly accept certain invalid arguments. Any object
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] docs/about/removed-features: Clarify 'device_add' is removed
2025-09-01 11:39 [PATCH] docs/about/removed-features: Clarify 'device_add' is removed Philippe Mathieu-Daudé
@ 2025-09-01 11:42 ` Daniel P. Berrangé
2025-09-01 12:13 ` Markus Armbruster
2025-09-01 20:59 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2025-09-01 11:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Markus Armbruster, Thomas Huth, Stefan Hajnoczi
On Mon, Sep 01, 2025 at 01:39:56PM +0200, Philippe Mathieu-Daudé wrote:
> All other titles in removed-features.rst mention when
> the feature was removed using "removed in". Use that
> instead of "since" which we use for when a feature is
> deprecated.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> docs/about/removed-features.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/about/removed-features: Clarify 'device_add' is removed
2025-09-01 11:39 [PATCH] docs/about/removed-features: Clarify 'device_add' is removed Philippe Mathieu-Daudé
2025-09-01 11:42 ` Daniel P. Berrangé
@ 2025-09-01 12:13 ` Markus Armbruster
2025-09-01 20:59 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2025-09-01 12:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-devel, Thomas Huth, Stefan Hajnoczi
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> All other titles in removed-features.rst mention when
> the feature was removed using "removed in". Use that
> instead of "since" which we use for when a feature is
> deprecated.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
My bad.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/about/removed-features: Clarify 'device_add' is removed
2025-09-01 11:39 [PATCH] docs/about/removed-features: Clarify 'device_add' is removed Philippe Mathieu-Daudé
2025-09-01 11:42 ` Daniel P. Berrangé
2025-09-01 12:13 ` Markus Armbruster
@ 2025-09-01 20:59 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-09-01 20:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Markus Armbruster, Thomas Huth, Stefan Hajnoczi
On 1/9/25 13:39, Philippe Mathieu-Daudé wrote:
> All other titles in removed-features.rst mention when
> the feature was removed using "removed in". Use that
> instead of "since" which we use for when a feature is
> deprecated.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> docs/about/removed-features.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch queued, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-01 20:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 11:39 [PATCH] docs/about/removed-features: Clarify 'device_add' is removed Philippe Mathieu-Daudé
2025-09-01 11:42 ` Daniel P. Berrangé
2025-09-01 12:13 ` Markus Armbruster
2025-09-01 20:59 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).