From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alexander Graf" <agraf@csgraf.de>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-arm@nongnu.org,
	"Mohamed Mediouni" <mohamed@unpredictable.fr>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Mads Ynddal" <mads@ynddal.dk>,
	"Phil Dennis-Jordan" <phil@philjordan.eu>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Cameron Esfahani" <dirty@apple.com>,
	"Roman Bolshakov" <rbolshakov@ddn.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 17/24] target/arm/hvf: Factor hvf_handle_vmexit() out
Date: Wed,  3 Sep 2025 12:06:53 +0200	[thread overview]
Message-ID: <20250903100702.16726-18-philmd@linaro.org> (raw)
In-Reply-To: <20250903100702.16726-1-philmd@linaro.org>
Factor hvf_handle_vmexit() out of hvf_vcpu_exec().
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/arm/hvf/hvf.c | 51 ++++++++++++++++++++++++--------------------
 1 file changed, 28 insertions(+), 23 deletions(-)
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index 3db0a8e288c..0cfe3066c23 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -2111,10 +2111,34 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)
     return ret;
 }
 
-int hvf_arch_vcpu_exec(CPUState *cpu)
+/* Must be called by the owning thread */
+static int hvf_handle_vmexit(CPUState *cpu, hv_vcpu_exit_t *exit)
 {
     ARMCPU *arm_cpu = ARM_CPU(cpu);
-    hv_vcpu_exit_t *hvf_exit = cpu->accel->exit;
+    int ret = 0;
+
+    switch (exit->reason) {
+    case HV_EXIT_REASON_EXCEPTION:
+        hvf_sync_vtimer(cpu);
+        ret = hvf_handle_exception(cpu, &exit->exception);
+        break;
+    case HV_EXIT_REASON_VTIMER_ACTIVATED:
+        qemu_set_irq(arm_cpu->gt_timer_outputs[GTIMER_VIRT], 1);
+        cpu->accel->vtimer_masked = true;
+        break;
+    case HV_EXIT_REASON_CANCELED:
+        /* we got kicked, no exit to process */
+        break;
+    default:
+        g_assert_not_reached();
+    }
+
+    return ret;
+}
+
+int hvf_arch_vcpu_exec(CPUState *cpu)
+{
+    int ret;
     hv_return_t r;
 
     if (!(cpu->singlestep_enabled & SSTEP_NOIRQ) &&
@@ -2133,6 +2157,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu)
     bql_lock();
     switch (r) {
     case HV_SUCCESS:
+        ret = hvf_handle_vmexit(cpu, cpu->accel->exit);
         break;
     case HV_ILLEGAL_GUEST_STATE:
         trace_hvf_illegal_guest_state();
@@ -2141,27 +2166,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu)
         g_assert_not_reached();
     }
 
-    /* handle VMEXIT */
-    uint64_t exit_reason = hvf_exit->reason;
-
-    switch (exit_reason) {
-    case HV_EXIT_REASON_EXCEPTION:
-        /* This is the main one, handle below. */
-        break;
-    case HV_EXIT_REASON_VTIMER_ACTIVATED:
-        qemu_set_irq(arm_cpu->gt_timer_outputs[GTIMER_VIRT], 1);
-        cpu->accel->vtimer_masked = true;
-        return 0;
-    case HV_EXIT_REASON_CANCELED:
-        /* we got kicked, no exit to process */
-        return 0;
-    default:
-        g_assert_not_reached();
-    }
-
-    hvf_sync_vtimer(cpu);
-
-    return hvf_handle_exception(cpu, &hvf_exit->exception);
+    return ret;
 }
 
 static const VMStateDescription vmstate_hvf_vtimer = {
-- 
2.51.0
next prev parent reply	other threads:[~2025-09-03 10:11 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 10:06 [PATCH 00/24] target/arm/hvf: Consolidate Philippe Mathieu-Daudé
2025-09-03 10:06 ` [PATCH 01/24] target/arm/hvf: Release memory allocated by hv_vcpu_config_create() Philippe Mathieu-Daudé
2025-09-03 12:22   ` Richard Henderson
2025-09-08 10:17   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 02/24] target/arm/hvf: Check hv_vcpus_exit() returned value Philippe Mathieu-Daudé
2025-09-03 12:23   ` Richard Henderson
2025-09-08 10:17   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 03/24] target/arm/hvf: Check hv_vcpu_set_vtimer_mask() " Philippe Mathieu-Daudé
2025-09-03 12:30   ` Richard Henderson
2025-09-08 10:17   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 04/24] accel/hvf: Rename hvf_vcpu_exec() -> hvf_arch_vcpu_exec() Philippe Mathieu-Daudé
2025-09-03 12:31   ` Richard Henderson
2025-09-08 10:17   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 05/24] accel/hvf: Rename hvf_put|get_registers -> hvf_arch_put|get_registers Philippe Mathieu-Daudé
2025-09-03 12:31   ` Richard Henderson
2025-09-08 10:16   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 06/24] target/arm/hvf: Mention flush_cpu_state() must run on vCPU thread Philippe Mathieu-Daudé
2025-09-03 12:31   ` Richard Henderson
2025-09-08 10:16   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 07/24] accel/hvf: Mention hvf_arch_init_vcpu() " Philippe Mathieu-Daudé
2025-09-03 12:33   ` Richard Henderson
2025-09-08 10:16   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 08/24] target/arm/hvf: Mention hvf_wfi() " Philippe Mathieu-Daudé
2025-09-03 12:34   ` Richard Henderson
2025-09-03 17:05     ` Philippe Mathieu-Daudé
2025-09-08 10:16     ` Mads Ynddal
2025-09-08 10:16   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 09/24] target/arm/hvf: Mention hvf_sync_vtimer() " Philippe Mathieu-Daudé
2025-09-08 10:16   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 10/24] target/arm/hvf: Mention hvf_arch_set_traps() " Philippe Mathieu-Daudé
2025-09-08 10:15   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 11/24] accel/hvf: Mention hvf_arch_update_guest_debug() must run on vCPU Philippe Mathieu-Daudé
2025-09-08 10:15   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 12/24] target/arm/hvf: Mention hvf_inject_interrupts() must run on vCPU thread Philippe Mathieu-Daudé
2025-09-08 11:00   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 13/24] accel/hvf: Implement hvf_arch_vcpu_destroy() Philippe Mathieu-Daudé
2025-09-03 12:35   ` Richard Henderson
2025-09-08 12:00   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 14/24] target/arm/hvf: Hardcode Apple MIDR Philippe Mathieu-Daudé
2025-09-03 12:36   ` Richard Henderson
2025-09-08 12:00   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 15/24] target/arm/hvf: switch hvf_arm_get_host_cpu_features to not create a vCPU Philippe Mathieu-Daudé
2025-09-03 10:13   ` Philippe Mathieu-Daudé
2025-09-03 12:03   ` Richard Henderson
2025-09-03 12:20     ` Philippe Mathieu-Daudé
2025-09-03 10:06 ` [PATCH 16/24] target/arm/hvf: Factor hvf_handle_exception() out Philippe Mathieu-Daudé
2025-09-03 12:46   ` Richard Henderson
2025-09-08 12:00   ` Mads Ynddal
2025-09-03 10:06 ` Philippe Mathieu-Daudé [this message]
2025-09-03 12:47   ` [PATCH 17/24] target/arm/hvf: Factor hvf_handle_vmexit() out Richard Henderson
2025-09-08 12:00   ` Mads Ynddal
2025-09-03 10:06 ` [PATCH 18/24] target/arm/hvf: Keep calling hv_vcpu_run() in loop Philippe Mathieu-Daudé
2025-09-03 12:47   ` Richard Henderson
2025-09-08 12:26   ` Mads Ynddal
2025-10-07  3:43     ` Philippe Mathieu-Daudé
2025-10-07  4:18       ` Philippe Mathieu-Daudé
2025-09-03 10:06 ` [PATCH 19/24] cpus: Trace cpu_exec_start() and cpu_exec_end() calls Philippe Mathieu-Daudé
2025-09-03 12:39   ` Richard Henderson
2025-09-03 10:06 ` [PATCH 20/24] accel/hvf: Guard hv_vcpu_run() between cpu_exec_start/end() calls Philippe Mathieu-Daudé
2025-09-03 14:30   ` Philippe Mathieu-Daudé
2025-09-03 10:06 ` [PATCH 21/24] target/arm: Call aarch64_add_pauth_properties() once in host_initfn() Philippe Mathieu-Daudé
2025-09-03 12:40   ` Richard Henderson
2025-09-03 10:06 ` [PATCH 22/24] accel/hvf: Restrict ARM specific fields of AccelCPUState Philippe Mathieu-Daudé
2025-09-03 12:41   ` Richard Henderson
2025-09-03 10:06 ` [PATCH 23/24] target/arm: Rename init_cpreg_list() -> arm_init_cpreg_list() Philippe Mathieu-Daudé
2025-09-11 14:46   ` Peter Maydell
2025-09-03 10:07 ` [PATCH 24/24] target/arm: Add arm_destroy_cpreg_list() helper Philippe Mathieu-Daudé
2025-09-03 10:12   ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20250903100702.16726-18-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=agraf@csgraf.de \
    --cc=dirty@apple.com \
    --cc=mads@ynddal.dk \
    --cc=mohamed@unpredictable.fr \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=phil@philjordan.eu \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rbolshakov@ddn.com \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).