* [PATCH] 9pfs: Include glib.h
@ 2025-09-04 14:30 Peter Foley
2025-09-05 7:27 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Peter Foley @ 2025-09-04 14:30 UTC (permalink / raw)
To: qemu-devel; +Cc: Christian Schoenebeck, Greg Kurz, nabihestefan, Peter Foley
gstrfuncs.h is not intended to be included directly.
Signed-off-by: Peter Foley <pefoley@google.com>
---
hw/9pfs/9p-util-generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..93c38e40f693a945f979ca89555cd9b1ea3175d6 100644
--- a/hw/9pfs/9p-util-generic.c
+++ b/hw/9pfs/9p-util-generic.c
@@ -2,7 +2,7 @@
#include "qemu/osdep.h"
#include "9p-util.h"
-#include <glib/gstrfuncs.h>
+#include <glib.h>
char *qemu_open_flags_tostr(int flags)
{
---
base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
change-id: 20250904-9p-11c0405ae7c5
Best regards,
--
Peter Foley <pefoley@google.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] 9pfs: Include glib.h
2025-09-04 14:30 [PATCH] 9pfs: Include glib.h Peter Foley
@ 2025-09-05 7:27 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2025-09-05 7:27 UTC (permalink / raw)
To: Peter Foley, qemu-devel; +Cc: Christian Schoenebeck, Greg Kurz, nabihestefan
On 9/4/25 16:30, Peter Foley wrote:
> gstrfuncs.h is not intended to be included directly.
Indeed -- it works only because qemu/osdep.h actually already includes
glib.h. So the line can be removed altogether.
Thanks for looking at these papercuts and bringing attention to the QEMU
upstream developers.
Paolo
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
> hw/9pfs/9p-util-generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
> index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..93c38e40f693a945f979ca89555cd9b1ea3175d6 100644
> --- a/hw/9pfs/9p-util-generic.c
> +++ b/hw/9pfs/9p-util-generic.c
> @@ -2,7 +2,7 @@
>
> #include "qemu/osdep.h"
> #include "9p-util.h"
> -#include <glib/gstrfuncs.h>
> +#include <glib.h>
>
> char *qemu_open_flags_tostr(int flags)
> {
>
> ---
> base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
> change-id: 20250904-9p-11c0405ae7c5
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-05 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-04 14:30 [PATCH] 9pfs: Include glib.h Peter Foley
2025-09-05 7:27 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).