qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	qemu-block@nongnu.org, "Daniel Berrangé" <berrange@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>, "John Snow" <jsnow@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>
Subject: [PATCH v3 16/19] python: ensure QEMUQtestProtocol closes its socket
Date: Mon,  8 Sep 2025 15:03:15 -0400	[thread overview]
Message-ID: <20250908190318.3331728-17-jsnow@redhat.com> (raw)
In-Reply-To: <20250908190318.3331728-1-jsnow@redhat.com>

From: Daniel P. Berrangé <berrange@redhat.com>

While QEMUQtestMachine closes the socket that was passed to
QEMUQtestProtocol, the python resource leak manager still
believes that the copy QEMUQtestProtocol holds is open. We
must explicitly call close to avoid this leak warnnig.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/qemu/machine/qtest.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
index 4f5ede85b23..781f674ffaf 100644
--- a/python/qemu/machine/qtest.py
+++ b/python/qemu/machine/qtest.py
@@ -177,6 +177,8 @@ def _post_shutdown(self) -> None:
             self._qtest_sock_pair[0].close()
             self._qtest_sock_pair[1].close()
             self._qtest_sock_pair = None
+        if self._qtest is not None:
+            self._qtest.close()
         super()._post_shutdown()
 
     def qtest(self, cmd: str) -> str:
-- 
2.50.1



  parent reply	other threads:[~2025-09-08 19:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 19:02 [PATCH v3 00/19] python: 3.14 compatibility and python-qemu-qmp synchronization John Snow
2025-09-08 19:03 ` [PATCH v3 01/19] python: backport 'Change error classes to have better repr methods' John Snow
2025-09-08 19:03 ` [PATCH v3 02/19] python: backport 'EventListener: add __repr__ method' John Snow
2025-09-08 19:03 ` [PATCH v3 03/19] python: backport 'kick event queue on legacy event_pull()' John Snow
2025-09-08 19:03 ` [PATCH v3 04/19] python: backport 'protocol: adjust logging name when changing client name' John Snow
2025-09-08 19:03 ` [PATCH v3 05/19] python: backport 'drop Python3.6 workarounds' John Snow
2025-09-08 19:03 ` [PATCH v3 06/19] python: backport 'Use @asynciocontextmanager' John Snow
2025-09-08 19:03 ` [PATCH v3 07/19] python: backport 'qmp-shell: add common_parser()' John Snow
2025-09-08 19:03 ` [PATCH v3 08/19] python: backport 'feat: allow setting read buffer limit' John Snow
2025-09-08 19:03 ` [PATCH v3 09/19] python: backport 'make require() preserve async-ness' John Snow
2025-09-08 19:03 ` [PATCH v3 10/19] python: backport 'qmp-shell-wrap: handle missing binary gracefully' John Snow
2025-09-08 19:03 ` [PATCH v3 11/19] python: backport 'qmp-tui: Do not crash if optional dependencies are not met' John Snow
2025-09-08 19:03 ` [PATCH v3 12/19] python: backport 'Remove deprecated get_event_loop calls' John Snow
2025-09-08 19:03 ` [PATCH v3 13/19] python: backport 'avoid creating additional event loops per thread' John Snow
2025-09-08 19:03 ` [PATCH v3 14/19] python: synchronize qemu.qmp documentation John Snow
2025-09-08 19:03 ` [PATCH v3 15/19] iotests: drop compat for old version context manager John Snow
2025-09-08 19:03 ` John Snow [this message]
2025-09-08 19:03 ` [PATCH v3 17/19] iotests/147: ensure temporary sockets are closed before exiting John Snow
2025-09-08 19:03 ` [PATCH v3 18/19] iotests/151: ensure subprocesses are cleaned up John Snow
2025-09-08 19:03 ` [PATCH v3 19/19] iotests/check: always enable all python warnings John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250908190318.3331728-17-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).