From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C0EECAC589 for ; Tue, 9 Sep 2025 08:46:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvtyz-0005Uz-N6; Tue, 09 Sep 2025 04:45:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvtyw-0005U2-4q; Tue, 09 Sep 2025 04:45:42 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvtyr-0003fb-Vg; Tue, 09 Sep 2025 04:45:41 -0400 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4cLclH5nnDz6M56j; Tue, 9 Sep 2025 16:42:35 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 65862140279; Tue, 9 Sep 2025 16:45:12 +0800 (CST) Received: from localhost (10.203.177.15) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 9 Sep 2025 10:45:11 +0200 Date: Tue, 9 Sep 2025 09:45:10 +0100 To: Wilfred Mallawa CC: Alistair Francis , Keith Busch , Klaus Jensen , Jesper Devantier , Stefan Hajnoczi , Fam Zheng , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Kevin Wolf , Hanna Reitz , "Michael S . Tsirkin" , "Marcel Apfelbaum" , , , Wilfred Mallawa Subject: Re: [PATCH v5 1/5] spdm-socket: add seperate send/recv functions Message-ID: <20250909094510.00005892@huawei.com> In-Reply-To: <20250909043259.93140-3-wilfred.opensource@gmail.com> References: <20250909043259.93140-2-wilfred.opensource@gmail.com> <20250909043259.93140-3-wilfred.opensource@gmail.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, 9 Sep 2025 14:32:56 +1000 Wilfred Mallawa wrote: > From: Wilfred Mallawa > > This is to support uni-directional transports such as SPDM over Storage. > As specified by the DMTF DSP0286. > > Also update spdm_socket_rsp() to use the new send()/receive() functions. For > the case of spdm_socket_receive(), this allows us to do error checking > in one place with the addition of spdm_socket_command_valid(). > > Signed-off-by: Wilfred Mallawa One trivial comment below. Either way Reviewed-by: Jonathan Cameron > +uint32_t spdm_socket_rsp(const int socket, uint32_t transport_type, > + void *req, uint32_t req_len, > + void *rsp, uint32_t rsp_len) > +{ > + bool result; > + > + result = spdm_socket_send(socket, SPDM_SOCKET_COMMAND_NORMAL, > + transport_type, req, req_len); > if (!result) { > return 0; > } > > - assert(command != 0); > - > + rsp_len = spdm_socket_receive(socket, transport_type, rsp, rsp_len); > return rsp_len; return spdm_socket_receive(socket, transport_type, rsp, rsp_len); Both shorter and avoids rsp_len changing meaning (slightly). > } >