qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PULL 06/23] tests/functional/m68k: Avoid ResourceWarning in the nextcube test
Date: Tue,  9 Sep 2025 15:51:30 +0200	[thread overview]
Message-ID: <20250909135147.612345-7-thuth@redhat.com> (raw)
In-Reply-To: <20250909135147.612345-1-thuth@redhat.com>

From: Thomas Huth <thuth@redhat.com>

Since commit c3fd296cf7b1 ("functional: always enable all python
warnings") we enabled more warnings for the functional tests. This
triggers now a warning in the nextcube test:

 tests/functional/m68k/test_nextcube.py:47: ResourceWarning:
  unclosed file <_io.BufferedReader name='tests/functional/m68k/test_nextcube.NextCubeMachine.test_bootrom_framebuffer_size/scratch/dump.ppm'>
   width, height = Image.open(screenshot_path).size

Use a proper "with" context to avoid it.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20250829142000.62320-1-thuth@redhat.com>
---
 tests/functional/m68k/test_nextcube.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/functional/m68k/test_nextcube.py b/tests/functional/m68k/test_nextcube.py
index 13c72bd136a..c1610e58456 100755
--- a/tests/functional/m68k/test_nextcube.py
+++ b/tests/functional/m68k/test_nextcube.py
@@ -44,7 +44,8 @@ def test_bootrom_framebuffer_size(self):
         self.check_bootrom_framebuffer(screenshot_path)
 
         from PIL import Image
-        width, height = Image.open(screenshot_path).size
+        with Image.open(screenshot_path) as image:
+                width, height = image.size
         self.assertEqual(width, 1120)
         self.assertEqual(height, 832)
 
-- 
2.51.0



  parent reply	other threads:[~2025-09-09 13:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 13:51 [PULL 00/23] Functional tests and misc patches Thomas Huth
2025-09-09 13:51 ` [PULL 01/23] hw/display/bcm2835_fb: Move inclusion of console.h to the .c file Thomas Huth
2025-09-09 13:51 ` [PULL 02/23] Revert "meson.build: Disable -fzero-call-used-regs on OpenBSD" Thomas Huth
2025-09-09 13:51 ` [PULL 03/23] hw/mips/malta: Silence warning from ubsan Thomas Huth
2025-09-09 13:51 ` [PULL 04/23] system/physmem: " Thomas Huth
2025-09-15 16:17   ` Richard Henderson
2025-09-09 13:51 ` [PULL 05/23] ui/vnc: Fix crash when specifying [vnc] without id in the config file Thomas Huth
2025-09-09 13:51 ` Thomas Huth [this message]
2025-09-09 13:51 ` [PULL 07/23] tests/functional: enable force refresh of cached assets Thomas Huth
2025-09-09 13:51 ` [PULL 08/23] tests/functional: fix formatting of exception args Thomas Huth
2025-09-09 13:51 ` [PULL 09/23] tests/functional: handle URLError when fetching assets Thomas Huth
2025-09-09 13:51 ` [PULL 10/23] tests/functional/arm: Update test ASPEED SDK v03.02 for AST1030 Thomas Huth
2025-09-09 13:51 ` [PULL 11/23] tests/functional/arm: Update test ASPEED SDK v09.07 for AST2500 Thomas Huth
2025-09-09 13:51 ` [PULL 12/23] tests/functional/arm: Update test ASPEED SDK v09.07 for AST2600 Thomas Huth
2025-09-09 13:51 ` [PULL 13/23] tests/functional/arm: Update test ASPEED SDK v09.07 for AST2700 vbootrom Thomas Huth
2025-09-09 13:51 ` [PULL 14/23] gitlab: replace avocado results files with meson results files Thomas Huth
2025-09-09 13:51 ` [PULL 15/23] gitlab: always include entire of meson-logs directory Thomas Huth
2025-09-09 13:51 ` [PULL 16/23] gitlab: include all junit XML files from meson Thomas Huth
2025-09-09 13:51 ` [PULL 17/23] gitlab: prevent duplicated meson log artifacts in test jobs Thomas Huth
2025-09-09 13:51 ` [PULL 18/23] tests/functional: return output from cmd.py helpers Thomas Huth
2025-09-09 13:51 ` [PULL 19/23] tests/functional: add vm param to " Thomas Huth
2025-09-09 13:51 ` [PULL 20/23] tests/functional: fix infinite loop on console EOF Thomas Huth
2025-09-09 13:51 ` [PULL 21/23] tests/functional: avoid duplicate messages on failures Thomas Huth
2025-09-09 13:51 ` [PULL 22/23] tests/functional: avoid tearDown failure when QEMU dies Thomas Huth
2025-09-09 13:51 ` [PULL 23/23] tests/functional: purge scratch dir on test startup Thomas Huth
2025-09-11 13:12 ` [PULL 00/23] Functional tests and misc patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250909135147.612345-7-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).