From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [PULL 15/61] treewide: rename qemu_wait_io_event/qemu_wait_io_event_common
Date: Sat, 13 Sep 2025 10:08:56 +0200 [thread overview]
Message-ID: <20250913080943.11710-16-pbonzini@redhat.com> (raw)
In-Reply-To: <20250913080943.11710-1-pbonzini@redhat.com>
Do so before extending it to the user-mode emulators, where there is no
such thing as an "I/O thread".
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/hw/core/cpu.h | 2 +-
include/system/cpus.h | 4 ++--
accel/dummy-cpus.c | 2 +-
accel/hvf/hvf-accel-ops.c | 2 +-
accel/kvm/kvm-accel-ops.c | 2 +-
accel/tcg/tcg-accel-ops-mttcg.c | 2 +-
accel/tcg/tcg-accel-ops-rr.c | 4 ++--
cpu-common.c | 2 +-
system/cpus.c | 6 +++---
target/i386/nvmm/nvmm-accel-ops.c | 2 +-
target/i386/whpx/whpx-accel-ops.c | 2 +-
11 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index 338757e5254..6075be0b59f 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -422,7 +422,7 @@ struct qemu_work_item;
* valid under cpu_list_lock.
* @created: Indicates whether the CPU thread has been successfully created.
* @halt_cond: condition variable sleeping threads can wait on.
- * @exit_request: Another thread requests the CPU to call qemu_wait_io_event().
+ * @exit_request: Another thread requests the CPU to call qemu_process_cpu_events().
* Should be read only by CPU thread with load-acquire, to synchronize with
* other threads' store-release operation.
*
diff --git a/include/system/cpus.h b/include/system/cpus.h
index 69be6a77a75..4aebec48705 100644
--- a/include/system/cpus.h
+++ b/include/system/cpus.h
@@ -17,8 +17,8 @@ bool cpu_work_list_empty(CPUState *cpu);
bool cpu_thread_is_idle(CPUState *cpu);
bool all_cpu_threads_idle(void);
bool cpu_can_run(CPUState *cpu);
-void qemu_wait_io_event_common(CPUState *cpu);
-void qemu_wait_io_event(CPUState *cpu);
+void qemu_process_cpu_events_common(CPUState *cpu);
+void qemu_process_cpu_events(CPUState *cpu);
void cpu_thread_signal_created(CPUState *cpu);
void cpu_thread_signal_destroyed(CPUState *cpu);
void cpu_handle_guest_debug(CPUState *cpu);
diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c
index 03cfc0fa01e..225a47c31fd 100644
--- a/accel/dummy-cpus.c
+++ b/accel/dummy-cpus.c
@@ -57,7 +57,7 @@ static void *dummy_cpu_thread_fn(void *arg)
qemu_sem_wait(&cpu->sem);
#endif
bql_lock();
- qemu_wait_io_event(cpu);
+ qemu_process_cpu_events(cpu);
} while (!cpu->unplug);
bql_unlock();
diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c
index d488d6afbac..7a27bdadb4f 100644
--- a/accel/hvf/hvf-accel-ops.c
+++ b/accel/hvf/hvf-accel-ops.c
@@ -198,7 +198,7 @@ static void *hvf_cpu_thread_fn(void *arg)
cpu_handle_guest_debug(cpu);
}
}
- qemu_wait_io_event(cpu);
+ qemu_process_cpu_events(cpu);
} while (!cpu->unplug || cpu_can_run(cpu));
hvf_vcpu_destroy(cpu);
diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c
index b709187c7d7..65a7f76a69a 100644
--- a/accel/kvm/kvm-accel-ops.c
+++ b/accel/kvm/kvm-accel-ops.c
@@ -53,7 +53,7 @@ static void *kvm_vcpu_thread_fn(void *arg)
cpu_handle_guest_debug(cpu);
}
}
- qemu_wait_io_event(cpu);
+ qemu_process_cpu_events(cpu);
} while (!cpu->unplug || cpu_can_run(cpu));
kvm_destroy_vcpu(cpu);
diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttcg.c
index 1148ebcaae5..342917c5f6e 100644
--- a/accel/tcg/tcg-accel-ops-mttcg.c
+++ b/accel/tcg/tcg-accel-ops-mttcg.c
@@ -113,7 +113,7 @@ static void *mttcg_cpu_thread_fn(void *arg)
}
}
- qemu_wait_io_event(cpu);
+ qemu_process_cpu_events(cpu);
} while (!cpu->unplug || cpu_can_run(cpu));
tcg_cpu_destroy(cpu);
diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c
index a1d75fd3419..813b313859a 100644
--- a/accel/tcg/tcg-accel-ops-rr.c
+++ b/accel/tcg/tcg-accel-ops-rr.c
@@ -117,7 +117,7 @@ static void rr_wait_io_event(void)
rr_start_kick_timer();
CPU_FOREACH(cpu) {
- qemu_wait_io_event_common(cpu);
+ qemu_process_cpu_events_common(cpu);
}
}
@@ -203,7 +203,7 @@ static void *rr_cpu_thread_fn(void *arg)
/* process any pending work */
CPU_FOREACH(cpu) {
current_cpu = cpu;
- qemu_wait_io_event_common(cpu);
+ qemu_process_cpu_events_common(cpu);
}
}
diff --git a/cpu-common.c b/cpu-common.c
index 152661df8e9..0eb5c7b8f24 100644
--- a/cpu-common.c
+++ b/cpu-common.c
@@ -137,7 +137,7 @@ static void queue_work_on_cpu(CPUState *cpu, struct qemu_work_item *wi)
wi->done = false;
qemu_mutex_unlock(&cpu->work_mutex);
- /* exit the inner loop and reach qemu_wait_io_event_common(). */
+ /* exit the inner loop and reach qemu_process_cpu_events_common(). */
cpu_exit(cpu);
}
diff --git a/system/cpus.c b/system/cpus.c
index bb13942cbb7..fd804e07327 100644
--- a/system/cpus.c
+++ b/system/cpus.c
@@ -450,7 +450,7 @@ static void qemu_cpu_stop(CPUState *cpu, bool exit)
qemu_cond_broadcast(&qemu_pause_cond);
}
-void qemu_wait_io_event_common(CPUState *cpu)
+void qemu_process_cpu_events_common(CPUState *cpu)
{
qatomic_set_mb(&cpu->thread_kicked, false);
if (cpu->stop) {
@@ -459,7 +459,7 @@ void qemu_wait_io_event_common(CPUState *cpu)
process_queued_cpu_work(cpu);
}
-void qemu_wait_io_event(CPUState *cpu)
+void qemu_process_cpu_events(CPUState *cpu)
{
bool slept = false;
@@ -474,7 +474,7 @@ void qemu_wait_io_event(CPUState *cpu)
qemu_plugin_vcpu_resume_cb(cpu);
}
- qemu_wait_io_event_common(cpu);
+ qemu_process_cpu_events_common(cpu);
}
void cpus_kick_thread(CPUState *cpu)
diff --git a/target/i386/nvmm/nvmm-accel-ops.c b/target/i386/nvmm/nvmm-accel-ops.c
index 86869f133e9..d066364b989 100644
--- a/target/i386/nvmm/nvmm-accel-ops.c
+++ b/target/i386/nvmm/nvmm-accel-ops.c
@@ -51,7 +51,7 @@ static void *qemu_nvmm_cpu_thread_fn(void *arg)
while (cpu_thread_is_idle(cpu)) {
qemu_cond_wait_bql(cpu->halt_cond);
}
- qemu_wait_io_event_common(cpu);
+ qemu_process_cpu_events_common(cpu);
} while (!cpu->unplug || cpu_can_run(cpu));
nvmm_destroy_vcpu(cpu);
diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-accel-ops.c
index da58805b1a6..2ca4ee02636 100644
--- a/target/i386/whpx/whpx-accel-ops.c
+++ b/target/i386/whpx/whpx-accel-ops.c
@@ -51,7 +51,7 @@ static void *whpx_cpu_thread_fn(void *arg)
while (cpu_thread_is_idle(cpu)) {
qemu_cond_wait_bql(cpu->halt_cond);
}
- qemu_wait_io_event_common(cpu);
+ qemu_process_cpu_events_common(cpu);
} while (!cpu->unplug || cpu_can_run(cpu));
whpx_destroy_vcpu(cpu);
--
2.51.0
next prev parent reply other threads:[~2025-09-13 8:12 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 8:08 [PULL 00/61] CPU, Rust, x86 changes for 2025-09-13 Paolo Bonzini
2025-09-13 8:08 ` [PULL 01/61] target/ppc: limit cpu_interrupt_exittb to system emulation Paolo Bonzini
2025-09-13 8:08 ` [PULL 02/61] target/sparc: limit cpu_check_irqs " Paolo Bonzini
2025-09-13 8:08 ` [PULL 03/61] target/i386: limit a20 " Paolo Bonzini
2025-09-13 8:08 ` [PULL 04/61] target-arm: remove uses of cpu_interrupt() for user-mode emulation Paolo Bonzini
2025-09-13 8:08 ` [PULL 05/61] user-exec: remove cpu_interrupt() stub Paolo Bonzini
2025-09-13 8:08 ` [PULL 06/61] treewide: clear bits of cs->interrupt_request with cpu_reset_interrupt() Paolo Bonzini
2025-09-13 8:08 ` [PULL 07/61] cpu-common: use atomic access for interrupt_request Paolo Bonzini
2025-09-13 8:08 ` [PULL 08/61] cpus: document that qemu_cpu_kick() can be used for BQL-less operation Paolo Bonzini
2025-09-13 8:08 ` [PULL 09/61] accel: use store_release/load_acquire for cross-thread exit_request Paolo Bonzini
2025-09-13 8:08 ` [PULL 10/61] accel: use atomic accesses for exit_request Paolo Bonzini
2025-09-13 8:08 ` [PULL 11/61] accel/tcg: create a thread-kick function for TCG Paolo Bonzini
2025-09-13 8:08 ` [PULL 12/61] accel/tcg: inline cpu_exit() Paolo Bonzini
2025-09-13 8:08 ` [PULL 13/61] cpus: remove TCG-ism from cpu_exit() Paolo Bonzini
2025-09-13 8:08 ` [PULL 14/61] cpus: properly kick CPUs out of inner execution loop Paolo Bonzini
2025-09-13 8:08 ` Paolo Bonzini [this message]
2025-09-13 8:08 ` [PULL 16/61] bsd-user, linux-user: introduce qemu_process_cpu_events Paolo Bonzini
2025-09-13 8:08 ` [PULL 17/61] cpus: clear exit_request in qemu_process_cpu_events Paolo Bonzini
2025-09-13 8:08 ` [PULL 18/61] accel: make all calls to qemu_process_cpu_events look the same Paolo Bonzini
2025-09-13 8:09 ` [PULL 19/61] tcg/user: do not set exit_request gratuitously Paolo Bonzini
2025-09-13 8:09 ` [PULL 20/61] ci: temporarily remove rust from Ubuntu Paolo Bonzini
2025-09-13 8:09 ` [PULL 21/61] configure: bump Meson to 1.9.0 for use with Rust Paolo Bonzini
2025-09-22 14:07 ` Peter Maydell
2025-09-22 15:14 ` Paolo Bonzini
2025-09-13 8:09 ` [PULL 22/61] meson, cargo: require Rust 1.83.0 Paolo Bonzini
2025-09-13 8:09 ` [PULL 23/61] rust: add missing const markers for MSRV==1.83.0 Paolo Bonzini
2025-09-13 8:09 ` [PULL 24/61] rust: use inline const expressions Paolo Bonzini
2025-09-13 8:09 ` [PULL 25/61] rust: add qdev Device derive macro Paolo Bonzini
2025-09-13 8:09 ` [PULL 26/61] rust: vmstate: convert to use builder pattern Paolo Bonzini
2025-09-13 8:09 ` [PULL 27/61] rust: vmstate: use const_refs_to_static Paolo Bonzini
2025-09-13 8:09 ` [PULL 28/61] rust: qdev: const_refs_to_static Paolo Bonzini
2025-09-13 8:09 ` [PULL 29/61] docs/rust: update msrv Paolo Bonzini
2025-09-13 8:09 ` [PULL 30/61] rust: remove unused global qemu "allocator" Paolo Bonzini
2025-09-13 8:09 ` [PULL 31/61] rust: add workspace authors Paolo Bonzini
2025-09-13 8:09 ` [PULL 32/61] rust: move vmstate_clock!() to qdev module Paolo Bonzini
2025-09-13 8:09 ` [PULL 33/61] rust: move VMState handling to QOM module Paolo Bonzini
2025-09-13 8:09 ` [PULL 34/61] rust: move Cell vmstate impl Paolo Bonzini
2025-09-13 8:09 ` [PULL 35/61] rust: split Rust-only "common" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 36/61] rust: make build.rs generic over various ./rust/projects Paolo Bonzini
2025-09-13 8:09 ` [PULL 37/61] rust: split "util" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 38/61] rust: split "migration" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 39/61] rust: split "bql" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 40/61] rust: split "qom" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 41/61] rust: split "chardev" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 42/61] rust: split "system" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 43/61] rust: split "hwcore" crate Paolo Bonzini
2025-09-13 8:09 ` [PULL 44/61] rust: rename qemu_api_macros -> qemu_macros Paolo Bonzini
2025-09-13 8:09 ` [PULL 45/61] rust/hpet: drop now unneeded qemu_api dep Paolo Bonzini
2025-09-13 8:09 ` [PULL 46/61] rust/pl011: drop dependency on qemu_api Paolo Bonzini
2025-09-13 8:09 ` [PULL 47/61] rust: repurpose qemu_api -> tests Paolo Bonzini
2025-09-13 8:09 ` [PULL 48/61] rust: re-export qemu_macros internal helper in "bits" Paolo Bonzini
2025-09-13 8:09 ` [PULL 49/61] rust: re-export qemu macros from common/qom/hwcore Paolo Bonzini
2025-09-13 8:09 ` [PULL 50/61] docs: update rust.rst Paolo Bonzini
2025-09-13 8:09 ` [PULL 51/61] rust: meson: remove unnecessary complication in device crates Paolo Bonzini
2025-09-13 8:09 ` [PULL 52/61] rust: do not inline do_init_io Paolo Bonzini
2025-09-13 8:09 ` [PULL 53/61] hpet: guard IRQ handling with BQL Paolo Bonzini
2025-09-13 8:09 ` [PULL 54/61] i386/cpu: Enable SMM cpu address space under KVM Paolo Bonzini
2025-09-18 16:24 ` Michael Tokarev
2025-09-22 15:16 ` Paolo Bonzini
2025-09-26 17:48 ` Peter Maydell
2025-09-28 6:51 ` Xiaoyao Li
2025-09-13 8:09 ` [PULL 55/61] target/i386: Define enum X86ASIdx for x86's address spaces Paolo Bonzini
2025-09-13 8:09 ` [PULL 56/61] multiboot: Fix the split lock Paolo Bonzini
2025-09-13 8:09 ` [PULL 57/61] i386/kvm: Get X86MachineState in kvm_arch_init() without the cast check Paolo Bonzini
2025-09-13 8:09 ` [PULL 58/61] i386/kvm: Drop KVM_CAP_X86_SMM check in kvm_arch_init() Paolo Bonzini
2025-09-13 8:09 ` [PULL 59/61] accel/kvm: Switch to check KVM_CAP_GUEST_MEMFD and KVM_CAP_USER_MEMORY2 on VM Paolo Bonzini
2025-09-13 8:09 ` [PULL 60/61] accel/kvm: Zero out mem explicitly in kvm_set_user_memory_region() Paolo Bonzini
2025-09-13 8:09 ` [PULL 61/61] accel/kvm: Set guest_memfd_offset to non-zero value only when guest_memfd is valid Paolo Bonzini
2025-09-13 9:37 ` [PULL 00/61] CPU, Rust, x86 changes for 2025-09-13 Peter Maydell
2025-09-16 14:37 ` Peter Maydell
2025-09-16 14:53 ` Paolo Bonzini
2025-09-17 16:33 ` Richard Henderson
2025-09-18 12:38 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250913080943.11710-16-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).