From: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com>
To: berrange@redhat.com
Cc: amit@kernel.org, armbru@redhat.com, eblake@redhat.com,
eduardo@habkost.net, filip.hejsek@gmail.com, lvivier@redhat.com,
marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com,
maxbr@linux.ibm.com, mst@redhat.com, noh4hss@gmail.com,
pbonzini@redhat.com, philmd@linaro.org, qemu-devel@nongnu.org,
wangyanan55@huawei.com, zhao1.liu@intel.com
Subject: [PATCH] char-pty: add support for the terminal size
Date: Mon, 15 Sep 2025 18:25:35 +0200 [thread overview]
Message-ID: <20250915162535.147642-1-maxbr@linux.ibm.com> (raw)
In-Reply-To: <aMfR3N3z6_fp6Lg9@redhat.com>
Update the terminal size upon SIGWINCH delivery.
To be committed with the patch-set: [PATCH v4 00/10] virtio-console: notify about the terminal size
Signed-off-by: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com>
---
chardev/char-pty.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/chardev/char-pty.c b/chardev/char-pty.c
index 674e9b3f14..802bae9037 100644
--- a/chardev/char-pty.c
+++ b/chardev/char-pty.c
@@ -28,6 +28,7 @@
#include "io/channel-file.h"
#include "qemu/sockets.h"
#include "qemu/error-report.h"
+#include "qemu/main-loop.h"
#include "qemu/module.h"
#include "qemu/option.h"
#include "qemu/qemu-print.h"
@@ -35,6 +36,8 @@
#include "chardev/char-io.h"
#include "qom/object.h"
+#include <sys/ioctl.h>
+
struct PtyChardev {
Chardev parent;
QIOChannel *ioc;
@@ -43,6 +46,8 @@ struct PtyChardev {
int connected;
GSource *timer_src;
char *path;
+
+ Notifier resize_notifier;
};
typedef struct PtyChardev PtyChardev;
@@ -85,6 +90,15 @@ static void pty_chr_rearm_timer(Chardev *chr, int ms)
g_free(name);
}
+static void pty_chr_resize(PtyChardev *s)
+{
+ struct winsize ws;
+
+ if (ioctl(QIO_CHANNEL_FILE(s->ioc)->fd, TIOCGWINSZ, &ws) != -1) {
+ qemu_chr_resize(CHARDEV(s), ws.ws_col, ws.ws_row);
+ }
+}
+
static void pty_chr_update_read_handler(Chardev *chr)
{
PtyChardev *s = PTY_CHARDEV(chr);
@@ -331,6 +345,12 @@ static int qemu_openpty_raw(int *aslave, char *pty_name)
return amaster;
}
+static void term_resize_notify(Notifier *n, void *data)
+{
+ PtyChardev *s = container_of(n, PtyChardev, resize_notifier);
+ pty_chr_resize(s);
+}
+
static void char_pty_open(Chardev *chr,
ChardevBackend *backend,
bool *be_opened,
@@ -376,6 +396,10 @@ static void char_pty_open(Chardev *chr,
s->path = g_strdup(path);
}
}
+
+ pty_chr_resize(s);
+ s->resize_notifier.notify = term_resize_notify;
+ sigwinch_add_notifier(&s->resize_notifier);
}
static void char_pty_parse(QemuOpts *opts, ChardevBackend *backend,
--
2.50.1
next prev parent reply other threads:[~2025-09-15 16:28 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 3:39 [PATCH v4 00/10] virtio-console: notify about the terminal size Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 01/10] chardev: add cols, rows fields Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 02/10] chardev: add CHR_EVENT_RESIZE Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 03/10] chardev: add qemu_chr_resize() Filip Hejsek
2025-09-18 8:45 ` Maximilian Immanuel Brandtner
2025-09-18 9:31 ` Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 04/10] char-mux: add support for the terminal size Filip Hejsek
2025-09-18 8:32 ` Maximilian Immanuel Brandtner
2025-09-18 9:11 ` Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 05/10] main-loop: change the handling of SIGWINCH Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 06/10] char-stdio: add support for the terminal size Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 07/10] qmp: add chardev-resize command Filip Hejsek
2025-09-12 14:01 ` Markus Armbruster
2025-09-12 18:10 ` Filip Hejsek
2025-09-15 6:35 ` Markus Armbruster
2025-09-15 22:22 ` Filip Hejsek
2025-09-16 13:07 ` Markus Armbruster
2025-09-16 17:01 ` Filip Hejsek
2025-09-17 8:25 ` Markus Armbruster
2025-09-12 3:39 ` [PATCH v4 08/10] virtio-serial-bus: add terminal resize messages Filip Hejsek
2025-09-12 13:50 ` Markus Armbruster
2025-09-12 15:02 ` Filip Hejsek
2025-09-18 8:23 ` Daniel P. Berrangé
2025-09-18 8:51 ` Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 09/10] virtio-console: notify the guest about terminal resizes Filip Hejsek
2025-09-12 3:39 ` [PATCH v4 10/10] char-win-stdio: add support for terminal size Filip Hejsek
2025-09-12 8:41 ` [PATCH v4 00/10] virtio-console: notify about the " Michael S. Tsirkin
2025-09-12 8:44 ` Michael S. Tsirkin
2025-09-12 8:50 ` Daniel P. Berrangé
2025-09-12 8:54 ` Michael S. Tsirkin
2025-09-15 8:41 ` Maximilian Immanuel Brandtner
2025-09-15 8:44 ` Daniel P. Berrangé
2025-09-15 16:25 ` Maximilian Immanuel Brandtner [this message]
2025-09-15 16:34 ` [PATCH v2] char-pty: add support for " Maximilian Immanuel Brandtner
2025-09-15 16:36 ` Michael S. Tsirkin
2025-09-15 22:02 ` Filip Hejsek
2025-09-17 9:39 ` Maximilian Immanuel Brandtner
2025-09-17 13:09 ` Filip Hejsek
2025-09-17 13:31 ` Daniel P. Berrangé
2025-09-17 14:08 ` Filip Hejsek
2025-09-17 16:17 ` Daniel P. Berrangé
2025-09-17 17:11 ` Filip Hejsek
2025-09-17 17:53 ` Daniel P. Berrangé
2025-09-17 18:29 ` Filip Hejsek
2025-09-18 8:35 ` Daniel P. Berrangé
2025-09-18 8:39 ` Maximilian Immanuel Brandtner
2025-09-18 8:48 ` Daniel P. Berrangé
2025-09-18 8:54 ` Maximilian Immanuel Brandtner
2025-09-18 8:59 ` Daniel P. Berrangé
2025-09-18 9:05 ` Maximilian Immanuel Brandtner
2025-09-18 19:21 ` Filip Hejsek
2025-09-18 7:53 ` Maximilian Immanuel Brandtner
2025-09-18 8:10 ` Filip Hejsek
2025-09-12 14:24 ` [PATCH v4 00/10] virtio-console: notify about " Filip Hejsek
2025-09-15 23:02 ` Filip Hejsek
2025-09-15 23:08 ` Michael S. Tsirkin
2025-09-17 18:32 ` Filip Hejsek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915162535.147642-1-maxbr@linux.ibm.com \
--to=maxbr@linux.ibm.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=filip.hejsek@gmail.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=noh4hss@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).