qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Mads Ynddal" <mads@ynddal.dk>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PULL v2 1/8] checkpatch: cull trailing '*/' in SPDX check
Date: Tue, 16 Sep 2025 13:51:01 -0400	[thread overview]
Message-ID: <20250916175108.139627-2-stefanha@redhat.com> (raw)
In-Reply-To: <20250916175108.139627-1-stefanha@redhat.com>

From: Daniel P. Berrangé <berrange@redhat.com>

Sometimes SPDX expressions appear inside C comments, and this
confuses checkpatch.pl. Drop the closing C comment characters
to avoid this.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20250916081638.764020-2-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/checkpatch.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 833f20f555..91616c974f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1368,6 +1368,9 @@ sub checkspdx {
     $expr =~ s/^\s*//g;
     $expr =~ s/\s*$//g;
 
+    # Cull C comment end
+    $expr =~ s/\*\/.*//;
+
     my @bits = split / +/, $expr;
 
     my $prefer = "GPL-2.0-or-later";
-- 
2.51.0



  reply	other threads:[~2025-09-16 17:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 17:51 [PULL v2 0/8] Tracing patches Stefan Hajnoczi
2025-09-16 17:51 ` Stefan Hajnoczi [this message]
2025-09-16 17:51 ` [PULL v2 2/8] tracetool: eliminate trailing whitespace in C format Stefan Hajnoczi
2025-09-16 17:51 ` [PULL v2 3/8] tracetool: avoid space after "*" in arg types Stefan Hajnoczi
2025-09-16 17:51 ` [PULL v2 4/8] tracetool: include SPDX-License-Identifier in generated files Stefan Hajnoczi
2025-09-16 17:51 ` [PULL v2 5/8] tracetool: add test suite for tracetool with reference output Stefan Hajnoczi
2025-09-16 17:51 ` [PULL v2 6/8] tracetool: drop the probe "__nocheck__" wrapping Stefan Hajnoczi
2025-09-16 17:51 ` [PULL v2 7/8] qapi: switch to use QEMU_TEST_REGENERATE env var Stefan Hajnoczi
2025-09-16 17:51 ` [PULL v2 8/8] tracetool-test: allow to run in parallel Stefan Hajnoczi
2025-09-17 18:09 ` [PULL v2 0/8] Tracing patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916175108.139627-2-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=mads@ynddal.dk \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).