From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: odaki@rsg.ci.i.u-tokyo.ac.jp, marcandre.lureau@redhat.com,
berrange@redhat.com
Subject: [PATCH v2 09/12] ui/pixman: Consistent error handling in qemu_pixman_shareable_free()
Date: Wed, 17 Sep 2025 13:52:04 +0200 [thread overview]
Message-ID: <20250917115207.1730186-10-armbru@redhat.com> (raw)
In-Reply-To: <20250917115207.1730186-1-armbru@redhat.com>
qemu_pixman_shareable_free() wraps around either qemu_memfd_free() or
qemu_win32_map_free(). The former reports trouble as error, with
error_report(), then succeeds. The latter reports it as warning (we
pass it &error_warn), then succeeds.
Change the latter to report as error, too.
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/qemu-pixman.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c
index ef4e71da11..e46c6232cf 100644
--- a/ui/qemu-pixman.c
+++ b/ui/qemu-pixman.c
@@ -288,7 +288,10 @@ qemu_pixman_shareable_free(qemu_pixman_shareable handle,
void *ptr, size_t size)
{
#ifdef WIN32
- qemu_win32_map_free(ptr, handle, &error_warn);
+ Error *err = NULL;
+
+ qemu_win32_map_free(ptr, handle, &err);
+ error_report_err(err);
#else
qemu_memfd_free(ptr, size, handle);
#endif
--
2.49.0
next prev parent reply other threads:[~2025-09-17 11:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 11:51 [PATCH v2 00/12] Error reporting cleanup, a fix, and &error_warn removal Markus Armbruster
2025-09-17 11:51 ` [PATCH v2 01/12] monitor: Clean up HMP gdbserver error reporting Markus Armbruster
2025-09-17 11:51 ` [PATCH v2 02/12] tcg: Fix error reporting on mprotect() failure in tcg_region_init() Markus Armbruster
2025-09-17 16:23 ` Richard Henderson
2025-09-18 12:23 ` Akihiko Odaki
2025-09-18 14:22 ` Markus Armbruster
2025-09-17 11:51 ` [PATCH v2 03/12] hw/cxl: Convert cxl_fmws_link() to Error Markus Armbruster
2025-09-17 13:15 ` Jonathan Cameron via
2025-09-17 11:51 ` [PATCH v2 04/12] migration/cpr: Clean up error reporting in cpr_resave_fd() Markus Armbruster
2025-09-17 11:52 ` [PATCH v2 05/12] hw/remote/vfio-user: Clean up error reporting Markus Armbruster
2025-09-17 11:52 ` [PATCH v2 06/12] net/slirp: " Markus Armbruster
2025-09-18 12:24 ` Akihiko Odaki
2025-09-18 14:24 ` Markus Armbruster
2025-09-17 11:52 ` [PATCH v2 07/12] ui/spice-core: " Markus Armbruster
2025-09-17 20:34 ` Richard Henderson
2025-09-17 11:52 ` [PATCH v2 08/12] util/oslib-win32: Do not treat null @errp as &error_warn Markus Armbruster
2025-09-17 20:33 ` Richard Henderson
2025-09-17 11:52 ` Markus Armbruster [this message]
2025-09-17 11:52 ` [PATCH v2 10/12] ui/dbus: Clean up dbus_update_gl_cb() error checking Markus Armbruster
2025-09-17 11:52 ` [PATCH v2 11/12] ui/dbus: Consistent handling of texture mutex failure Markus Armbruster
2025-09-17 11:52 ` [PATCH v2 12/12] error: Kill @error_warn Markus Armbruster
2025-09-17 15:18 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917115207.1730186-10-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).