From: Filip Hejsek <filip.hejsek@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Maximilian Immanuel Brandtner" <maxbr@linux.ibm.com>,
"Szymon Lukasz" <noh4hss@gmail.com>,
"Filip Hejsek" <filip.hejsek@gmail.com>
Subject: [PATCH RFC v5 01/12] chardev: add cols, rows fields
Date: Sun, 21 Sep 2025 01:45:31 +0200 [thread overview]
Message-ID: <20250921-console-resize-v5-1-89e3c6727060@gmail.com> (raw)
In-Reply-To: <20250921-console-resize-v5-0-89e3c6727060@gmail.com>
From: Szymon Lukasz <noh4hss@gmail.com>
These fields should be interpreted as the size of the terminal connected
to a given chardev.
Signed-off-by: Szymon Lukasz <noh4hss@gmail.com>
Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>
---
chardev/char-fe.c | 13 +++++++++++++
include/chardev/char-fe.h | 10 ++++++++++
include/chardev/char.h | 1 +
3 files changed, 24 insertions(+)
diff --git a/chardev/char-fe.c b/chardev/char-fe.c
index 158a5f4f551ee49120eee6ebdf772fb450739f47..8622898bd414c208b5a0397b439e18a8bf0b8a92 100644
--- a/chardev/char-fe.c
+++ b/chardev/char-fe.c
@@ -329,6 +329,19 @@ void qemu_chr_fe_set_echo(CharBackend *be, bool echo)
}
}
+void qemu_chr_fe_get_winsize(CharBackend *be, uint16_t *cols, uint16_t *rows)
+{
+ Chardev *chr = be->chr;
+
+ if (chr) {
+ *cols = chr->cols;
+ *rows = chr->rows;
+ } else {
+ *cols = 0;
+ *rows = 0;
+ }
+}
+
void qemu_chr_fe_set_open(CharBackend *be, bool is_open)
{
Chardev *chr = be->chr;
diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h
index 8ef05b3dd095bdcaa51b10482261a29b1e8233c7..02d5606fa343ac64a76f48dcd250b5431a0a7761 100644
--- a/include/chardev/char-fe.h
+++ b/include/chardev/char-fe.h
@@ -158,6 +158,16 @@ int qemu_chr_fe_wait_connected(CharBackend *be, Error **errp);
*/
void qemu_chr_fe_set_echo(CharBackend *be, bool echo);
+/**
+ * qemu_chr_fe_get_winsize:
+ * @cols: the address for storing columns
+ * @rows: the address for storing rows
+ *
+ * Get the size of the terminal connected to the chardev backend.
+ * Returns *cols = *rows = 0, if no associated Chardev.
+ */
+void qemu_chr_fe_get_winsize(CharBackend *be, uint16_t *cols, uint16_t *rows);
+
/**
* qemu_chr_fe_set_open:
* @be: a CharBackend
diff --git a/include/chardev/char.h b/include/chardev/char.h
index 429852f8d9d3c5a7e061acea3561b019b15d658f..336b2e68d099e70a9abe71ef842b160bf12ea932 100644
--- a/include/chardev/char.h
+++ b/include/chardev/char.h
@@ -65,6 +65,7 @@ struct Chardev {
char *filename;
int logfd;
int be_open;
+ uint16_t cols, rows;
/* used to coordinate the chardev-change special-case: */
bool handover_yank_instance;
GSource *gsource;
--
2.51.0
next prev parent reply other threads:[~2025-09-20 23:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 23:45 [PATCH RFC v5 00/12] virtio-console: notify about the terminal size Filip Hejsek
2025-09-20 23:45 ` Filip Hejsek [this message]
2025-09-22 8:13 ` [PATCH RFC v5 01/12] chardev: add cols, rows fields Daniel P. Berrangé
2025-10-13 5:09 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 02/12] chardev: add CHR_EVENT_RESIZE Filip Hejsek
2025-09-22 8:16 ` Daniel P. Berrangé
2025-10-13 5:11 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 03/12] chardev: add qemu_chr_resize() Filip Hejsek
2025-09-22 8:19 ` Daniel P. Berrangé
2025-10-13 5:12 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 04/12] char-mux: add support for the terminal size Filip Hejsek
2025-09-22 8:21 ` Daniel P. Berrangé
2025-10-13 5:13 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 05/12] main-loop: change the handling of SIGWINCH Filip Hejsek
2025-09-22 8:29 ` Daniel P. Berrangé
2025-10-13 5:13 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 06/12] char-stdio: add support for the terminal size Filip Hejsek
2025-09-22 8:33 ` Daniel P. Berrangé
2025-10-13 5:14 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 07/12] qmp: add chardev-window-size-changed command Filip Hejsek
2025-09-22 6:45 ` Markus Armbruster
2025-09-22 8:52 ` Filip Hejsek
2025-09-22 9:38 ` Markus Armbruster
2025-09-22 8:35 ` Daniel P. Berrangé
2025-10-13 5:18 ` Dominique Martinet
2025-10-13 5:23 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 08/12] virtio-serial-bus: add terminal resize messages Filip Hejsek
2025-09-22 8:53 ` Daniel P. Berrangé
2025-10-13 5:19 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 09/12] virtio-console: notify the guest about terminal resizes Filip Hejsek
2025-09-22 8:45 ` Daniel P. Berrangé
2025-10-13 5:28 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 10/12] char-win-stdio: add support for terminal size Filip Hejsek
2025-09-22 8:38 ` Daniel P. Berrangé
2025-10-13 5:29 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 11/12] ui/console-vc: forward text console size to vc chardev Filip Hejsek
2025-09-22 8:41 ` Daniel P. Berrangé
2025-10-13 5:29 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 12/12] ui/gtk: forward gtk " Filip Hejsek
2025-09-22 8:41 ` Daniel P. Berrangé
2025-10-13 5:44 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250921-console-resize-v5-1-89e3c6727060@gmail.com \
--to=filip.hejsek@gmail.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=noh4hss@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).