qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: [PATCH v5 60/76] target/arm: Add gcs record for BLR with PAuth
Date: Mon, 22 Sep 2025 11:49:08 -0700	[thread overview]
Message-ID: <20250922184924.2754205-61-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250922184924.2754205-1-richard.henderson@linaro.org>

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/tcg/translate-a64.c | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 79fc7b8c3d..529c5bef0c 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -1842,21 +1842,21 @@ static bool trans_BRAZ(DisasContext *s, arg_braz *a)
 
 static bool trans_BLRAZ(DisasContext *s, arg_braz *a)
 {
-    TCGv_i64 dst, lr;
+    TCGv_i64 dst, link;
 
     if (!dc_isar_feature(aa64_pauth, s)) {
         return false;
     }
-
     dst = auth_branch_target(s, cpu_reg(s, a->rn), tcg_constant_i64(0), !a->m);
-    lr = cpu_reg(s, 30);
-    if (dst == lr) {
-        TCGv_i64 tmp = tcg_temp_new_i64();
-        tcg_gen_mov_i64(tmp, dst);
-        dst = tmp;
+
+    link = tcg_temp_new_i64();
+    gen_pc_plus_diff(s, link, 4);
+    if (s->gcs_en) {
+        gen_add_gcs_record(s, link);
     }
-    gen_pc_plus_diff(s, lr, curr_insn_len(s));
     gen_a64_set_pc(s, dst);
+    tcg_gen_mov_i64(cpu_reg(s, 30), link);
+
     set_btype_for_blr(s);
     s->base.is_jmp = DISAS_JUMP;
     return true;
@@ -1892,20 +1892,21 @@ static bool trans_BRA(DisasContext *s, arg_bra *a)
 
 static bool trans_BLRA(DisasContext *s, arg_bra *a)
 {
-    TCGv_i64 dst, lr;
+    TCGv_i64 dst, link;
 
     if (!dc_isar_feature(aa64_pauth, s)) {
         return false;
     }
     dst = auth_branch_target(s, cpu_reg(s, a->rn), cpu_reg_sp(s, a->rm), !a->m);
-    lr = cpu_reg(s, 30);
-    if (dst == lr) {
-        TCGv_i64 tmp = tcg_temp_new_i64();
-        tcg_gen_mov_i64(tmp, dst);
-        dst = tmp;
+
+    link = tcg_temp_new_i64();
+    gen_pc_plus_diff(s, link, 4);
+    if (s->gcs_en) {
+        gen_add_gcs_record(s, link);
     }
-    gen_pc_plus_diff(s, lr, curr_insn_len(s));
     gen_a64_set_pc(s, dst);
+    tcg_gen_mov_i64(cpu_reg(s, 30), link);
+
     set_btype_for_blr(s);
     s->base.is_jmp = DISAS_JUMP;
     return true;
-- 
2.43.0



  parent reply	other threads:[~2025-09-22 19:08 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 18:48 [PATCH v5 00/76] target/arm: Implement FEAT_GCS Richard Henderson
2025-09-22 18:48 ` [PATCH v5 01/76] target/arm: Add isar feature test for FEAT_S1PIE, FEAT_S2PIE Richard Henderson
2025-09-22 18:48 ` [PATCH v5 02/76] target/arm: Enable TCR2_ELx.PIE Richard Henderson
2025-09-22 18:48 ` [PATCH v5 03/76] target/arm: Implement PIR_ELx, PIRE0_ELx, S2PIR_EL2 registers Richard Henderson
2025-09-22 18:48 ` [PATCH v5 04/76] target/arm: Force HPD for stage2 translations Richard Henderson
2025-09-22 18:48 ` [PATCH v5 05/76] target/arm: Cache NV1 early in get_phys_addr_lpae Richard Henderson
2025-09-22 18:48 ` [PATCH v5 06/76] target/arm: Populate PIE in aa64_va_parameters Richard Henderson
2025-09-22 18:48 ` [PATCH v5 07/76] target/arm: Implement get_S1prot_indirect Richard Henderson
2025-09-22 18:48 ` [PATCH v5 08/76] target/arm: Implement get_S2prot_indirect Richard Henderson
2025-09-22 18:48 ` [PATCH v5 09/76] target/arm: Expand CPUARMState.exception.syndrome to 64 bits Richard Henderson
2025-09-22 18:48 ` [PATCH v5 10/76] target/arm: Expand syndrome parameter to raise_exception* Richard Henderson
2025-09-22 18:48 ` [PATCH v5 11/76] target/arm: Implement dirtybit check for PIE Richard Henderson
2025-09-22 18:48 ` [PATCH v5 12/76] target/arm: Enable FEAT_S1PIE and FEAT_S2PIE on -cpu max Richard Henderson
2025-09-22 18:48 ` [PATCH v5 13/76] include/hw/core/cpu: Introduce MMUIdxMap Richard Henderson
2025-09-22 18:48 ` [PATCH v5 14/76] include/hw/core/cpu: Introduce cpu_tlb_fast Richard Henderson
2025-09-22 18:48 ` [PATCH v5 15/76] include/hw/core/cpu: Invert the indexing into CPUTLBDescFast Richard Henderson
2025-09-22 18:48 ` [PATCH v5 16/76] target/hppa: Adjust mmu indexes to begin with 0 Richard Henderson
2025-09-22 18:48 ` [PATCH v5 17/76] include/exec/memopidx: Adjust for 32 mmu indexes Richard Henderson
2025-09-22 18:48 ` [PATCH v5 18/76] include/hw/core/cpu: Widen MMUIdxMap Richard Henderson
2025-09-22 18:48 ` [PATCH v5 19/76] target/arm: Split out mmuidx.h from cpu.h Richard Henderson
2025-09-22 18:48 ` [PATCH v5 20/76] target/arm: Convert arm_mmu_idx_to_el from switch to table Richard Henderson
2025-09-22 18:48 ` [PATCH v5 21/76] target/arm: Remove unused env argument from regime_el Richard Henderson
2025-09-22 18:48 ` [PATCH v5 22/76] target/arm: Convert regime_el from switch to table Richard Henderson
2025-09-22 18:48 ` [PATCH v5 23/76] target/arm: Convert regime_has_2_ranges " Richard Henderson
2025-09-22 18:48 ` [PATCH v5 24/76] target/arm: Remove unused env argument from regime_is_pan Richard Henderson
2025-09-22 18:48 ` [PATCH v5 25/76] target/arm: Convert regime_is_pan from switch to table Richard Henderson
2025-09-22 18:48 ` [PATCH v5 26/76] target/arm: Remove unused env argument from regime_is_user Richard Henderson
2025-09-22 18:48 ` [PATCH v5 27/76] target/arm: Convert regime_is_user from switch to table Richard Henderson
2025-09-22 18:48 ` [PATCH v5 28/76] target/arm: Convert arm_mmu_idx_is_stage1_of_2 " Richard Henderson
2025-09-22 18:48 ` [PATCH v5 29/76] target/arm: Convert regime_is_stage2 " Richard Henderson
2025-09-22 18:48 ` [PATCH v5 30/76] target/arm: Introduce mmu indexes for GCS Richard Henderson
2025-09-22 18:48 ` [PATCH v5 31/76] target/arm: Introduce regime_to_gcs Richard Henderson
2025-09-22 18:48 ` [PATCH v5 32/76] target/arm: Support page protections for GCS mmu indexes Richard Henderson
2025-09-22 18:48 ` [PATCH v5 33/76] target/arm: Implement gcs bit for data abort Richard Henderson
2025-09-22 18:48 ` [PATCH v5 34/76] target/arm: Add GCS cpregs Richard Henderson
2025-09-22 18:48 ` [PATCH v5 35/76] target/arm: Add GCS enable and trap levels to DisasContext Richard Henderson
2025-09-22 18:48 ` [PATCH v5 36/76] target/arm: Implement FEAT_CHK Richard Henderson
2025-09-22 18:48 ` [PATCH v5 37/76] target/arm: Make helper_exception_return system-only Richard Henderson
2025-09-22 18:48 ` [PATCH v5 38/76] target/arm: Export cpsr_{read_for, write_from}_spsr_elx Richard Henderson
2025-09-22 18:48 ` [PATCH v5 39/76] target/arm: Expand pstate to 64 bits Richard Henderson
2025-09-22 18:48 ` [PATCH v5 40/76] target/arm: Add syndrome data for EC_GCS Richard Henderson
2025-09-22 18:48 ` [PATCH v5 41/76] target/arm: Add arm_hcr_el2_nvx_eff Richard Henderson
2025-09-22 18:48 ` [PATCH v5 42/76] target/arm: Use arm_hcr_el2_nvx_eff in access_nv1 Richard Henderson
2025-09-22 18:48 ` [PATCH v5 43/76] target/arm: Split out access_nv1_with_nvx Richard Henderson
2025-09-22 18:48 ` [PATCH v5 44/76] target/arm: Implement EXLOCKException for ELR_ELx and SPSR_ELx Richard Henderson
2025-09-22 18:48 ` [PATCH v5 45/76] target/arm: Split {full,core}_a64_user_mem_index Richard Henderson
2025-09-22 18:48 ` [PATCH v5 46/76] target/arm: Introduce delay_exception{_el} Richard Henderson
2025-09-22 18:48 ` [PATCH v5 47/76] target/arm: Emit HSTR trap exception out of line Richard Henderson
2025-09-22 18:48 ` [PATCH v5 48/76] target/arm: Emit v7m LTPSIZE " Richard Henderson
2025-09-22 18:48 ` [PATCH v5 49/76] target/arm: Implement GCSSTR, GCSSTTR Richard Henderson
2025-09-22 18:48 ` [PATCH v5 50/76] target/arm: Implement GCSB Richard Henderson
2025-09-22 18:48 ` [PATCH v5 51/76] target/arm: Implement GCSPUSHM Richard Henderson
2025-09-22 18:49 ` [PATCH v5 52/76] target/arm: Implement GCSPOPM Richard Henderson
2025-09-22 18:49 ` [PATCH v5 53/76] target/arm: Implement GCSPUSHX Richard Henderson
2025-09-22 18:49 ` [PATCH v5 54/76] target/arm: Implement GCSPOPX Richard Henderson
2025-09-22 18:49 ` [PATCH v5 55/76] target/arm: Implement GCSPOPCX Richard Henderson
2025-09-22 18:49 ` [PATCH v5 56/76] target/arm: Implement GCSSS1 Richard Henderson
2025-09-22 18:49 ` [PATCH v5 57/76] target/arm: Implement GCSSS2 Richard Henderson
2025-09-22 18:49 ` [PATCH v5 58/76] target/arm: Add gcs record for BL Richard Henderson
2025-09-22 18:49 ` [PATCH v5 59/76] target/arm: Add gcs record for BLR Richard Henderson
2025-09-22 18:49 ` Richard Henderson [this message]
2025-09-22 18:49 ` [PATCH v5 61/76] target/arm: Load gcs record for RET Richard Henderson
2025-09-22 18:49 ` [PATCH v5 62/76] target/arm: Load gcs record for RET with PAuth Richard Henderson
2025-09-22 18:49 ` [PATCH v5 63/76] target/arm: Copy EXLOCKEn to EXLOCK on exception to the same EL Richard Henderson
2025-09-22 18:49 ` [PATCH v5 64/76] target/arm: Implement EXLOCK check during exception return Richard Henderson
2025-09-22 18:49 ` [PATCH v5 65/76] target/arm: Enable FEAT_GCS with -cpu max Richard Henderson
2025-09-22 18:49 ` [PATCH v5 66/76] linux-user/aarch64: Implement prctls for GCS Richard Henderson
2025-09-22 18:49 ` [PATCH v5 67/76] linux-user/aarch64: Allocate new gcs stack on clone Richard Henderson
2025-09-22 18:49 ` [PATCH v5 68/76] linux-user/aarch64: Release gcs stack on thread exit Richard Henderson
2025-09-22 18:49 ` [PATCH v5 69/76] linux-user/aarch64: Implement map_shadow_stack syscall Richard Henderson
2025-09-22 18:49 ` [PATCH v5 70/76] target/arm: Enable GCSPR_EL0 for read in user-mode Richard Henderson
2025-09-22 18:49 ` [PATCH v5 71/76] linux-user/aarch64: Inject SIGSEGV for GCS faults Richard Henderson
2025-09-22 18:49 ` [PATCH v5 72/76] linux-user/aarch64: Generate GCS signal records Richard Henderson
2025-09-22 18:49 ` [PATCH v5 73/76] linux-user/aarch64: Enable GCS in HWCAP Richard Henderson
2025-09-22 18:49 ` [PATCH v5 74/76] tests/tcg/aarch64: Add gcsstr Richard Henderson
2025-09-22 18:49 ` [PATCH v5 75/76] tests/tcg/aarch64: Add gcspushm Richard Henderson
2025-09-22 18:49 ` [PATCH v5 76/76] tests/tcg/aarch64: Add gcsss Richard Henderson
2025-09-23 23:58 ` [PATCH v5 00/76] target/arm: Implement FEAT_GCS Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922184924.2754205-61-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).