From: Minglei Liu <minglei.liu@smartx.com>
To: qemu-devel@nongnu.org
Cc: Kostiantyn Kostiuk <kkostiuk@redhat.com>,
Michael Roth <michael.roth@amd.com>,
"minglei.liu" <minglei.liu@smartx.com>
Subject: [PATCH] qga: Improve Windows filesystem space info retrieval logic
Date: Tue, 23 Sep 2025 19:32:43 +0800 [thread overview]
Message-ID: <20250923113243.78244-1-minglei.liu@smartx.com> (raw)
From: "minglei.liu" <minglei.liu@smartx.com>
Previously, disk space reporting only worked for volumes with drive letters,
skipping those without (e.g. System Reserved).
This change always calls GetDiskFreeSpaceEx with fs->name, which is a
volume GUID path. Windows APIs accept both drive letters (e.g. "C:\")
and volume GUIDs (e.g. "\\?\Volume{GUID}\") as valid lpDirectoryName
parameters, so space reporting is now consistent across all volumes.
Reference:
https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file
Signed-off-by: minglei.liu <minglei.liu@smartx.com>
---
qga/commands-win32.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 8227480810..acc2c11589 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1164,15 +1164,15 @@ static GuestFilesystemInfo *build_guest_fsinfo(char *guid, Error **errp)
fs->mountpoint = g_strdup("System Reserved");
} else {
fs->mountpoint = g_strndup(mnt_point, len);
- if (GetDiskFreeSpaceEx(fs->mountpoint,
- (PULARGE_INTEGER) & i64FreeBytesToCaller,
- (PULARGE_INTEGER) & i64TotalBytes,
- (PULARGE_INTEGER) & i64FreeBytes)) {
- fs->used_bytes = i64TotalBytes - i64FreeBytes;
- fs->total_bytes = i64TotalBytes;
- fs->has_total_bytes = true;
- fs->has_used_bytes = true;
- }
+ }
+ if (GetDiskFreeSpaceEx(fs->name,
+ (PULARGE_INTEGER) & i64FreeBytesToCaller,
+ (PULARGE_INTEGER) & i64TotalBytes,
+ (PULARGE_INTEGER) & i64FreeBytes)) {
+ fs->used_bytes = i64TotalBytes - i64FreeBytes;
+ fs->total_bytes = i64TotalBytes;
+ fs->has_total_bytes = true;
+ fs->has_used_bytes = true;
}
wcstombs(fs_name, wfs_name, sizeof(wfs_name));
fs->type = g_strdup(fs_name);
--
2.39.5 (Apple Git-154)
next reply other threads:[~2025-09-23 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 11:32 Minglei Liu [this message]
2025-09-24 8:09 ` [PATCH] qga: Improve Windows filesystem space info retrieval logic Kostiantyn Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923113243.78244-1-minglei.liu@smartx.com \
--to=minglei.liu@smartx.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).