* [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR
@ 2025-09-23 14:35 Huacai Chen
2025-09-23 14:35 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* Huacai Chen
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Huacai Chen @ 2025-09-23 14:35 UTC (permalink / raw)
To: Bibo Mao, Song Gao
Cc: Jiaxun Yang, WANG Xuerui, qemu-devel, Huacai Chen, Huacai Chen
Align VIRT_GED_CPUHP_ADDR to 4 bytes to avoid ACPI errors during boot.
Huacai Chen (3):
bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes
tests/data/acpi/loongarch64: Update expected DSDT.*
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
include/hw/loongarch/virt.h | 6 +++---
tests/data/acpi/loongarch64/virt/DSDT | Bin 4603 -> 4603 bytes
tests/data/acpi/loongarch64/virt/DSDT.memhp | Bin 5824 -> 5824 bytes
tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4609 bytes
tests/data/acpi/loongarch64/virt/DSDT.topology | Bin 4905 -> 4905 bytes
5 files changed, 3 insertions(+), 3 deletions(-)
--
2.7.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
2025-09-23 14:35 [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR Huacai Chen
@ 2025-09-23 14:35 ` Huacai Chen
2025-09-28 3:15 ` Bibo Mao
2025-09-23 14:35 ` [PATCH 2/3] hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes Huacai Chen
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Huacai Chen @ 2025-09-23 14:35 UTC (permalink / raw)
To: Bibo Mao, Song Gao; +Cc: Jiaxun Yang, WANG Xuerui, qemu-devel, Huacai Chen
Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
---
tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..2ed837faee 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,5 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/loongarch64/virt/DSDT",
+"tests/data/acpi/loongarch64/virt/DSDT.memhp",
+"tests/data/acpi/loongarch64/virt/DSDT.numamem",
+"tests/data/acpi/loongarch64/virt/DSDT.topology",
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes
2025-09-23 14:35 [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR Huacai Chen
2025-09-23 14:35 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* Huacai Chen
@ 2025-09-23 14:35 ` Huacai Chen
2025-09-24 7:20 ` Bibo Mao
2025-09-23 14:35 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* Huacai Chen
2025-10-09 7:31 ` [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR gaosong
3 siblings, 1 reply; 9+ messages in thread
From: Huacai Chen @ 2025-09-23 14:35 UTC (permalink / raw)
To: Bibo Mao, Song Gao
Cc: Jiaxun Yang, WANG Xuerui, qemu-devel, Huacai Chen,
Nathan Chancellor, WANG Rui
From: Huacai Chen <chenhuacai@loongson.cn>
Now VIRT_GED_CPUHP_ADDR is not aligned to 4 bytes, but if Linux kernel
is built with ACPI_MISALIGNMENT_NOT_SUPPORTED, it assumes the alignment,
otherwise we get ACPI errors at boot phase:
ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
ACPI Error: Method execution failed \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
VIRT_GED_MEM_ADDR and VIRT_GED_REG_ADDR are already aligned now, but use
QEMU_ALIGN_UP() to explicitly align them can make code more robust.
Reported-by: Nathan Chancellor <nathan@kernel.org>
Suggested-by: WANG Rui <wangrui@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
include/hw/loongarch/virt.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
index 602feab0f0..be4f5d603f 100644
--- a/include/hw/loongarch/virt.h
+++ b/include/hw/loongarch/virt.h
@@ -28,9 +28,9 @@
#define VIRT_LOWMEM_SIZE 0x10000000
#define VIRT_HIGHMEM_BASE 0x80000000
#define VIRT_GED_EVT_ADDR 0x100e0000
-#define VIRT_GED_MEM_ADDR (VIRT_GED_EVT_ADDR + ACPI_GED_EVT_SEL_LEN)
-#define VIRT_GED_REG_ADDR (VIRT_GED_MEM_ADDR + MEMORY_HOTPLUG_IO_LEN)
-#define VIRT_GED_CPUHP_ADDR (VIRT_GED_REG_ADDR + ACPI_GED_REG_COUNT)
+#define VIRT_GED_MEM_ADDR QEMU_ALIGN_UP(VIRT_GED_EVT_ADDR + ACPI_GED_EVT_SEL_LEN, 4)
+#define VIRT_GED_REG_ADDR QEMU_ALIGN_UP(VIRT_GED_MEM_ADDR + MEMORY_HOTPLUG_IO_LEN, 4)
+#define VIRT_GED_CPUHP_ADDR QEMU_ALIGN_UP(VIRT_GED_REG_ADDR + ACPI_GED_REG_COUNT, 4)
#define COMMAND_LINE_SIZE 512
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.*
2025-09-23 14:35 [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR Huacai Chen
2025-09-23 14:35 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* Huacai Chen
2025-09-23 14:35 ` [PATCH 2/3] hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes Huacai Chen
@ 2025-09-23 14:35 ` Huacai Chen
2025-09-24 7:26 ` Bibo Mao
2025-10-09 7:31 ` [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR gaosong
3 siblings, 1 reply; 9+ messages in thread
From: Huacai Chen @ 2025-09-23 14:35 UTC (permalink / raw)
To: Bibo Mao, Song Gao; +Cc: Jiaxun Yang, WANG Xuerui, qemu-devel, Huacai Chen
DSDT diffs from "iasl -d":
@@ -11,7 +11,7 @@
* Signature "DSDT"
* Length 0x000011FB (4603)
* Revision 0x01 **** 32-bit table (V1), no 64-bit math support
- * Checksum 0x5D
+ * Checksum 0x5B
* OEM ID "BOCHS "
* OEM Table ID "BXPC "
* OEM Revision 0x00000001 (1)
@@ -1426,11 +1426,11 @@
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
- 0x100E001F, // Address Base
+ 0x100E0020, // Address Base
0x0000000C, // Address Length
)
})
- OperationRegion (PRST, SystemMemory, 0x100E001F, 0x0C)
+ OperationRegion (PRST, SystemMemory, 0x100E0020, 0x0C)
Field (PRST, ByteAcc, NoLock, WriteAsZeros)
{
Offset (0x04),
Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
---
tests/data/acpi/loongarch64/virt/DSDT | Bin 4603 -> 4603 bytes
tests/data/acpi/loongarch64/virt/DSDT.memhp | Bin 5824 -> 5824 bytes
tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4609 bytes
.../data/acpi/loongarch64/virt/DSDT.topology | Bin 4905 -> 4905 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 4 ----
5 files changed, 4 deletions(-)
diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
index b31841aec6ed296f10ea1695a67ead38f45424d5..55aa34f988d6ef69293e91c5fe45bee0a02bc5f1 100644
GIT binary patch
delta 44
zcmeyZ{9BpJCD<k8w;%%pWAsL@BfP>2415AS3=9mF4ABh%LBSymJPMm1@=CD)02#3h
APXGV_
delta 44
zcmeyZ{9BpJCD<k8w;%%pW9&w*BfP@$415AS3=9mF4ABh%LBSymJo1|#@=CD)02$8<
APXGV_
diff --git a/tests/data/acpi/loongarch64/virt/DSDT.memhp b/tests/data/acpi/loongarch64/virt/DSDT.memhp
index e291200fc91caa3d93dcd6ec4736f7340f5e3f65..c0955eb60448cc5f4d38d410abc260ae54ea2e9a 100644
GIT binary patch
delta 44
zcmX@0dq9`VCD<k8fEWV<W5PzRW+7n(20j5E1_p*ohUkWXpx_V&9)-;dgcMi+`vnS0
delta 44
zcmX@0dq9`VCD<k8fEWV<W70;hW+7pD20j5E1_p*ohUkWXpx_V&9{J4+gcMi+`y&cU
diff --git a/tests/data/acpi/loongarch64/virt/DSDT.numamem b/tests/data/acpi/loongarch64/virt/DSDT.numamem
index 07923ac39584c5a5e73c9556d251814ce10de6cc..61e47e7252155dcf9c76879c4f60f4b3eef63f86 100644
GIT binary patch
delta 44
zcmZovX;k5I33dr#6k=dte72G62(PdL1D^m70|P@PLv%wxP;dwXkHY4Myb3G;-$V)Z
delta 44
zcmZovX;k5I33dr#6k=dte6f-12(Pd_1D^m70|P@PLv%wxP;dwXkNoC`yb3G;-(m^%
diff --git a/tests/data/acpi/loongarch64/virt/DSDT.topology b/tests/data/acpi/loongarch64/virt/DSDT.topology
index 6dfbb495f88b74b87849b58473e46717bc588a56..b2afebc938ce45d798c8aa5f45a463f1617e257e 100644
GIT binary patch
delta 44
zcmZ3fwo;ADCD<iIQ<#B)@!UqPBfP>2415AS3=9mF4ABh%LBSymJPMm1@_MiW0PuGT
Ag8%>k
delta 44
zcmZ3fwo;ADCD<iIQ<#B)@xn%~BfP@$415AS3=9mF4ABh%LBSymJo1|#@_MiW0PvLx
Ag8%>k
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 2ed837faee..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,5 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/loongarch64/virt/DSDT",
-"tests/data/acpi/loongarch64/virt/DSDT.memhp",
-"tests/data/acpi/loongarch64/virt/DSDT.numamem",
-"tests/data/acpi/loongarch64/virt/DSDT.topology",
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes
2025-09-23 14:35 ` [PATCH 2/3] hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes Huacai Chen
@ 2025-09-24 7:20 ` Bibo Mao
0 siblings, 0 replies; 9+ messages in thread
From: Bibo Mao @ 2025-09-24 7:20 UTC (permalink / raw)
To: Huacai Chen, Song Gao
Cc: Jiaxun Yang, WANG Xuerui, qemu-devel, Huacai Chen,
Nathan Chancellor, WANG Rui
On 2025/9/23 下午10:35, Huacai Chen wrote:
> From: Huacai Chen <chenhuacai@loongson.cn>
>
> Now VIRT_GED_CPUHP_ADDR is not aligned to 4 bytes, but if Linux kernel
> is built with ACPI_MISALIGNMENT_NOT_SUPPORTED, it assumes the alignment,
> otherwise we get ACPI errors at boot phase:
>
> ACPI Error: AE_AML_ALIGNMENT, Returned by Handler for [SystemMemory] (20250404/evregion-301)
> ACPI Error: Aborting method \_SB.CPUS.CSTA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> ACPI Error: Aborting method \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/psparse-529)
> ACPI Error: Method execution failed \_SB.CPUS.C000._STA due to previous error (AE_AML_ALIGNMENT) (20250404/uteval-68)
>
> VIRT_GED_MEM_ADDR and VIRT_GED_REG_ADDR are already aligned now, but use
> QEMU_ALIGN_UP() to explicitly align them can make code more robust.
>
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Suggested-by: WANG Rui <wangrui@loongson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> include/hw/loongarch/virt.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h
> index 602feab0f0..be4f5d603f 100644
> --- a/include/hw/loongarch/virt.h
> +++ b/include/hw/loongarch/virt.h
> @@ -28,9 +28,9 @@
> #define VIRT_LOWMEM_SIZE 0x10000000
> #define VIRT_HIGHMEM_BASE 0x80000000
> #define VIRT_GED_EVT_ADDR 0x100e0000
> -#define VIRT_GED_MEM_ADDR (VIRT_GED_EVT_ADDR + ACPI_GED_EVT_SEL_LEN)
> -#define VIRT_GED_REG_ADDR (VIRT_GED_MEM_ADDR + MEMORY_HOTPLUG_IO_LEN)
> -#define VIRT_GED_CPUHP_ADDR (VIRT_GED_REG_ADDR + ACPI_GED_REG_COUNT)
> +#define VIRT_GED_MEM_ADDR QEMU_ALIGN_UP(VIRT_GED_EVT_ADDR + ACPI_GED_EVT_SEL_LEN, 4)
> +#define VIRT_GED_REG_ADDR QEMU_ALIGN_UP(VIRT_GED_MEM_ADDR + MEMORY_HOTPLUG_IO_LEN, 4)
> +#define VIRT_GED_CPUHP_ADDR QEMU_ALIGN_UP(VIRT_GED_REG_ADDR + ACPI_GED_REG_COUNT, 4)
>
> #define COMMAND_LINE_SIZE 512
>
>
Reviewed-by: Bibo Mao <maobibo@loongson.cn>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.*
2025-09-23 14:35 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* Huacai Chen
@ 2025-09-24 7:26 ` Bibo Mao
2025-09-24 9:04 ` Michael S. Tsirkin
0 siblings, 1 reply; 9+ messages in thread
From: Bibo Mao @ 2025-09-24 7:26 UTC (permalink / raw)
To: Huacai Chen, Song Gao, Michael S. Tsirkin
Cc: Jiaxun Yang, WANG Xuerui, qemu-devel
Add Michael
On 2025/9/23 下午10:35, Huacai Chen wrote:
> DSDT diffs from "iasl -d":
>
> @@ -11,7 +11,7 @@
> * Signature "DSDT"
> * Length 0x000011FB (4603)
> * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
> - * Checksum 0x5D
> + * Checksum 0x5B
> * OEM ID "BOCHS "
> * OEM Table ID "BXPC "
> * OEM Revision 0x00000001 (1)
> @@ -1426,11 +1426,11 @@
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> Memory32Fixed (ReadWrite,
> - 0x100E001F, // Address Base
> + 0x100E0020, // Address Base
> 0x0000000C, // Address Length
> )
> })
> - OperationRegion (PRST, SystemMemory, 0x100E001F, 0x0C)
> + OperationRegion (PRST, SystemMemory, 0x100E0020, 0x0C)
> Field (PRST, ByteAcc, NoLock, WriteAsZeros)
> {
> Offset (0x04),
>
> Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
> ---
> tests/data/acpi/loongarch64/virt/DSDT | Bin 4603 -> 4603 bytes
> tests/data/acpi/loongarch64/virt/DSDT.memhp | Bin 5824 -> 5824 bytes
> tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4609 bytes
> .../data/acpi/loongarch64/virt/DSDT.topology | Bin 4905 -> 4905 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 4 ----
> 5 files changed, 4 deletions(-)
>
> diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
> index b31841aec6ed296f10ea1695a67ead38f45424d5..55aa34f988d6ef69293e91c5fe45bee0a02bc5f1 100644
> GIT binary patch
> delta 44
> zcmeyZ{9BpJCD<k8w;%%pWAsL@BfP>2415AS3=9mF4ABh%LBSymJPMm1@=CD)02#3h
> APXGV_
>
> delta 44
> zcmeyZ{9BpJCD<k8w;%%pW9&w*BfP@$415AS3=9mF4ABh%LBSymJo1|#@=CD)02$8<
> APXGV_
>
> diff --git a/tests/data/acpi/loongarch64/virt/DSDT.memhp b/tests/data/acpi/loongarch64/virt/DSDT.memhp
> index e291200fc91caa3d93dcd6ec4736f7340f5e3f65..c0955eb60448cc5f4d38d410abc260ae54ea2e9a 100644
> GIT binary patch
> delta 44
> zcmX@0dq9`VCD<k8fEWV<W5PzRW+7n(20j5E1_p*ohUkWXpx_V&9)-;dgcMi+`vnS0
>
> delta 44
> zcmX@0dq9`VCD<k8fEWV<W70;hW+7pD20j5E1_p*ohUkWXpx_V&9{J4+gcMi+`y&cU
>
> diff --git a/tests/data/acpi/loongarch64/virt/DSDT.numamem b/tests/data/acpi/loongarch64/virt/DSDT.numamem
> index 07923ac39584c5a5e73c9556d251814ce10de6cc..61e47e7252155dcf9c76879c4f60f4b3eef63f86 100644
> GIT binary patch
> delta 44
> zcmZovX;k5I33dr#6k=dte72G62(PdL1D^m70|P@PLv%wxP;dwXkHY4Myb3G;-$V)Z
>
> delta 44
> zcmZovX;k5I33dr#6k=dte6f-12(Pd_1D^m70|P@PLv%wxP;dwXkNoC`yb3G;-(m^%
>
> diff --git a/tests/data/acpi/loongarch64/virt/DSDT.topology b/tests/data/acpi/loongarch64/virt/DSDT.topology
> index 6dfbb495f88b74b87849b58473e46717bc588a56..b2afebc938ce45d798c8aa5f45a463f1617e257e 100644
> GIT binary patch
> delta 44
> zcmZ3fwo;ADCD<iIQ<#B)@!UqPBfP>2415AS3=9mF4ABh%LBSymJPMm1@_MiW0PuGT
> Ag8%>k
>
> delta 44
> zcmZ3fwo;ADCD<iIQ<#B)@xn%~BfP@$415AS3=9mF4ABh%LBSymJo1|#@_MiW0PvLx
> Ag8%>k
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 2ed837faee..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,5 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/loongarch64/virt/DSDT",
> -"tests/data/acpi/loongarch64/virt/DSDT.memhp",
> -"tests/data/acpi/loongarch64/virt/DSDT.numamem",
> -"tests/data/acpi/loongarch64/virt/DSDT.topology",
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.*
2025-09-24 7:26 ` Bibo Mao
@ 2025-09-24 9:04 ` Michael S. Tsirkin
0 siblings, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2025-09-24 9:04 UTC (permalink / raw)
To: Bibo Mao; +Cc: Huacai Chen, Song Gao, Jiaxun Yang, WANG Xuerui, qemu-devel
On Wed, Sep 24, 2025 at 03:26:13PM +0800, Bibo Mao wrote:
> Add Michael
>
> On 2025/9/23 下午10:35, Huacai Chen wrote:
> > DSDT diffs from "iasl -d":
> >
> > @@ -11,7 +11,7 @@
> > * Signature "DSDT"
> > * Length 0x000011FB (4603)
> > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
> > - * Checksum 0x5D
> > + * Checksum 0x5B
> > * OEM ID "BOCHS "
> > * OEM Table ID "BXPC "
> > * OEM Revision 0x00000001 (1)
> > @@ -1426,11 +1426,11 @@
> > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> > {
> > Memory32Fixed (ReadWrite,
> > - 0x100E001F, // Address Base
> > + 0x100E0020, // Address Base
> > 0x0000000C, // Address Length
> > )
> > })
> > - OperationRegion (PRST, SystemMemory, 0x100E001F, 0x0C)
> > + OperationRegion (PRST, SystemMemory, 0x100E0020, 0x0C)
> > Field (PRST, ByteAcc, NoLock, WriteAsZeros)
> > {
> > Offset (0x04),
> >
> > Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
this does what the patch says it does
Acked-by: Michael S. Tsirkin <mst@redhat.com>
up to maintainers to figure out if it's TRT
> > ---
> > tests/data/acpi/loongarch64/virt/DSDT | Bin 4603 -> 4603 bytes
> > tests/data/acpi/loongarch64/virt/DSDT.memhp | Bin 5824 -> 5824 bytes
> > tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4609 bytes
> > .../data/acpi/loongarch64/virt/DSDT.topology | Bin 4905 -> 4905 bytes
> > tests/qtest/bios-tables-test-allowed-diff.h | 4 ----
> > 5 files changed, 4 deletions(-)
> >
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT b/tests/data/acpi/loongarch64/virt/DSDT
> > index b31841aec6ed296f10ea1695a67ead38f45424d5..55aa34f988d6ef69293e91c5fe45bee0a02bc5f1 100644
> > GIT binary patch
> > delta 44
> > zcmeyZ{9BpJCD<k8w;%%pWAsL@BfP>2415AS3=9mF4ABh%LBSymJPMm1@=CD)02#3h
> > APXGV_
> >
> > delta 44
> > zcmeyZ{9BpJCD<k8w;%%pW9&w*BfP@$415AS3=9mF4ABh%LBSymJo1|#@=CD)02$8<
> > APXGV_
> >
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT.memhp b/tests/data/acpi/loongarch64/virt/DSDT.memhp
> > index e291200fc91caa3d93dcd6ec4736f7340f5e3f65..c0955eb60448cc5f4d38d410abc260ae54ea2e9a 100644
> > GIT binary patch
> > delta 44
> > zcmX@0dq9`VCD<k8fEWV<W5PzRW+7n(20j5E1_p*ohUkWXpx_V&9)-;dgcMi+`vnS0
> >
> > delta 44
> > zcmX@0dq9`VCD<k8fEWV<W70;hW+7pD20j5E1_p*ohUkWXpx_V&9{J4+gcMi+`y&cU
> >
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT.numamem b/tests/data/acpi/loongarch64/virt/DSDT.numamem
> > index 07923ac39584c5a5e73c9556d251814ce10de6cc..61e47e7252155dcf9c76879c4f60f4b3eef63f86 100644
> > GIT binary patch
> > delta 44
> > zcmZovX;k5I33dr#6k=dte72G62(PdL1D^m70|P@PLv%wxP;dwXkHY4Myb3G;-$V)Z
> >
> > delta 44
> > zcmZovX;k5I33dr#6k=dte6f-12(Pd_1D^m70|P@PLv%wxP;dwXkNoC`yb3G;-(m^%
> >
> > diff --git a/tests/data/acpi/loongarch64/virt/DSDT.topology b/tests/data/acpi/loongarch64/virt/DSDT.topology
> > index 6dfbb495f88b74b87849b58473e46717bc588a56..b2afebc938ce45d798c8aa5f45a463f1617e257e 100644
> > GIT binary patch
> > delta 44
> > zcmZ3fwo;ADCD<iIQ<#B)@!UqPBfP>2415AS3=9mF4ABh%LBSymJPMm1@_MiW0PuGT
> > Ag8%>k
> >
> > delta 44
> > zcmZ3fwo;ADCD<iIQ<#B)@xn%~BfP@$415AS3=9mF4ABh%LBSymJo1|#@_MiW0PvLx
> > Ag8%>k
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index 2ed837faee..dfb8523c8b 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1,5 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/loongarch64/virt/DSDT",
> > -"tests/data/acpi/loongarch64/virt/DSDT.memhp",
> > -"tests/data/acpi/loongarch64/virt/DSDT.numamem",
> > -"tests/data/acpi/loongarch64/virt/DSDT.topology",
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
2025-09-23 14:35 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* Huacai Chen
@ 2025-09-28 3:15 ` Bibo Mao
0 siblings, 0 replies; 9+ messages in thread
From: Bibo Mao @ 2025-09-28 3:15 UTC (permalink / raw)
To: Huacai Chen, Song Gao; +Cc: Jiaxun Yang, WANG Xuerui, qemu-devel
Reviewed-by: <maobibo@loongson.cn>
On 2025/9/23 下午10:35, Huacai Chen wrote:
> Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index dfb8523c8b..2ed837faee 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1 +1,5 @@
> /* List of comma-separated changed AML files to ignore */
> +"tests/data/acpi/loongarch64/virt/DSDT",
> +"tests/data/acpi/loongarch64/virt/DSDT.memhp",
> +"tests/data/acpi/loongarch64/virt/DSDT.numamem",
> +"tests/data/acpi/loongarch64/virt/DSDT.topology",
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR
2025-09-23 14:35 [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR Huacai Chen
` (2 preceding siblings ...)
2025-09-23 14:35 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* Huacai Chen
@ 2025-10-09 7:31 ` gaosong
3 siblings, 0 replies; 9+ messages in thread
From: gaosong @ 2025-10-09 7:31 UTC (permalink / raw)
To: Huacai Chen, Bibo Mao; +Cc: Jiaxun Yang, WANG Xuerui, qemu-devel, Huacai Chen
在 2025/9/23 下午10:35, Huacai Chen 写道:
> Align VIRT_GED_CPUHP_ADDR to 4 bytes to avoid ACPI errors during boot.
>
> Huacai Chen (3):
> bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.*
> hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes
> tests/data/acpi/loongarch64: Update expected DSDT.*
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> include/hw/loongarch/virt.h | 6 +++---
> tests/data/acpi/loongarch64/virt/DSDT | Bin 4603 -> 4603 bytes
> tests/data/acpi/loongarch64/virt/DSDT.memhp | Bin 5824 -> 5824 bytes
> tests/data/acpi/loongarch64/virt/DSDT.numamem | Bin 4609 -> 4609 bytes
> tests/data/acpi/loongarch64/virt/DSDT.topology | Bin 4905 -> 4905 bytes
> 5 files changed, 3 insertions(+), 3 deletions(-)
> --
> 2.7.0
Applied to loongarch-next
Thanks.
Song Gao
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-10-09 7:33 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-23 14:35 [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR Huacai Chen
2025-09-23 14:35 ` [PATCH 1/3] bios-tables-test-allowed-diff.h: Allow LoongArch DSDT.* Huacai Chen
2025-09-28 3:15 ` Bibo Mao
2025-09-23 14:35 ` [PATCH 2/3] hw/loongarch/virt: Align VIRT_GED_CPUHP_ADDR to 4 bytes Huacai Chen
2025-09-24 7:20 ` Bibo Mao
2025-09-23 14:35 ` [PATCH 3/3] tests/data/acpi/loongarch64: Update expected DSDT.* Huacai Chen
2025-09-24 7:26 ` Bibo Mao
2025-09-24 9:04 ` Michael S. Tsirkin
2025-10-09 7:31 ` [PATCH 0/3] LoongArch: Align VIRT_GED_CPUHP_ADDR gaosong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).