From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Tanish Desai" <tanishdesai37@gmail.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Mads Ynddal" <mads@ynddal.dk>
Subject: Re: [PATCH 16/16] tracetool/syslog: add Rust support
Date: Tue, 23 Sep 2025 15:37:21 -0400 [thread overview]
Message-ID: <20250923193721.GR509965@fedora> (raw)
In-Reply-To: <20250919112536.141782-17-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Fri, Sep 19, 2025 at 01:25:36PM +0200, Paolo Bonzini wrote:
> From: Tanish Desai <tanishdesai37@gmail.com>
>
> The syslog backend needs the syslog function from libc and the LOG_INFO enum
> value; they are re-exported as "::trace::syslog" and "::trace::LOG_INFO"
> so that device crates do not all have to add the libc dependency, but
> otherwise there is nothing special.
>
> Signed-off-by: Tanish Desai <tanishdesai37@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/Cargo.lock | 3 +++
> rust/trace/Cargo.toml | 3 +++
> rust/trace/src/lib.rs | 4 +++
> scripts/tracetool/backend/syslog.py | 7 ++++-
> tests/tracetool/syslog.rs | 40 +++++++++++++++++++++++++++++
> tests/tracetool/tracetool-test.py | 2 +-
> 6 files changed, 57 insertions(+), 2 deletions(-)
> create mode 100644 tests/tracetool/syslog.rs
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-09-23 19:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 11:25 [PATCH 00/16] tracetool: add Rust support Paolo Bonzini
2025-09-19 11:25 ` [PATCH 01/16] tracetool: fix usage of try_import() Paolo Bonzini
2025-09-23 19:06 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 02/16] tracetool: remove dead code Paolo Bonzini
2025-09-23 19:06 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 03/16] treewide: remove unnessary "coding" header Paolo Bonzini
2025-09-23 19:06 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 04/16] tracetool: add SPDX headers Paolo Bonzini
2025-09-23 19:06 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 05/16] trace/ftrace: move snprintf+write from tracepoints to ftrace.c Paolo Bonzini
2025-09-19 11:25 ` [PATCH 06/16] tracetool: add CHECK_TRACE_EVENT_GET_STATE Paolo Bonzini
2025-09-19 11:25 ` [PATCH 07/16] tracetool/backend: remove redundant trace event checks Paolo Bonzini
2025-09-19 11:25 ` [PATCH 08/16] tracetool: Add Rust format support Paolo Bonzini
2025-09-23 19:23 ` Stefan Hajnoczi
2025-09-24 7:13 ` Paolo Bonzini
2025-09-24 7:50 ` Daniel P. Berrangé
2025-09-24 11:49 ` Stefan Hajnoczi
2025-09-24 11:56 ` Daniel P. Berrangé
2025-09-24 18:10 ` Stefan Hajnoczi
2025-09-24 19:58 ` Paolo Bonzini
2025-09-25 11:50 ` Stefan Hajnoczi
2025-09-25 12:38 ` Paolo Bonzini
2025-09-25 15:09 ` Stefan Hajnoczi
2025-09-25 15:37 ` Paolo Bonzini
2025-09-25 17:16 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 09/16] rust: add trace crate Paolo Bonzini
2025-09-23 19:29 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 10/16] rust: qdev: add minimal clock bindings Paolo Bonzini
2025-09-23 19:31 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 11/16] rust: pl011: add tracepoints Paolo Bonzini
2025-09-23 19:04 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 12/16] tracetool/simple: add Rust support Paolo Bonzini
2025-09-23 19:35 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 13/16] log: change qemu_loglevel to unsigned Paolo Bonzini
2025-09-23 19:06 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 14/16] tracetool/log: add Rust support Paolo Bonzini
2025-09-23 19:36 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 15/16] tracetool/ftrace: " Paolo Bonzini
2025-09-23 19:36 ` Stefan Hajnoczi
2025-09-19 11:25 ` [PATCH 16/16] tracetool/syslog: " Paolo Bonzini
2025-09-23 19:37 ` Stefan Hajnoczi [this message]
2025-09-23 19:43 ` [PATCH 00/16] tracetool: " Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2025-09-29 15:49 [PATCH v2 " Paolo Bonzini
2025-09-29 15:49 ` [PATCH 16/16] tracetool/syslog: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923193721.GR509965@fedora \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=mads@ynddal.dk \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tanishdesai37@gmail.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).