From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
eric.auger@redhat.com, joao.m.martins@oracle.com,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: [PATCH 1/2] vfio/container: Support unmap all in one ioctl()
Date: Wed, 24 Sep 2025 03:02:53 -0400 [thread overview]
Message-ID: <20250924070254.1550014-2-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20250924070254.1550014-1-zhenzhong.duan@intel.com>
VFIO type1 kernel uAPI supports unmapping whole address space in one call
since commit c19650995374 ("vfio/type1: implement unmap all"). use the
unmap_all variant whenever it's supported in kernel.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
hw/vfio/container.c | 33 ++++++++++++++++++++-------------
1 file changed, 20 insertions(+), 13 deletions(-)
diff --git a/hw/vfio/container.c b/hw/vfio/container.c
index 030c6d3f89..2e13f04803 100644
--- a/hw/vfio/container.c
+++ b/hw/vfio/container.c
@@ -122,12 +122,12 @@ unmap_exit:
static int vfio_legacy_dma_unmap_one(const VFIOContainerBase *bcontainer,
hwaddr iova, ram_addr_t size,
- IOMMUTLBEntry *iotlb)
+ uint32_t flags, IOMMUTLBEntry *iotlb)
{
const VFIOContainer *container = VFIO_IOMMU_LEGACY(bcontainer);
struct vfio_iommu_type1_dma_unmap unmap = {
.argsz = sizeof(unmap),
- .flags = 0,
+ .flags = flags,
.iova = iova,
.size = size,
};
@@ -187,25 +187,32 @@ static int vfio_legacy_dma_unmap(const VFIOContainerBase *bcontainer,
hwaddr iova, ram_addr_t size,
IOMMUTLBEntry *iotlb, bool unmap_all)
{
+ uint32_t flags = 0;
int ret;
if (unmap_all) {
- /* The unmap ioctl doesn't accept a full 64-bit span. */
- Int128 llsize = int128_rshift(int128_2_64(), 1);
+ const VFIOContainer *container = VFIO_IOMMU_LEGACY(bcontainer);
- ret = vfio_legacy_dma_unmap_one(bcontainer, 0, int128_get64(llsize),
- iotlb);
+ assert(!iova && !size);
- if (ret == 0) {
- ret = vfio_legacy_dma_unmap_one(bcontainer, int128_get64(llsize),
- int128_get64(llsize), iotlb);
- }
+ ret = ioctl(container->fd, VFIO_CHECK_EXTENSION, VFIO_UNMAP_ALL);
+ if (ret) {
+ flags = VFIO_DMA_UNMAP_FLAG_ALL;
+ } else {
+ /* The unmap ioctl doesn't accept a full 64-bit span. */
+ Int128 llsize = int128_rshift(int128_2_64(), 1);
+ size = int128_get64(llsize);
+
+ ret = vfio_legacy_dma_unmap_one(bcontainer, 0, size, flags, iotlb);
+ if (ret) {
+ return ret;
+ }
- } else {
- ret = vfio_legacy_dma_unmap_one(bcontainer, iova, size, iotlb);
+ iova = size;
+ }
}
- return ret;
+ return vfio_legacy_dma_unmap_one(bcontainer, iova, size, flags, iotlb);
}
static int vfio_legacy_dma_map(const VFIOContainerBase *bcontainer, hwaddr iova,
--
2.47.1
next prev parent reply other threads:[~2025-09-24 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 7:02 [PATCH 0/2] Optimize unmap_all with one ioctl() Zhenzhong Duan
2025-09-24 7:02 ` Zhenzhong Duan [this message]
2025-09-30 15:26 ` [PATCH 1/2] vfio/container: Support unmap all in " Cédric Le Goater
2025-09-30 22:04 ` John Levon
2025-10-01 6:58 ` Cédric Le Goater
2025-10-08 10:18 ` Duan, Zhenzhong
2025-10-08 13:01 ` Cédric Le Goater
2025-10-08 13:11 ` John Levon
2025-10-08 13:26 ` Cédric Le Goater
2025-10-08 10:17 ` Duan, Zhenzhong
2025-09-24 7:02 ` [PATCH 2/2] vfio/iommufd: " Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924070254.1550014-2-zhenzhong.duan@intel.com \
--to=zhenzhong.duan@intel.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).