From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
eric.auger@redhat.com, steven.sistare@oracle.com,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: [PATCH 2/5] vfio/cpr-legacy: drop an erroneous assert
Date: Thu, 25 Sep 2025 22:23:45 -0400 [thread overview]
Message-ID: <20250926022348.1883776-3-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20250926022348.1883776-1-zhenzhong.duan@intel.com>
vfio_legacy_cpr_dma_map() is not only used in post_load on destination
but also error recovery path on source side. Assert it for destination
is wrong.
Fixes: 7e9f21411302 ("vfio/container: restore DMA vaddr")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
hw/vfio/cpr-legacy.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/vfio/cpr-legacy.c b/hw/vfio/cpr-legacy.c
index 3ea24d60de..19fd8b60d3 100644
--- a/hw/vfio/cpr-legacy.c
+++ b/hw/vfio/cpr-legacy.c
@@ -51,8 +51,6 @@ static int vfio_legacy_cpr_dma_map(const VFIOContainerBase *bcontainer,
.size = size,
};
- g_assert(cpr_is_incoming());
-
if (ioctl(container->fd, VFIO_IOMMU_MAP_DMA, &map)) {
return -errno;
}
--
2.47.1
next prev parent reply other threads:[~2025-09-26 2:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 2:23 [PATCH 0/5] VFIO: cpr-transfer fixes Zhenzhong Duan
2025-09-26 2:23 ` [PATCH 1/5] vfio/container: Remap only populated parts in a section Zhenzhong Duan
2025-09-26 13:25 ` Steven Sistare
2025-09-26 2:23 ` Zhenzhong Duan [this message]
2025-09-26 13:25 ` [PATCH 2/5] vfio/cpr-legacy: drop an erroneous assert Steven Sistare
2025-09-26 2:23 ` [PATCH 3/5] vfio/iommufd: Save cpr.ioas_id on source side for CPR transfer Zhenzhong Duan
2025-09-26 13:55 ` Steven Sistare
2025-09-26 2:23 ` [PATCH 4/5] vfio/iommufd: Restore vbasedev's reference to hwpt after " Zhenzhong Duan
2025-09-26 14:22 ` Steven Sistare
2025-09-27 16:09 ` [PATCH 0/5] VFIO: cpr-transfer fixes Cédric Le Goater
2025-09-28 8:15 ` Duan, Zhenzhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926022348.1883776-3-zhenzhong.duan@intel.com \
--to=zhenzhong.duan@intel.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=eric.auger@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).